)]}'
{"id":"openocd~master~I2763d93095e3db7590644652f16b7b24939d6cae","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002274":{"account":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"last_update":"2024-06-08 08:44:04.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-24 12:55:37.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-05-22 05:00:54.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I2763d93095e3db7590644652f16b7b24939d6cae","subject":"tcl/chip/st/spear: fix syntax errors","status":"MERGED","created":"2024-05-16 02:53:38.000000000","updated":"2024-06-08 08:44:04.000000000","submitted":"2024-06-08 08:44:04.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"8281","meta_rev_id":"8f61a99e2be7e59bbc76732b9fdb60c0fdda0e96","_number":8281,"owner":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 08:44:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-08 08:44:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 08:44:04.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-16 03:26:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-18 03:03:36.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2024-05-21 09:04:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-05-22 05:00:54.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-05-24 12:55:37.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"6ebd25e3dbaa00397b3bdfe09c5c459c5ab4723d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-16 02:53:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8acf96c9fc9a2bf5cb03095991ab30680836b110","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-16 03:26:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19578/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18738/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"05cbc014dfa2fdb0c147b9958bfd5c4ed07e2d12","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-05-18 03:03:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"763d77e6a4054e2fa1836d0432eb16f42129862e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-21 09:04:54.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d26ea6b7c7a022e51f4933b5ec189260853697e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-22 00:28:10.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f38d0d77b4791349cd2806be47b4f6d872afcab7","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-22 00:35:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0fec0046119709d3fceab306c4dd3745c9b39e27","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-22 01:14:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19601/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18762/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"f625bd71884f6ebee1c70acb140eb5d597e7fd1c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-05-22 05:00:54.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bf8d3d59edd15aee5c073573d53cd26c01c65694","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-24 12:55:37.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e1c608b0681d905ca483a3b6ed93f25b8376f8eb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:44:01.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8f61a99e2be7e59bbc76732b9fdb60c0fdda0e96","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:44:04.000000000","message":"Change has been successfully cherry-picked as 7050cade9dcea77dd9882669ea97fddc6a8084d4","accounts_in_message":[],"_revision_number":3}],"current_revision":"7050cade9dcea77dd9882669ea97fddc6a8084d4","revisions":{"47a5429e71ef9e99c2a35bab1e74b4a0a422a2d5":{"kind":"REWORK","_number":1,"created":"2024-05-16 02:53:38.000000000","uploader":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"ref":"refs/changes/81/8281/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/8281/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/1 \u0026\u0026 git checkout -b change-8281 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/8281/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"780289563c9772be2557cf42c634994677282a21","subject":"tcl/target/c100helper: fix syntax errors"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:49:23.000000000","tz":-240},"committer":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:53:24.000000000","tz":-240},"subject":"tcl/chip/st/spear: fix syntax errors","message":"tcl/chip/st/spear: fix syntax errors\n\nChange-Id: I2763d93095e3db7590644652f16b7b24939d6cae\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\n"}},"7050cade9dcea77dd9882669ea97fddc6a8084d4":{"kind":"REWORK","_number":3,"created":"2024-06-08 08:44:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/81/8281/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/8281/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/3 \u0026\u0026 git checkout -b change-8281 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/8281/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"223e3d8fe76d86f01111bbe37f83a19d719ac81a","subject":"tcl/target/c100helper: fix syntax errors"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:49:23.000000000","tz":-240},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-08 08:44:04.000000000","tz":0},"subject":"tcl/chip/st/spear: fix syntax errors","message":"tcl/chip/st/spear: fix syntax errors\n\nWhile the current jimtcl does not consider this an error, the Tcl\ndodekalogue states that strings terminate at the second double quote\ncharacter (see https://www.tcl.tk/man/tcl/TclCmd/Tcl.htm#M8).\n\nThese syntax errors were caught by tclint v0.2.5\n(https://github.com/nmoroze/tclint):\n\n```\ntclint tcl/chip/st/spear/spear3xx_ddr.tcl | grep \"syntax error\"\n```\n\nChange-Id: I2763d93095e3db7590644652f16b7b24939d6cae\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8281\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"c482e8984b762fb72e76141f44de06d03cfda599":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-22 00:28:10.000000000","uploader":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"ref":"refs/changes/81/8281/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/8281/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/2 \u0026\u0026 git checkout -b change-8281 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/8281/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/8281/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa7e6a5d65f47803d468a2552dd8e92223c83ca1","subject":"tcl/target/c100helper: fix syntax errors"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:49:23.000000000","tz":-240},"committer":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-22 00:21:07.000000000","tz":-240},"subject":"tcl/chip/st/spear: fix syntax errors","message":"tcl/chip/st/spear: fix syntax errors\n\nWhile the current jimtcl does not consider this an error, the Tcl\ndodekalogue states that strings terminate at the second double quote\ncharacter (see https://www.tcl.tk/man/tcl/TclCmd/Tcl.htm#M8).\n\nThese syntax errors were caught by tclint v0.2.5\n(https://github.com/nmoroze/tclint):\n\n```\ntclint tcl/chip/st/spear/spear3xx_ddr.tcl | grep \"syntax error\"\n```\n\nChange-Id: I2763d93095e3db7590644652f16b7b24939d6cae\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}