)]}'
{"id":"openocd~master~I759461e5f89ca48a6e16e4b4101570260421dba1","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002275":{"account":{"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"},"last_update":"2024-05-27 08:17:44.000000000","reason":"\u003cGERRIT_ACCOUNT_1002275\u003e replied on the change","reason_account":{"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-06-17 14:04:49.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-06-26 19:08:51.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I759461e5f89ca48a6e16e4b4101570260421dba1","subject":"target/cortex_m: allow poll quickly get out of TARGET_RESET state","status":"MERGED","created":"2024-05-17 19:51:44.000000000","updated":"2024-07-15 10:15:44.000000000","submitted":"2024-06-17 14:04:49.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":8,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"8285","meta_rev_id":"90b41e71dda2757b1ba291f71e5e68871070424d","_number":8285,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-17 14:04:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-17 14:04:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-17 14:04:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}],"reviewers":{"CC":[{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-17 20:15:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-19 11:19:34.000000000","updated_by":{"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"},"reviewer":{"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"},"state":"REVIEWER"},{"updated":"2024-05-27 10:21:02.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-06-26 13:42:01.000000000","updated_by":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"CC"}],"messages":[{"id":"ee57268d0c90fcacc1c1b1491dcc412c982c0ab1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-05-17 19:51:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69bf3ab520dd0e7f37b05efb445b72936ecbb775","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-17 20:15:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19583/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18743/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4f88a322ef1871abb06931460447933a02823965","author":{"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"},"real_author":{"_account_id":1002275,"name":"Dhruva Gole","email":"d-gole@ti.com","username":"DhruvaG2000"},"date":"2024-05-27 08:17:44.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"16ed89e065cc3f926c276714cc1a03f68302091b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-09 13:05:31.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"75f86b6d06a80bf6ad55fdaab7fc75fce8cf0796","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-17 14:04:49.000000000","message":"Change has been successfully cherry-picked as 4892e32294c6ea4cf53251adb81dee4e85aee0b0","accounts_in_message":[],"_revision_number":2},{"id":"e222486882ee45193b58b1393ce3b3f8b335c379","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2024-06-26 13:42:01.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4905e5ab6f45b781ed892446b66116b4a16d4874","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-26 16:03:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b468e065f7988954ff3945fec82c97185ca42403","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2024-06-26 16:44:53.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"4c1063ebe8e4594fae99d84d13f518de1ee0b306","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-26 19:08:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"de6cb572bf01b4c181f5833eadbdd73f0f3e4500","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-15 09:34:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"90b41e71dda2757b1ba291f71e5e68871070424d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-15 10:15:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"4892e32294c6ea4cf53251adb81dee4e85aee0b0","revisions":{"f2c30d128044a76fc44631eb45aaa83a4d723907":{"kind":"REWORK","_number":1,"created":"2024-05-17 19:51:44.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/85/8285/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/8285/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/1 \u0026\u0026 git checkout -b change-8285 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/8285/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-05-17 19:27:24.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-05-17 19:27:24.000000000","tz":120},"subject":"target/cortex_m: allow poll quickly get out of TARGET_RESET state","message":"target/cortex_m: allow poll quickly get out of TARGET_RESET state\n\ncortex_m_poll_one() detects reset testing S_RESET_ST sticky bit.\nIf the signal comes unexpectedly, poll must return TARGET_RESET state.\n\nOn the contrary in case of polling inside of an OpenOCD reset command,\nTARGET_RESET has been has already been set and we need to get out of\nit as quickly as possible.\n\nThe original code needs 2 polls: the first clears S_RESET_ST\nand keeps TARGET_RESET state, the current TARGET_RUNNING or TARGET_HALTED\nis reflected as late as the second poll is done.\n\nChange the logic to keep in TARGET_RESET only when necessary.\n\nSee also [1]\n\nLink: [1] 8284: tcl/target: ti_cc3220sf: Use halt for CC3320SF targets | https://review.openocd.org/c/openocd/+/8284\nFixes: https://sourceforge.net/p/openocd/tickets/360/\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I759461e5f89ca48a6e16e4b4101570260421dba1\n"}},"4892e32294c6ea4cf53251adb81dee4e85aee0b0":{"kind":"REWORK","_number":2,"created":"2024-06-17 14:04:49.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/85/8285/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/8285/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/2 \u0026\u0026 git checkout -b change-8285 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/8285/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/8285/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bf4be566a7e7f510977533a0402716d92f208f95","subject":"pld: small documentation fixes."}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-05-17 19:27:24.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-06-17 14:04:49.000000000","tz":0},"subject":"target/cortex_m: allow poll quickly get out of TARGET_RESET state","message":"target/cortex_m: allow poll quickly get out of TARGET_RESET state\n\ncortex_m_poll_one() detects reset testing S_RESET_ST sticky bit.\nIf the signal comes unexpectedly, poll must return TARGET_RESET state.\n\nOn the contrary in case of polling inside of an OpenOCD reset command,\nTARGET_RESET has been has already been set and we need to get out of\nit as quickly as possible.\n\nThe original code needs 2 polls: the first clears S_RESET_ST\nand keeps TARGET_RESET state, the current TARGET_RUNNING or TARGET_HALTED\nis reflected as late as the second poll is done.\n\nChange the logic to keep in TARGET_RESET only when necessary.\n\nSee also [1]\n\nLink: [1] 8284: tcl/target: ti_cc3220sf: Use halt for CC3320SF targets | https://review.openocd.org/c/openocd/+/8284\nFixes: https://sourceforge.net/p/openocd/tickets/360/\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I759461e5f89ca48a6e16e4b4101570260421dba1\nReviewed-on: https://review.openocd.org/c/openocd/+/8285\nTested-by: jenkins\nReviewed-by: Dhruva Gole \u003cd-gole@ti.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}