)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5cf98fa58f3f4bb3e69495bacf11a6671c251f34","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ae30a765_90638867","updated":"2024-05-31 07:59:09.000000000","message":"The original code that is being modified in this patch is somewhat misleading, and so it is not immediately clear that read_memory_bus_v0() and read_memory_abstract() do not support increment \u003d\u003d 0.\n\nPlease, see my comments.\n\nThank you.","commit_id":"31e96729812eb18b3fceb3892bdf24359e8580b4"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"c0c5fcf940b996d55e384141d46f3da76670ceeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c194aad0_0452cb8b","in_reply_to":"ae30a765_90638867","updated":"2024-06-02 16:46:54.000000000","message":"Done","commit_id":"31e96729812eb18b3fceb3892bdf24359e8580b4"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"ab9ff6f3c55f38384322077198dc9e1d2fb0ca2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b8bfb249_6debe589","updated":"2024-06-03 05:25:47.000000000","message":"Checked visually, LGTM, thank you.","commit_id":"8198a7c803dbb458b852ec6f761dda6d80e6ddcd"}],"src/target/riscv/riscv-013.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5cf98fa58f3f4bb3e69495bacf11a6671c251f34","unresolved":true,"context_lines":[{"line_number":3564,"context_line":"\t\t\t\tcontinue;"},{"line_number":3565,"context_line":""},{"line_number":3566,"context_line":"\t\t\tif (get_field(info-\u003esbcs, DM_SBCS_SBVERSION) \u003d\u003d 0)"},{"line_number":3567,"context_line":"\t\t\t\tret \u003d read_memory_bus_v0(target, address, size, count, buffer, addr_autoincr ? size : 0);"},{"line_number":3568,"context_line":"\t\t\telse if (get_field(info-\u003esbcs, DM_SBCS_SBVERSION) \u003d\u003d 1)"},{"line_number":3569,"context_line":"\t\t\t\tret \u003d read_memory_bus_v1(target, address, size, count, buffer, addr_autoincr ? size : 0);"},{"line_number":3570,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"c94f193f_c1e407b2","line":3567,"updated":"2024-05-31 07:59:09.000000000","message":"Please, if you can update the code so that read_memory_bus_v0 is not called with increment \u003d\u003d 0. The function does not support this mode of operation.","commit_id":"31e96729812eb18b3fceb3892bdf24359e8580b4"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"c0c5fcf940b996d55e384141d46f3da76670ceeb","unresolved":false,"context_lines":[{"line_number":3564,"context_line":"\t\t\t\tcontinue;"},{"line_number":3565,"context_line":""},{"line_number":3566,"context_line":"\t\t\tif (get_field(info-\u003esbcs, DM_SBCS_SBVERSION) \u003d\u003d 0)"},{"line_number":3567,"context_line":"\t\t\t\tret \u003d read_memory_bus_v0(target, address, size, count, buffer, addr_autoincr ? size : 0);"},{"line_number":3568,"context_line":"\t\t\telse if (get_field(info-\u003esbcs, DM_SBCS_SBVERSION) \u003d\u003d 1)"},{"line_number":3569,"context_line":"\t\t\t\tret \u003d read_memory_bus_v1(target, address, size, count, buffer, addr_autoincr ? size : 0);"},{"line_number":3570,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"1b159b0d_b28f2f35","line":3567,"in_reply_to":"c94f193f_c1e407b2","updated":"2024-06-02 16:46:54.000000000","message":"Done","commit_id":"31e96729812eb18b3fceb3892bdf24359e8580b4"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5cf98fa58f3f4bb3e69495bacf11a6671c251f34","unresolved":true,"context_lines":[{"line_number":3574,"context_line":"\t\t\tif (mem_should_skip_abstract(target, address, size, addr_autoincr ? size : 0, true, \u0026abstract_result))"},{"line_number":3575,"context_line":"\t\t\t\tcontinue;"},{"line_number":3576,"context_line":""},{"line_number":3577,"context_line":"\t\t\tret \u003d read_memory_abstract(target, address, size, count, buffer, addr_autoincr ? size : 0);"},{"line_number":3578,"context_line":""},{"line_number":3579,"context_line":"\t\t\tif (ret !\u003d ERROR_OK)"},{"line_number":3580,"context_line":"\t\t\t\tabstract_result \u003d \"failed\";"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"07414fab_221507b1","line":3577,"updated":"2024-05-31 07:59:09.000000000","message":"read_memory_abstract() does not support increment, even though the parameter is there. I\u0027m sorry for this misleading code.\n\nTo resolve it, please if you can:\n- copy the increment check from read_memory_bus_v0() also to read_memory_abstract()\n- avoid calling read_memory_abstract() with increment !\u003d size","commit_id":"31e96729812eb18b3fceb3892bdf24359e8580b4"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"c0c5fcf940b996d55e384141d46f3da76670ceeb","unresolved":false,"context_lines":[{"line_number":3574,"context_line":"\t\t\tif (mem_should_skip_abstract(target, address, size, addr_autoincr ? size : 0, true, \u0026abstract_result))"},{"line_number":3575,"context_line":"\t\t\t\tcontinue;"},{"line_number":3576,"context_line":""},{"line_number":3577,"context_line":"\t\t\tret \u003d read_memory_abstract(target, address, size, count, buffer, addr_autoincr ? size : 0);"},{"line_number":3578,"context_line":""},{"line_number":3579,"context_line":"\t\t\tif (ret !\u003d ERROR_OK)"},{"line_number":3580,"context_line":"\t\t\t\tabstract_result \u003d \"failed\";"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"60b6a0a4_9ac0bb9a","line":3577,"in_reply_to":"07414fab_221507b1","updated":"2024-06-02 16:46:54.000000000","message":"Done","commit_id":"31e96729812eb18b3fceb3892bdf24359e8580b4"}]}