)]}'
{"id":"openocd~master~I99024194b6687b88d354ef278aa25f372c862c22","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002279":{"account":{"_account_id":1002279,"name":"Mark Featherston","email":"mark@embeddedts.com","username":"markfeatherston","status":"embeddedTS"},"last_update":"2024-06-08 08:45:04.000000000","reason":"Change was submitted"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-05-25 15:38:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1000853\u003e replied on the change","reason_account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-25 09:21:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I99024194b6687b88d354ef278aa25f372c862c22","subject":"jtag/drivers/ftdi: Use command_print instead of LOG_USER for get_signal","status":"MERGED","created":"2024-05-23 20:37:11.000000000","updated":"2024-06-08 08:45:04.000000000","submitted":"2024-06-08 08:45:04.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8294","meta_rev_id":"4efdfe81b460971b47089e0af8015f0b0d4395bf","_number":8294,"owner":{"_account_id":1002279,"name":"Mark Featherston","email":"mark@embeddedts.com","username":"markfeatherston","status":"embeddedTS"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 08:45:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 08:45:04.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-08 08:45:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-23 21:01:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-24 09:39:40.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-05-24 18:06:25.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"CC"},{"updated":"2024-05-25 15:38:38.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"70e3136d5395876bd49933f771a2221a362eac1a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002279,"name":"Mark Featherston","email":"mark@embeddedts.com","username":"markfeatherston","status":"embeddedTS"},"real_author":{"_account_id":1002279,"name":"Mark Featherston","email":"mark@embeddedts.com","username":"markfeatherston","status":"embeddedTS"},"date":"2024-05-23 20:37:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a66db37750eef8c31b5266f538161583dfbe91d8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-23 21:01:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19606/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18766/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"dc989f73c1959e606b21582654140971fe5786ec","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-24 09:39:40.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4554fce2497bbdc9d25cf49c01441a8d94fc0c7a","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-24 18:06:25.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0de936a3508a46984f5b4045c0b46f4b2394af71","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002279,"name":"Mark Featherston","email":"mark@embeddedts.com","username":"markfeatherston","status":"embeddedTS"},"real_author":{"_account_id":1002279,"name":"Mark Featherston","email":"mark@embeddedts.com","username":"markfeatherston","status":"embeddedTS"},"date":"2024-05-24 21:23:36.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"2274b5b11300585e048afb140027399f69b9ff89","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-24 21:37:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19614/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18774/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d0fd36bf8fbb006cdd4babb9d6042916af5fc594","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-25 09:21:21.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"93acbb5e1180c376729696cc3c2a6cd56413d306","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-25 15:38:38.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"08b34b98b12727c9049dc5d57be1f1c0a73b7d64","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:45:00.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4efdfe81b460971b47089e0af8015f0b0d4395bf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:45:04.000000000","message":"Change has been successfully cherry-picked as 9623069e8090fbbf80250836e82feaecdb65233e","accounts_in_message":[],"_revision_number":3}],"current_revision":"9623069e8090fbbf80250836e82feaecdb65233e","revisions":{"f4a3acc8962ed28c21e0a0bcd2504e8e4b5984e3":{"kind":"REWORK","_number":2,"created":"2024-05-24 21:23:36.000000000","uploader":{"_account_id":1002279,"name":"Mark Featherston","email":"mark@embeddedts.com","username":"markfeatherston","status":"embeddedTS"},"ref":"refs/changes/94/8294/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/8294/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/2 \u0026\u0026 git checkout -b change-8294 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/8294/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Mark Featherston","email":"mark@embeddedts.com","date":"2024-05-23 20:24:32.000000000","tz":-420},"committer":{"name":"Mark Featherston","email":"mark@embeddedts.com","date":"2024-05-24 21:20:21.000000000","tz":-420},"subject":"jtag/drivers/ftdi: Use command_print instead of LOG_USER for get_signal","message":"jtag/drivers/ftdi: Use command_print instead of LOG_USER for get_signal\n\nLOG_USER only outputs to user interfaces, but leaves no way to get the\nFTDI inputs over the RPC interface. Switch to command_print so this\nstring goes to both logs and the RPC interface.\n\nChange-Id: I99024194b6687b88d354ef278aa25f372c862c22\nSigned-off-by: Mark Featherston \u003cmark@embeddedts.com\u003e\n"}},"9623069e8090fbbf80250836e82feaecdb65233e":{"kind":"REWORK","_number":3,"created":"2024-06-08 08:45:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/8294/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/8294/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/3 \u0026\u0026 git checkout -b change-8294 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/8294/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"72b39088ee1772a65e74004fdc096db09edf8c0c","subject":"target: reset examine after assert_reset"}],"author":{"name":"Mark Featherston","email":"mark@embeddedts.com","date":"2024-05-23 20:24:32.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-08 08:45:04.000000000","tz":0},"subject":"jtag/drivers/ftdi: Use command_print instead of LOG_USER for get_signal","message":"jtag/drivers/ftdi: Use command_print instead of LOG_USER for get_signal\n\nLOG_USER only outputs to user interfaces, but leaves no way to get the\nFTDI inputs over the RPC interface. Switch to command_print so this\nstring goes to both logs and the RPC interface.\n\nChange-Id: I99024194b6687b88d354ef278aa25f372c862c22\nSigned-off-by: Mark Featherston \u003cmark@embeddedts.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8294\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\n"}},"45a8bbad042640702da238721640d465520330fe":{"kind":"REWORK","_number":1,"created":"2024-05-23 20:37:11.000000000","uploader":{"_account_id":1002279,"name":"Mark Featherston","email":"mark@embeddedts.com","username":"markfeatherston","status":"embeddedTS"},"ref":"refs/changes/94/8294/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/8294/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/1 \u0026\u0026 git checkout -b change-8294 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/8294/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/8294/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Mark Featherston","email":"mark@embeddedts.com","date":"2024-05-23 20:24:32.000000000","tz":-420},"committer":{"name":"Mark Featherston","email":"mark@embeddedts.com","date":"2024-05-23 20:36:58.000000000","tz":-420},"subject":"jtag/drivers/ftdi: Use command_print instead of LOG_USER for get_signal","message":"jtag/drivers/ftdi: Use command_print instead of LOG_USER for get_signal\n\nLOG_USER only outputs to user interfaces, but leaves no way to get the\nFTDI inputs over the RPC interface. Switch to command_print so this\nstring goes to both logs and the RPC interface.\n\nChange-Id: I99024194b6687b88d354ef278aa25f372c862c22\nSigned-off-by: Mark Featherston \u003cmark@embeddedts.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}