)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3bc19b9b85c3e60881f63672486fd2d0ec1b8681","unresolved":true,"context_lines":[{"line_number":7,"context_line":"target/riscv: hide_csrs configuration option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option allows users to mark certain CSRs as hidden so they could be"},{"line_number":10,"context_line":"expluded from *reg* output and target.xml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is based on the work by Anatoly Parshintsev \u003c114445139+aap-sc@users.noreply.github.com\u003e"},{"line_number":13,"context_line":"and Jan Matyas \u003c50193733+JanMatCodasip@users.noreply.github.com\u003e in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5c29842a_b50ae391","line":10,"updated":"2024-05-25 17:02:14.000000000","message":"typo s/expluded/excluded/","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"27de4034d658934af617a6a5d3f978dfb5e44313","unresolved":false,"context_lines":[{"line_number":7,"context_line":"target/riscv: hide_csrs configuration option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option allows users to mark certain CSRs as hidden so they could be"},{"line_number":10,"context_line":"expluded from *reg* output and target.xml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is based on the work by Anatoly Parshintsev \u003c114445139+aap-sc@users.noreply.github.com\u003e"},{"line_number":13,"context_line":"and Jan Matyas \u003c50193733+JanMatCodasip@users.noreply.github.com\u003e in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7bd89680_8d264d31","line":10,"in_reply_to":"5c29842a_b50ae391","updated":"2024-05-26 09:42:29.000000000","message":"Done","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"d5146b6b3a3e1ca911ea88b11ba9ec9e94b7f367","unresolved":false,"context_lines":[{"line_number":7,"context_line":"target/riscv: hide_csrs configuration option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option allows users to mark certain CSRs as hidden so they could be"},{"line_number":10,"context_line":"expluded from *reg* output and target.xml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is based on the work by Anatoly Parshintsev \u003c114445139+aap-sc@users.noreply.github.com\u003e"},{"line_number":13,"context_line":"and Jan Matyas \u003c50193733+JanMatCodasip@users.noreply.github.com\u003e in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a6a23577_8787d41e","line":10,"in_reply_to":"5c29842a_b50ae391","updated":"2024-06-09 14:05:14.000000000","message":"Done","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3bc19b9b85c3e60881f63672486fd2d0ec1b8681","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This option allows users to mark certain CSRs as hidden so they could be"},{"line_number":10,"context_line":"expluded from *reg* output and target.xml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is based on the work by Anatoly Parshintsev \u003c114445139+aap-sc@users.noreply.github.com\u003e"},{"line_number":13,"context_line":"and Jan Matyas \u003c50193733+JanMatCodasip@users.noreply.github.com\u003e in the"},{"line_number":14,"context_line":"RISC-V fork of OpenOCD."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8b4a166c933e7de752b193a855afe24ac51356de"},{"line_number":17,"context_line":"Signed-off-by: Bernhard Rosenkränzer \u003cbero@baylibre.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4a26811b_e89503fb","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":6},"updated":"2024-05-25 17:02:14.000000000","message":"these two lines are too long. Drop the email address and keep only the names. The emails are already below in the Signed-off-by","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"d5146b6b3a3e1ca911ea88b11ba9ec9e94b7f367","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This option allows users to mark certain CSRs as hidden so they could be"},{"line_number":10,"context_line":"expluded from *reg* output and target.xml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is based on the work by Anatoly Parshintsev \u003c114445139+aap-sc@users.noreply.github.com\u003e"},{"line_number":13,"context_line":"and Jan Matyas \u003c50193733+JanMatCodasip@users.noreply.github.com\u003e in the"},{"line_number":14,"context_line":"RISC-V fork of OpenOCD."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8b4a166c933e7de752b193a855afe24ac51356de"},{"line_number":17,"context_line":"Signed-off-by: Bernhard Rosenkränzer \u003cbero@baylibre.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"96b0539c_9ce8fe65","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":6},"in_reply_to":"4a26811b_e89503fb","updated":"2024-06-09 14:05:14.000000000","message":"Done","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"27de4034d658934af617a6a5d3f978dfb5e44313","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This option allows users to mark certain CSRs as hidden so they could be"},{"line_number":10,"context_line":"expluded from *reg* output and target.xml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is based on the work by Anatoly Parshintsev \u003c114445139+aap-sc@users.noreply.github.com\u003e"},{"line_number":13,"context_line":"and Jan Matyas \u003c50193733+JanMatCodasip@users.noreply.github.com\u003e in the"},{"line_number":14,"context_line":"RISC-V fork of OpenOCD."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8b4a166c933e7de752b193a855afe24ac51356de"},{"line_number":17,"context_line":"Signed-off-by: Bernhard Rosenkränzer \u003cbero@baylibre.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c849b4f1_e0da4662","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":6},"in_reply_to":"4a26811b_e89503fb","updated":"2024-05-26 09:42:29.000000000","message":"Done","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3bc19b9b85c3e60881f63672486fd2d0ec1b8681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb10d0dd_e46c6a67","updated":"2024-05-25 17:02:14.000000000","message":"Minor comments below","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"change_message_id":"4b5586f0e6f1c545240d6cf1a611e60423f47e72","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c2dd95e0_81a6f29a","updated":"2024-05-29 11:50:09.000000000","message":"@Bernard, is it really necessary to back port these patches now? Don\u0027t get me wrong -  I don\u0027t have any objections, though I\u0027d like to clarify the situation.\n\nCurrent maintainers of riscv-openocd fork sync with mainline OpenOCD quite often. So, when it comes RISC-V platform riscv-openocd has all the latest functionality and latest changes from mainline.\n\nCurrently, riscv-openocd fork is subject to major refactoring. Once it is finished - the codebase will be more or less stable and there is a hope that we\u0027ll initiate merging with mainline by EOY.","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a443c25764bbe306e4d80e5f6808fc4da93f9918","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"072a20db_dbcb265d","updated":"2024-05-29 06:55:16.000000000","message":"Bernhard, wouldn\u0027t be easier to set `hidden` flag in `struct reg` instead of creating an extra list of registers?","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"change_message_id":"d49d6680082ee45d54bc374400abd18c60f43598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3808dff5_cb1c2e5f","updated":"2024-06-08 17:47:15.000000000","message":"Jan, Marek + CC","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"c8943c4d708db2091d43062b666df2a12f950fbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"97198aa3_d23a9f89","updated":"2024-07-09 11:31:35.000000000","message":"Sorry for taking so long to reply.\nI\u0027d also like to hear Jan\u0027s opinion on the matter.","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"769edd18cb16cb18de1782e0d6de65050a58f331","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e7918581_7c7b3969","updated":"2026-01-06 07:21:24.000000000","message":"This change is contained in already merged\n8893: target: riscv: Sync with the RISC-V fork | https://review.openocd.org/c/openocd/+/8893\nCan we abandon this patch?","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"d5146b6b3a3e1ca911ea88b11ba9ec9e94b7f367","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6bfa69d0_7e62e5b0","in_reply_to":"1969fa71_58a9c4ce","updated":"2024-06-09 14:05:14.000000000","message":"What we\u0027d like to accomplish by backporting the patches from riscv-openocd is giving people who just `dnf install openocd` or `apt install openocd` something that will work well for their RISC-V boxes -- and to accelerate the process of merging riscv-openocd into mainline.\nRight now I think probably refactoring the patches and getting them into mainline (reducing the size of the diff at least) is a good start, but of course it doesn\u0027t really help if the same set of patches is already being refactored.\nI have more backport patches queued up, but of course I don\u0027t want them to get in the way of anything.","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"c8943c4d708db2091d43062b666df2a12f950fbb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4726b5ac_b918b957","in_reply_to":"6bfa69d0_7e62e5b0","updated":"2024-07-09 11:31:35.000000000","message":"I also think the focal point of any effort on upsteaming the changes from RISC-V OpenOCD fork should be to avoid double work.\n\nWith this in mind:\n\n* There are some differences outside `src/target/riscv`, I\u0027d have liked for them to be prioritized. You can find info on them here: https://github.com/riscv-collab/riscv-openocd/issues/979. \n* In regard to this particular patch, it will create merge conflicts on backport to RISC-V OpenOCD due to https://github.com/riscv-collab/riscv-openocd/pull/1084. The RISC-V implementation of register-cache-related stuff is now being re-worked. So I\u0027m not sure merging this one is in the spirit of \"avoiding double work\".\n* In regard to the patches you have queued up, I\u0027d like to take a look at them and decide whether or not we could commit to not changing these lines in the fork. Apart from the changes outside `src/target/riscv` -- this is a default and definitive yes for me.\n* On this topic, maybe an enforcement of such code freezes should be added to CI in the fork, though I\u0027m not sure this can be easily done on the level of individual lines in the file.","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"962fc054c91c9235f7a26a91edd06e69d425fa38","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1969fa71_58a9c4ce","in_reply_to":"c2dd95e0_81a6f29a","updated":"2024-06-08 15:01:01.000000000","message":"To avoid overloading maintainers of OpenOCD upstream and of riscv-openocd, and to avoid developers to waste their time, I would like to get consensus on how to proceed.\nBernhard, following my review, has also worked on the series in https://review.openocd.org/c/openocd/+/8288 and there are 28 open patches in gerrit about riscv https://review.openocd.org/q/riscv+status:open\n\nShould OpenOCD upstream reject any riscv patch until a \"formal\" merge from riscv-openocd starts?\nShould Bernhard move his series on riscv-openocd?\nWhat to do with all the other pending patch in gerrit?","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"243968b6760a0e3d46cfa00ff83c9660e41e269e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3497d38b_12f36532","in_reply_to":"e7918581_7c7b3969","updated":"2026-01-09 09:01:17.000000000","message":"\u003e This change is contained in already merged\n8893: target: riscv: Sync with the RISC-V fork | https://review.openocd.org/c/openocd/+/8893\nCan we abandon this patch?\n\nI agree - this patch can be abandoned.","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3bc19b9b85c3e60881f63672486fd2d0ec1b8681","unresolved":true,"context_lines":[{"line_number":11207,"context_line":"@end example"},{"line_number":11208,"context_line":"@end deffn"},{"line_number":11209,"context_line":""},{"line_number":11210,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":11211,"context_line":"@deffn {Command} {riscv info}"},{"line_number":11212,"context_line":"Displays some information OpenOCD detected about the target."},{"line_number":11213,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"d9fe33e5_527cbd14","line":11210,"updated":"2024-05-25 17:02:14.000000000","message":"I think this is a left-over from your git operations","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"27de4034d658934af617a6a5d3f978dfb5e44313","unresolved":false,"context_lines":[{"line_number":11207,"context_line":"@end example"},{"line_number":11208,"context_line":"@end deffn"},{"line_number":11209,"context_line":""},{"line_number":11210,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":11211,"context_line":"@deffn {Command} {riscv info}"},{"line_number":11212,"context_line":"Displays some information OpenOCD detected about the target."},{"line_number":11213,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"73a5cb72_48901e55","line":11210,"in_reply_to":"d9fe33e5_527cbd14","updated":"2024-05-26 09:42:29.000000000","message":"Done","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"d5146b6b3a3e1ca911ea88b11ba9ec9e94b7f367","unresolved":false,"context_lines":[{"line_number":11207,"context_line":"@end example"},{"line_number":11208,"context_line":"@end deffn"},{"line_number":11209,"context_line":""},{"line_number":11210,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":11211,"context_line":"@deffn {Command} {riscv info}"},{"line_number":11212,"context_line":"Displays some information OpenOCD detected about the target."},{"line_number":11213,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"8e842eda_3578c368","line":11210,"in_reply_to":"d9fe33e5_527cbd14","updated":"2024-06-09 14:05:14.000000000","message":"Done","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"}],"src/target/riscv/riscv.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3bc19b9b85c3e60881f63672486fd2d0ec1b8681","unresolved":true,"context_lines":[{"line_number":2935,"context_line":"\t\t\t\t\"`init`.\""},{"line_number":2936,"context_line":"\t},"},{"line_number":2937,"context_line":"\t{"},{"line_number":2938,"context_line":"\t\t.name \u003d \"expose_custom\","},{"line_number":2939,"context_line":"\t\t.handler \u003d riscv_set_expose_custom,"},{"line_number":2940,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":2941,"context_line":"\t\t.usage \u003d \"n0[-m0|\u003dname0][,n1[-m1|\u003dname1]]...\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7115f113_20e20126","line":2938,"updated":"2024-05-25 17:02:14.000000000","message":"I see that this command (and probably also others in risc-v code) is not reported in the file doc/openocd.texi\nIf you have the opportunity and time, please add them through another patch or patch-set.","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"d5146b6b3a3e1ca911ea88b11ba9ec9e94b7f367","unresolved":true,"context_lines":[{"line_number":2935,"context_line":"\t\t\t\t\"`init`.\""},{"line_number":2936,"context_line":"\t},"},{"line_number":2937,"context_line":"\t{"},{"line_number":2938,"context_line":"\t\t.name \u003d \"expose_custom\","},{"line_number":2939,"context_line":"\t\t.handler \u003d riscv_set_expose_custom,"},{"line_number":2940,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":2941,"context_line":"\t\t.usage \u003d \"n0[-m0|\u003dname0][,n1[-m1|\u003dname1]]...\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"19067163_2abbf907","line":2938,"in_reply_to":"7115f113_20e20126","updated":"2024-06-09 14:05:14.000000000","message":"It is actually documented...\nhttps://github.com/openocd-org/openocd/blob/master/doc/openocd.texi#L11186-L11208\n\nAm I missing something?","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3bc19b9b85c3e60881f63672486fd2d0ec1b8681","unresolved":true,"context_lines":[{"line_number":4389,"context_line":"\t\t\t} else if (r-\u003eexist \u0026\u0026 !list_empty(\u0026info-\u003ehide_csr)) {"},{"line_number":4390,"context_line":"\t\t\t\trange_list_t *entry;"},{"line_number":4391,"context_line":"\t\t\t\tlist_for_each_entry(entry, \u0026info-\u003ehide_csr, list)"},{"line_number":4392,"context_line":"\t\t\t\t\tif ((entry-\u003elow \u003c\u003d csr_number) \u0026\u0026 (csr_number \u003c\u003d entry-\u003ehigh)) {"},{"line_number":4393,"context_line":"\t\t\t\t\t\tLOG_TARGET_DEBUG(target, \"Hiding CSR %d (name\u003d%s)\", csr_number, r-\u003ename);"},{"line_number":4394,"context_line":"\t\t\t\t\t\tr-\u003ehidden \u003d true;"},{"line_number":4395,"context_line":"\t\t\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"748bab1c_428645b0","line":4392,"updated":"2024-05-25 17:02:14.000000000","message":"Here checkpatch complains that the parentheses around \u0027entry-\u003elow \u003c\u003d csr_number\u0027 and around \u0027csr_number \u003c\u003d entry-\u003ehigh\u0027 are not necessary.\nPlease drop them","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"27de4034d658934af617a6a5d3f978dfb5e44313","unresolved":false,"context_lines":[{"line_number":4389,"context_line":"\t\t\t} else if (r-\u003eexist \u0026\u0026 !list_empty(\u0026info-\u003ehide_csr)) {"},{"line_number":4390,"context_line":"\t\t\t\trange_list_t *entry;"},{"line_number":4391,"context_line":"\t\t\t\tlist_for_each_entry(entry, \u0026info-\u003ehide_csr, list)"},{"line_number":4392,"context_line":"\t\t\t\t\tif ((entry-\u003elow \u003c\u003d csr_number) \u0026\u0026 (csr_number \u003c\u003d entry-\u003ehigh)) {"},{"line_number":4393,"context_line":"\t\t\t\t\t\tLOG_TARGET_DEBUG(target, \"Hiding CSR %d (name\u003d%s)\", csr_number, r-\u003ename);"},{"line_number":4394,"context_line":"\t\t\t\t\t\tr-\u003ehidden \u003d true;"},{"line_number":4395,"context_line":"\t\t\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"055b6aa9_d07d7fa8","line":4392,"in_reply_to":"748bab1c_428645b0","updated":"2024-05-26 09:42:29.000000000","message":"Done","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"change_message_id":"d5146b6b3a3e1ca911ea88b11ba9ec9e94b7f367","unresolved":false,"context_lines":[{"line_number":4389,"context_line":"\t\t\t} else if (r-\u003eexist \u0026\u0026 !list_empty(\u0026info-\u003ehide_csr)) {"},{"line_number":4390,"context_line":"\t\t\t\trange_list_t *entry;"},{"line_number":4391,"context_line":"\t\t\t\tlist_for_each_entry(entry, \u0026info-\u003ehide_csr, list)"},{"line_number":4392,"context_line":"\t\t\t\t\tif ((entry-\u003elow \u003c\u003d csr_number) \u0026\u0026 (csr_number \u003c\u003d entry-\u003ehigh)) {"},{"line_number":4393,"context_line":"\t\t\t\t\t\tLOG_TARGET_DEBUG(target, \"Hiding CSR %d (name\u003d%s)\", csr_number, r-\u003ename);"},{"line_number":4394,"context_line":"\t\t\t\t\t\tr-\u003ehidden \u003d true;"},{"line_number":4395,"context_line":"\t\t\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"149bf878_85c3b960","line":4392,"in_reply_to":"748bab1c_428645b0","updated":"2024-06-09 14:05:14.000000000","message":"Done","commit_id":"85c2b3aab9946e9bc0d2667dfd22089ef1024a12"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"8b25317afb95a9f0c0771978e56044f5990ccacf","unresolved":true,"context_lines":[{"line_number":2600,"context_line":"COMMAND_HANDLER(riscv_hide_csrs)"},{"line_number":2601,"context_line":"{"},{"line_number":2602,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":2603,"context_line":"\t\tLOG_ERROR(\"Command expects parameters\");"},{"line_number":2604,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":2605,"context_line":"\t}"},{"line_number":2606,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"f629558f_4d17ad64","line":2603,"updated":"2026-01-06 09:48:29.000000000","message":"Remove this error message, if at all use `command_print()` but not in this case.","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c6a80ba46a4cf5415d6486f13a4afb3e09cea5ca","unresolved":false,"context_lines":[{"line_number":2600,"context_line":"COMMAND_HANDLER(riscv_hide_csrs)"},{"line_number":2601,"context_line":"{"},{"line_number":2602,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":2603,"context_line":"\t\tLOG_ERROR(\"Command expects parameters\");"},{"line_number":2604,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":2605,"context_line":"\t}"},{"line_number":2606,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a17a7b55_a63d707a","line":2603,"in_reply_to":"2c4cce37_abe4d1a4","updated":"2026-01-06 20:50:03.000000000","message":"Ups, sorry for the noise.","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"01f1438f443db436814f70f73f88933b7990ef25","unresolved":true,"context_lines":[{"line_number":2600,"context_line":"COMMAND_HANDLER(riscv_hide_csrs)"},{"line_number":2601,"context_line":"{"},{"line_number":2602,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":2603,"context_line":"\t\tLOG_ERROR(\"Command expects parameters\");"},{"line_number":2604,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":2605,"context_line":"\t}"},{"line_number":2606,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2c4cce37_abe4d1a4","line":2603,"in_reply_to":"f629558f_4d17ad64","updated":"2026-01-06 11:59:40.000000000","message":"This change is going to be abandoned!\nThe merged code fortunately doesn\u0027t contain this problem.","commit_id":"ad3ffcead5447b4a522545d622ae218ddd975496"}]}