)]}'
{"id":"openocd~master~I412f66ddd7bf7d260cee495324058482b26ff0c5","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-06-15 14:12:01.000000000","reason":"removed on reply"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-05-26 20:04:34.000000000","reason":"\u003cGERRIT_ACCOUNT_1000853\u003e replied on the change","reason_account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}}},"hashtags":[],"change_id":"I412f66ddd7bf7d260cee495324058482b26ff0c5","subject":"target/arm_tpiu_swo: Fix memory leak on error","status":"MERGED","created":"2024-05-26 10:43:36.000000000","updated":"2024-06-15 14:12:06.000000000","submitted":"2024-06-15 14:12:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8300","meta_rev_id":"010c171320d146da9be60f14bbe9958befc022a8","_number":8300,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-15 14:12:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-15 14:12:06.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-15 14:12:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-26 11:06:09.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-26 14:24:49.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"d5cb941566a9d0cda82c7007788597d9808e0080","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 10:43:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e8649c1a739db5aee7707eab458e738ef65c2e52","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-26 11:06:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19626/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18785/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"adbd4238afb60cde75802a62056a977903122e21","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 14:24:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f8cbcc5fe21c416b807c1d165f54ae8af9211403","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-26 20:04:34.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d6c431bcb5866d65cd3e73435e740d8296538f3b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-15 14:12:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"010c171320d146da9be60f14bbe9958befc022a8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-15 14:12:06.000000000","message":"Change has been successfully cherry-picked as b49e03f77ed890b39274d94ae6267bf07a68ba98","accounts_in_message":[],"_revision_number":2}],"current_revision":"b49e03f77ed890b39274d94ae6267bf07a68ba98","revisions":{"68fbf3c26106efbac396ee57d0238b37cce764b5":{"kind":"REWORK","_number":1,"created":"2024-05-26 10:43:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/8300/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8300/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/1 \u0026\u0026 git checkout -b change-8300 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8300/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-26 10:38:43.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-26 10:38:43.000000000","tz":120},"subject":"target/arm_tpiu_swo: Fix memory leak on error","message":"target/arm_tpiu_swo: Fix memory leak on error\n\nIn case of fail to allocate \u0027obj-\u003ename\u0027, the memory allocated for\n\u0027obj-\u003eout_filename\u0027 is not freed, thus leaking.\n\nSince \u0027obj\u0027 is allocated with calloc(), thus zeroed, switch to use\nthe common error exit path for both allocations of \u0027obj-\u003ename\u0027 and\n\u0027obj-\u003eout_filename\u0027.\n\nFixes: 2506ccb50915 (\"target/arm_tpiu_swo: Fix division by zero\")\nChange-Id: I412f66ddd7bf7d260cee495324058482b26ff0c5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"b49e03f77ed890b39274d94ae6267bf07a68ba98":{"kind":"REWORK","_number":2,"created":"2024-06-15 14:12:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/8300/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/8300/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/2 \u0026\u0026 git checkout -b change-8300 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/8300/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/8300/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"400cf213c05d17cede4dca4787a5533959bd2183","subject":"fix GCC\u0027s `-Wcalloc-transposed-args` warning"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-26 10:38:43.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-15 14:12:06.000000000","tz":0},"subject":"target/arm_tpiu_swo: Fix memory leak on error","message":"target/arm_tpiu_swo: Fix memory leak on error\n\nIn case of fail to allocate \u0027obj-\u003ename\u0027, the memory allocated for\n\u0027obj-\u003eout_filename\u0027 is not freed, thus leaking.\n\nSince \u0027obj\u0027 is allocated with calloc(), thus zeroed, switch to use\nthe common error exit path for both allocations of \u0027obj-\u003ename\u0027 and\n\u0027obj-\u003eout_filename\u0027.\n\nFixes: 2506ccb50915 (\"target/arm_tpiu_swo: Fix division by zero\")\nChange-Id: I412f66ddd7bf7d260cee495324058482b26ff0c5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8300\nTested-by: jenkins\nReviewed-by: zapb \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}