)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a6ce3d1541fabc19481545f701e4b1c2e8a10257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"161c988a_bcccbd87","updated":"2024-10-27 13:10:33.000000000","message":"Thanks for this patch.\nIt highlights we have some issue in the configure.ac.\nI propose some improvement below, that could be useful as fix for other drivers.\nPlease have a look and verify it works fine for you too.","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"b77f9c255952ae97f290fb15ad06a8c59508f790","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cfc72c4b_7d2854dc","updated":"2024-11-01 18:45:46.000000000","message":"I think this patch is ready to merge.","commit_id":"e143cd787ea336cffd76c8afe6acbca2428118c1"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"0ee3364de177f88e031369c6a55cbceb8b7d0a38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"42acc7ae_6f4f0c0c","updated":"2024-10-27 14:03:47.000000000","message":"Thanks for your input, I have amended the patch accordingly.","commit_id":"e143cd787ea336cffd76c8afe6acbca2428118c1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bda4940d76b462fb0e109c33914c5010b8f7f42c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"34780aa0_22dc39a9","updated":"2024-10-27 18:01:27.000000000","message":"Thanks!","commit_id":"e143cd787ea336cffd76c8afe6acbca2428118c1"}],"configure.ac":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a6ce3d1541fabc19481545f701e4b1c2e8a10257","unresolved":true,"context_lines":[{"line_number":273,"context_line":"  LIBJAYLINK_ADAPTERS"},{"line_number":274,"context_line":"  ],[auto])"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"AC_ARG_ADAPTERS([DUMMY_ADAPTER, PCIE_ADAPTERS],[no])"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"AC_ARG_ENABLE([parport],"},{"line_number":279,"context_line":"  AS_HELP_STRING([--enable-parport], [Enable building the pc parallel port driver]),"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"90b3f3b4_87894a2c","line":276,"updated":"2024-10-27 13:10:33.000000000","message":"I prefer you add it to the list above, so it gets `auto`.\nBut it\u0027s not enough!","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"0ee3364de177f88e031369c6a55cbceb8b7d0a38","unresolved":false,"context_lines":[{"line_number":273,"context_line":"  LIBJAYLINK_ADAPTERS"},{"line_number":274,"context_line":"  ],[auto])"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"AC_ARG_ADAPTERS([DUMMY_ADAPTER, PCIE_ADAPTERS],[no])"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"AC_ARG_ENABLE([parport],"},{"line_number":279,"context_line":"  AS_HELP_STRING([--enable-parport], [Enable building the pc parallel port driver]),"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"53a3cd7b_4673e7ff","line":276,"in_reply_to":"90b3f3b4_87894a2c","updated":"2024-10-27 14:03:47.000000000","message":"Done","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a6ce3d1541fabc19481545f701e4b1c2e8a10257","unresolved":true,"context_lines":[{"line_number":347,"context_line":"  [build_sysfsgpio\u003d$enableval], [build_sysfsgpio\u003dno])"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"AS_CASE([$host_os],"},{"line_number":350,"context_line":"  [linux*], [],"},{"line_number":351,"context_line":"  ["},{"line_number":352,"context_line":"    AS_IF([test \"x$build_sysfsgpio\" \u003d \"xyes\"], ["},{"line_number":353,"context_line":"      AC_MSG_ERROR([sysfsgpio is only available on linux])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"c334fc33_8b6bcb15","line":350,"updated":"2024-10-27 13:10:33.000000000","message":"Here we need a new variable, e.g.\n```\n  [linux*], [\n    is_linux\u003dyes\n  ],\n```","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"0ee3364de177f88e031369c6a55cbceb8b7d0a38","unresolved":false,"context_lines":[{"line_number":347,"context_line":"  [build_sysfsgpio\u003d$enableval], [build_sysfsgpio\u003dno])"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"AS_CASE([$host_os],"},{"line_number":350,"context_line":"  [linux*], [],"},{"line_number":351,"context_line":"  ["},{"line_number":352,"context_line":"    AS_IF([test \"x$build_sysfsgpio\" \u003d \"xyes\"], ["},{"line_number":353,"context_line":"      AC_MSG_ERROR([sysfsgpio is only available on linux])"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"548863bf_82eab7e1","line":350,"in_reply_to":"c334fc33_8b6bcb15","updated":"2024-10-27 14:03:47.000000000","message":"Done","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a6ce3d1541fabc19481545f701e4b1c2e8a10257","unresolved":true,"context_lines":[{"line_number":357,"context_line":"      AC_MSG_ERROR([linuxgpiod is only available on linux])"},{"line_number":358,"context_line":"    ])"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    AS_IF([test \"x$enable_xlnx_pcie_xvc\" \u003d \"xyes\"], ["},{"line_number":361,"context_line":"     AC_MSG_ERROR([xlnx_pcie_xvc is only available on linux])"},{"line_number":362,"context_line":"   ])"},{"line_number":363,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"cd8f0f65_2d510006","line":360,"updated":"2024-10-27 13:10:33.000000000","message":"This test can be dropped, as it gets part of `PROCESS_ADAPTERS` below","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"0ee3364de177f88e031369c6a55cbceb8b7d0a38","unresolved":false,"context_lines":[{"line_number":357,"context_line":"      AC_MSG_ERROR([linuxgpiod is only available on linux])"},{"line_number":358,"context_line":"    ])"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    AS_IF([test \"x$enable_xlnx_pcie_xvc\" \u003d \"xyes\"], ["},{"line_number":361,"context_line":"     AC_MSG_ERROR([xlnx_pcie_xvc is only available on linux])"},{"line_number":362,"context_line":"   ])"},{"line_number":363,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"238f7d68_91df72ec","line":360,"in_reply_to":"cd8f0f65_2d510006","updated":"2024-10-27 14:03:47.000000000","message":"Done","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a6ce3d1541fabc19481545f701e4b1c2e8a10257","unresolved":true,"context_lines":[{"line_number":713,"context_line":"PROCESS_ADAPTERS([LIBFTDI_USB1_ADAPTERS], [\"x$use_libftdi\" \u003d \"xyes\" -a \"x$use_libusb1\" \u003d \"xyes\"], [libftdi and libusb-1.x])"},{"line_number":714,"context_line":"PROCESS_ADAPTERS([LIBGPIOD_ADAPTERS], [\"x$use_libgpiod\" \u003d \"xyes\"], [libgpiod])"},{"line_number":715,"context_line":"PROCESS_ADAPTERS([LIBJAYLINK_ADAPTERS], [\"x$use_internal_libjaylink\" \u003d \"xyes\" -o \"x$use_libjaylink\" \u003d \"xyes\"], [libjaylink-0.2])"},{"line_number":716,"context_line":"PROCESS_ADAPTERS([DUMMY_ADAPTER, PCIE_ADAPTERS], [true], [unused])"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"AS_IF([test \"x$enable_linuxgpiod\" !\u003d \"xno\"], ["},{"line_number":719,"context_line":"  build_bitbang\u003dyes"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"0b362fc0_6a713698","line":716,"updated":"2024-10-27 13:10:33.000000000","message":"and here left DUMMY alone and add a new line\n`PROCESS_ADAPTERS([PCIE_ADAPTERS], [\"x$is_linux\" \u003d \"xyes\"], [Linux build])`","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"},{"author":{"_account_id":1000438,"name":"R. Diez","email":"rdiez-2006@rd10.de","username":"rdiez"},"change_message_id":"0ee3364de177f88e031369c6a55cbceb8b7d0a38","unresolved":false,"context_lines":[{"line_number":713,"context_line":"PROCESS_ADAPTERS([LIBFTDI_USB1_ADAPTERS], [\"x$use_libftdi\" \u003d \"xyes\" -a \"x$use_libusb1\" \u003d \"xyes\"], [libftdi and libusb-1.x])"},{"line_number":714,"context_line":"PROCESS_ADAPTERS([LIBGPIOD_ADAPTERS], [\"x$use_libgpiod\" \u003d \"xyes\"], [libgpiod])"},{"line_number":715,"context_line":"PROCESS_ADAPTERS([LIBJAYLINK_ADAPTERS], [\"x$use_internal_libjaylink\" \u003d \"xyes\" -o \"x$use_libjaylink\" \u003d \"xyes\"], [libjaylink-0.2])"},{"line_number":716,"context_line":"PROCESS_ADAPTERS([DUMMY_ADAPTER, PCIE_ADAPTERS], [true], [unused])"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"AS_IF([test \"x$enable_linuxgpiod\" !\u003d \"xno\"], ["},{"line_number":719,"context_line":"  build_bitbang\u003dyes"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5181c69e_d4fe97f1","line":716,"in_reply_to":"0b362fc0_6a713698","updated":"2024-10-27 14:03:47.000000000","message":"Done","commit_id":"db4c261efa9bff220dbac942c07c0bb2dfc1408d"}]}