)]}'
{"id":"openocd~master~I079e19cd153aec853a3c2eb66953024b8542d0f4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2024-07-13 22:23:15.000000000","reason":"Change was submitted"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-07-13 22:23:15.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-06-23 22:08:12.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002143":{"account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"last_update":"2024-06-10 13:20:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1002143\u003e replied on the change","reason_account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"}}},"hashtags":[],"change_id":"I079e19cd153aec853a3c2eb66953024b8542d0f4","subject":"binarybuffer: Fix str_to_buf() parsing function","status":"MERGED","created":"2024-06-03 08:45:09.000000000","updated":"2024-07-13 22:23:15.000000000","submitted":"2024-07-13 22:23:15.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":15,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"8315","meta_rev_id":"ed967a9ba1bb06940f74f09257973394d670277f","_number":8315,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-13 22:23:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-13 22:23:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-13 22:23:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-03 09:27:44.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-06-05 07:35:08.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2024-06-07 13:29:53.000000000","updated_by":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"reviewer":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"state":"REVIEWER"},{"updated":"2024-06-09 16:18:30.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"a6eeb15be5c8a36942616942aa0fb809c76431d1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-03 08:45:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bb0abb2fd060578de7cb074033647f7a35f22a8f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-03 09:27:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18814/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/19656/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"00fbc9918a007fa6b33ca1a7a89805ff136ba448","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-03 12:46:08.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c8c886cd41453d7f1cd90ccac7aec318cd831f7d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-03 13:19:04.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"ca8d00de0520001899d35126e19c2ed499e5645e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-03 13:19:32.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18818/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/19660/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"995783f264965eca4bbdc87fdd4a63d2ad1083a4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-03 14:03:36.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19661/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18819/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"abb2c713f19d7293aa3c5934ee0c796b26daf257","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-04 08:38:54.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"70450b56e160f813cab4980ebaf9db9dac2439e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-04 08:44:15.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"782052038099df867a75653d93bf0392f542fc03","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-04 08:44:35.000000000","message":"Patch Set 4: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18820/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/19662/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"52ea74767fcea0b93cbde65223a8bedda8bd9cfb","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-04 08:59:06.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19664/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18821/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"cef9d50413d8adc4650fdd5c74a70eae65475530","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-04 11:31:00.000000000","message":"Patch Set 6: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"72bad652392a670262eab104b0d23471cc9fb078","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-04 12:00:25.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19669/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18826/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"56c6460f90a30026f6eb950f592a7d07c7d13029","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2024-06-07 13:29:53.000000000","message":"Patch Set 6: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":6},{"id":"b93466c849ca0da1f1bef02495165809a9e372b9","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-06-09 10:05:43.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"7411e90a9d0682da04d5920e8ee6e33097ec01be","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-09 16:18:30.000000000","message":"Patch Set 6: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"db97b991a9c047a1e327cd07156ad354d0259eaa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-10 10:10:04.000000000","message":"Uploaded patch set 7.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"3dd8f7bdf00f56fd44bf406a6d098676a7466438","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-10 10:16:21.000000000","message":"Patch Set 7:\n\n(4 comments)","accounts_in_message":[],"_revision_number":7},{"id":"06b7feafbdc31d37475fe3f4668b303924c94df3","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-10 10:17:45.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"4643be99c610f3559decac74c61866cc2fb3e664","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-10 10:53:18.000000000","message":"Patch Set 7: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19689/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18845/ : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"93c073ecf89b2a19ad57cb06fea27464827419e1","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2024-06-10 12:00:35.000000000","message":"Patch Set 7:\n\n(2 comments)","accounts_in_message":[],"_revision_number":7},{"id":"1ab3c940a209354abf21a7ffa78d1b557cd86fb4","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-06-10 12:22:03.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"bca0dd86a2ee2cb66d17b6a7e441d1811b7dacd5","author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"real_author":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"date":"2024-06-10 13:20:27.000000000","message":"Patch Set 7: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"ebeb5270c2ccbc0a02c9dc72166a2db9e879a9fe","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 22:08:12.000000000","message":"Patch Set 7: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"4e771622416cacd4ed2ce30140063e96cb259d51","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 22:22:45.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"ed967a9ba1bb06940f74f09257973394d670277f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 22:23:15.000000000","message":"Change has been successfully cherry-picked as 53b94fad58ab32b02531f13299968c41f49947fa","accounts_in_message":[],"_revision_number":8}],"current_revision":"53b94fad58ab32b02531f13299968c41f49947fa","revisions":{"53b94fad58ab32b02531f13299968c41f49947fa":{"kind":"REWORK","_number":8,"created":"2024-07-13 22:23:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/15/8315/8","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8315/8","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/8 \u0026\u0026 git checkout -b change-8315 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8315/8","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c97a8ff10d250ad98597054322fd727dc292a332","subject":"flash/nor/nrf5: remove asserts on dereferenced pointers"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:23:02.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 22:23:15.000000000","tz":0},"subject":"binarybuffer: Fix str_to_buf() parsing function","message":"binarybuffer: Fix str_to_buf() parsing function\n\nThe function str_to_buf() was too benevolent and did\nnot perform sufficient error checking on the input\nstring being parsed. Especially:\n\n- Invalid numbers were silently ignored.\n- Out-of-range numbers were silently truncated.\n\nThe following commands that use str_to_buf()\nwere affected:\n\n- reg (when writing a register value)\n- set_reg\n- jtag drscan\n\nThis pull request fixes that by:\n\n- Rewriting str_to_buf() to add the missing checks.\n- Adding function command_parse_str_to_buf() which can\n  be used in command handlers. It parses the input\n  numbers and provides user-readable error messages\n  in case of parsing errors.\n\nExamples:\n\njtag drscan 10 huh10\n\n- Old behavior: The string \"huh10\" is silently\n  converted to 10 and the command is then executed.\n  No warning error or warning is shown to the user.\n- New behavior: Error message is shown:\n  \"\u0027huh10\u0027 is not a valid number\"\n\nreg pc 0x123456789\n\nAssuming the \"pc\" is 32 bits wide:\n\n- Old behavior: The register value is silently\n  truncated to 0x23456789 and the command is performed.\n- New behavior: Error message is shown to the user:\n  \"Number 0x123456789 exceeds 32 bits\"\n\nChange-Id: I079e19cd153aec853a3c2eb66953024b8542d0f4\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8315\nTested-by: jenkins\nReviewed-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"28f83d9ecc0c2913c8ae2b1b35d90769867d5b32":{"kind":"REWORK","_number":4,"created":"2024-06-04 08:38:54.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/15/8315/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8315/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/4 \u0026\u0026 git checkout -b change-8315 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8315/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:23:02.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-04 08:38:34.000000000","tz":120},"subject":"binarybuffer: Fix str_to_buf() parsing function","message":"binarybuffer: Fix str_to_buf() parsing function\n\nThe function str_to_buf() was too benevolent and did\nnot perform sufficient error checking on the input\nstring being parsed. Especially:\n\n- Invalid numbers were silently ignored.\n- Out-of-range nubmers were silently truncated.\n\nThe following commands that use str_to_buf()\nwere affected:\n\n- reg (when writing a register value)\n- set_reg\n- jtag drscan\n\nThis pull request fixes that by:\n\n- Rewriting str_to_buf() to add the missing checks.\n- Adding function command_parse_str_to_buf() which can\n  be used in command handlers. It parses the input\n  numbers and provides user-readable error messages\n  in case of parsing errors.\n\nExamples:\n\njtag drscan 10 huh10\n\n- Old behavior: The string \"huh10\" is silently\n  converted to 10 and the command is then executed.\n  No warning error or warning is shown to the user.\n- New behavior: Error message is shown:\n  \"Number huh10 (base-10) contains an invalid digit\"\n\nreg pc 0x123456789\n\nAssuming the \"pc\" is 32 bits wide:\n\n- Old behavior: The register value is silently\n  truncated to 0x23456789 and the command is performed.\n- New behavior: Error message is shown to the user:\n  \"Number 0x123456789 exceeds 32 bits\"\n\nChange-Id: I079e19cd153aec853a3c2eb66953024b8542d0f4\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"e1b385d3a822ed7848ba7ac838d330507c2556b7":{"kind":"REWORK","_number":5,"created":"2024-06-04 08:44:15.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/15/8315/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8315/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/5 \u0026\u0026 git checkout -b change-8315 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8315/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:23:02.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-04 08:39:49.000000000","tz":120},"subject":"binarybuffer: Fix str_to_buf() parsing function","message":"binarybuffer: Fix str_to_buf() parsing function\n\nThe function str_to_buf() was too benevolent and did\nnot perform sufficient error checking on the input\nstring being parsed. Especially:\n\n- Invalid numbers were silently ignored.\n- Out-of-range nubmers were silently truncated.\n\nThe following commands that use str_to_buf()\nwere affected:\n\n- reg (when writing a register value)\n- set_reg\n- jtag drscan\n\nThis pull request fixes that by:\n\n- Rewriting str_to_buf() to add the missing checks.\n- Adding function command_parse_str_to_buf() which can\n  be used in command handlers. It parses the input\n  numbers and provides user-readable error messages\n  in case of parsing errors.\n\nExamples:\n\njtag drscan 10 huh10\n\n- Old behavior: The string \"huh10\" is silently\n  converted to 10 and the command is then executed.\n  No warning error or warning is shown to the user.\n- New behavior: Error message is shown:\n  \"Number huh10 (base-10) contains an invalid digit\"\n\nreg pc 0x123456789\n\nAssuming the \"pc\" is 32 bits wide:\n\n- Old behavior: The register value is silently\n  truncated to 0x23456789 and the command is performed.\n- New behavior: Error message is shown to the user:\n  \"Number 0x123456789 exceeds 32 bits\"\n\nChange-Id: I079e19cd153aec853a3c2eb66953024b8542d0f4\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"235258664506c9a27b2530dec0723faa24a1c422":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2024-06-04 11:31:00.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/15/8315/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8315/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/6 \u0026\u0026 git checkout -b change-8315 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8315/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:23:02.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-04 11:31:00.000000000","tz":0},"subject":"binarybuffer: Fix str_to_buf() parsing function","message":"binarybuffer: Fix str_to_buf() parsing function\n\nThe function str_to_buf() was too benevolent and did\nnot perform sufficient error checking on the input\nstring being parsed. Especially:\n\n- Invalid numbers were silently ignored.\n- Out-of-range numbers were silently truncated.\n\nThe following commands that use str_to_buf()\nwere affected:\n\n- reg (when writing a register value)\n- set_reg\n- jtag drscan\n\nThis pull request fixes that by:\n\n- Rewriting str_to_buf() to add the missing checks.\n- Adding function command_parse_str_to_buf() which can\n  be used in command handlers. It parses the input\n  numbers and provides user-readable error messages\n  in case of parsing errors.\n\nExamples:\n\njtag drscan 10 huh10\n\n- Old behavior: The string \"huh10\" is silently\n  converted to 10 and the command is then executed.\n  No warning error or warning is shown to the user.\n- New behavior: Error message is shown:\n  \"Number huh10 (base-10) contains an invalid digit\"\n\nreg pc 0x123456789\n\nAssuming the \"pc\" is 32 bits wide:\n\n- Old behavior: The register value is silently\n  truncated to 0x23456789 and the command is performed.\n- New behavior: Error message is shown to the user:\n  \"Number 0x123456789 exceeds 32 bits\"\n\nChange-Id: I079e19cd153aec853a3c2eb66953024b8542d0f4\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"},"description":"Edit commit message"},"161c88e294a9d95c511b9e601f94578d31e6276d":{"kind":"REWORK","_number":7,"created":"2024-06-10 10:10:04.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/15/8315/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8315/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/7 \u0026\u0026 git checkout -b change-8315 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8315/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c0904731320c686e5074e68db8358e2f3ce83d","subject":"flash/nor/nrf5: handle ERROR_WAIT during nRF91 flash erase"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:23:02.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-10 10:07:25.000000000","tz":120},"subject":"binarybuffer: Fix str_to_buf() parsing function","message":"binarybuffer: Fix str_to_buf() parsing function\n\nThe function str_to_buf() was too benevolent and did\nnot perform sufficient error checking on the input\nstring being parsed. Especially:\n\n- Invalid numbers were silently ignored.\n- Out-of-range numbers were silently truncated.\n\nThe following commands that use str_to_buf()\nwere affected:\n\n- reg (when writing a register value)\n- set_reg\n- jtag drscan\n\nThis pull request fixes that by:\n\n- Rewriting str_to_buf() to add the missing checks.\n- Adding function command_parse_str_to_buf() which can\n  be used in command handlers. It parses the input\n  numbers and provides user-readable error messages\n  in case of parsing errors.\n\nExamples:\n\njtag drscan 10 huh10\n\n- Old behavior: The string \"huh10\" is silently\n  converted to 10 and the command is then executed.\n  No warning error or warning is shown to the user.\n- New behavior: Error message is shown:\n  \"\u0027huh10\u0027 is not a valid number\"\n\nreg pc 0x123456789\n\nAssuming the \"pc\" is 32 bits wide:\n\n- Old behavior: The register value is silently\n  truncated to 0x23456789 and the command is performed.\n- New behavior: Error message is shown to the user:\n  \"Number 0x123456789 exceeds 32 bits\"\n\nChange-Id: I079e19cd153aec853a3c2eb66953024b8542d0f4\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"8e7a7638e6801dfe0391e32bcd8655d9af964291":{"kind":"REWORK","_number":1,"created":"2024-06-03 08:45:09.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/15/8315/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8315/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/1 \u0026\u0026 git checkout -b change-8315 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8315/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:23:02.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:44:12.000000000","tz":120},"subject":"binarybuffer: Fix str_to_buf() parsing function","message":"binarybuffer: Fix str_to_buf() parsing function\n\nThe function str_to_buf() was too benevolent and did\nnot perform sufficient error checking on the input\nstring being parsed. Especially:\n\n- Invalid numbers were silently ignored.\n- Out-of-range nubmers were silently truncated.\n\nThe following commands that use str_to_buf()\nwere affected:\n\n- reg (when writing a register value)\n- set_reg\n- jtag drscan\n\nThis pull request fixes that by:\n\n- Rewriting str_to_buf() to add the missing checks.\n- Adding function command_parse_str_to_buf() which can\n  be used in command handlers. It parses the input\n  numbers and provides user-readable error messages\n  in case of parsing errors.\n\nExamples:\n\njtag drscan 10 huh10\n\n- Old behavior: The string \"huh10\" is silently\n  converted to 10 and the command is then executed.\n  No warning error or warning is shown to the user.\n- New behavior: Error message is shown:\n  \"Number huh10 (base-10) contains an invalid digit\"\n\nreg pc 0x123456789\n\n- Old behavior: The register value is silently\n  truncated to 0x23456789 and the command is performed.\n- New behavior: Error message is shown to the user:\n  \"Number 0x123456789 exceeds 32 bits\"\n\nChange-Id: I079e19cd153aec853a3c2eb66953024b8542d0f4\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"7d975a1a8b16674e85518910fdfc42b230548617":{"kind":"REWORK","_number":2,"created":"2024-06-03 12:46:08.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/15/8315/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8315/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/2 \u0026\u0026 git checkout -b change-8315 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8315/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:23:02.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 12:45:48.000000000","tz":120},"subject":"binarybuffer: Fix str_to_buf() parsing function","message":"binarybuffer: Fix str_to_buf() parsing function\n\nThe function str_to_buf() was too benevolent and did\nnot perform sufficient error checking on the input\nstring being parsed. Especially:\n\n- Invalid numbers were silently ignored.\n- Out-of-range nubmers were silently truncated.\n\nThe following commands that use str_to_buf()\nwere affected:\n\n- reg (when writing a register value)\n- set_reg\n- jtag drscan\n\nThis pull request fixes that by:\n\n- Rewriting str_to_buf() to add the missing checks.\n- Adding function command_parse_str_to_buf() which can\n  be used in command handlers. It parses the input\n  numbers and provides user-readable error messages\n  in case of parsing errors.\n\nExamples:\n\njtag drscan 10 huh10\n\n- Old behavior: The string \"huh10\" is silently\n  converted to 10 and the command is then executed.\n  No warning error or warning is shown to the user.\n- New behavior: Error message is shown:\n  \"Number huh10 (base-10) contains an invalid digit\"\n\nreg pc 0x123456789\n\n- Old behavior: The register value is silently\n  truncated to 0x23456789 and the command is performed.\n- New behavior: Error message is shown to the user:\n  \"Number 0x123456789 exceeds 32 bits\"\n\nChange-Id: I079e19cd153aec853a3c2eb66953024b8542d0f4\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"df1f0a73c3dd46a2063fd3a4b7eb55859e7e9f66":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-06-03 13:19:04.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/15/8315/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8315/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/3 \u0026\u0026 git checkout -b change-8315 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8315/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8315/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 08:23:02.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2024-06-03 13:19:04.000000000","tz":0},"subject":"binarybuffer: Fix str_to_buf() parsing function","message":"binarybuffer: Fix str_to_buf() parsing function\n\nThe function str_to_buf() was too benevolent and did\nnot perform sufficient error checking on the input\nstring being parsed. Especially:\n\n- Invalid numbers were silently ignored.\n- Out-of-range nubmers were silently truncated.\n\nThe following commands that use str_to_buf()\nwere affected:\n\n- reg (when writing a register value)\n- set_reg\n- jtag drscan\n\nThis pull request fixes that by:\n\n- Rewriting str_to_buf() to add the missing checks.\n- Adding function command_parse_str_to_buf() which can\n  be used in command handlers. It parses the input\n  numbers and provides user-readable error messages\n  in case of parsing errors.\n\nExamples:\n\njtag drscan 10 huh10\n\n- Old behavior: The string \"huh10\" is silently\n  converted to 10 and the command is then executed.\n  No warning error or warning is shown to the user.\n- New behavior: Error message is shown:\n  \"Number huh10 (base-10) contains an invalid digit\"\n\nreg pc 0x123456789\n\nAssuming the \"pc\" is 32 bits wide:\n\n- Old behavior: The register value is silently\n  truncated to 0x23456789 and the command is performed.\n- New behavior: Error message is shown to the user:\n  \"Number 0x123456789 exceeds 32 bits\"\n\nChange-Id: I079e19cd153aec853a3c2eb66953024b8542d0f4\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"},"description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}