)]}'
{"id":"openocd~master~I8ed1064a847b73065528ee7032be967b5c58b431","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-07-13 22:19:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8ed1064a847b73065528ee7032be967b5c58b431","subject":"target: cortex_m: fix detection of STAR-MC1 device","status":"MERGED","created":"2024-06-04 10:08:32.000000000","updated":"2024-07-13 22:19:04.000000000","submitted":"2024-07-13 22:19:04.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8316","meta_rev_id":"da95a7437bcb9118c36820e176b7739927064704","_number":8316,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-13 22:19:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-13 22:19:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-05 13:53:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-06-10 14:58:43.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"dd6b0d3dc95fcea1c0bb0d076cee89dface5db3e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-04 10:08:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3abc14aa69c69f86e85e0467a4216e1d3410c88b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-05 13:39:17.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b473d11852e7d4e2a783ac0575517ddbdfb7bc1b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-05 13:53:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19670/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18827/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"16436bb7cdd399d0ee1d6f764e345e344d7b3871","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-10 14:58:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"da95a7437bcb9118c36820e176b7739927064704","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 22:19:04.000000000","message":"Change has been successfully cherry-picked as df7a31f5367d61e4b61b990a0e265a786ba90fd4","accounts_in_message":[],"_revision_number":3}],"current_revision":"df7a31f5367d61e4b61b990a0e265a786ba90fd4","revisions":{"ba8faf2478abe61c6b965e3027864afb34db6984":{"kind":"REWORK","_number":1,"created":"2024-06-04 10:08:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/16/8316/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/8316/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/1 \u0026\u0026 git checkout -b change-8316 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/8316/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-04 08:30:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-04 09:19:58.000000000","tz":120},"subject":"target: cortex_m: fix detection of STAR-MC1 device","message":"target: cortex_m: fix detection of STAR-MC1 device\n\nThe detection of Cortex-M STAR-MC1 was introduced with [1], at a\ntime when OpenOCD was only checking the field PartNo of the CPUID\nregister.\nLater-on [2], OpenOCD extended the check to the field implementer\nof CPUID register. The value for ARM (0x41) implementer was used\nto all the Cortex-M, but no feedback for STAR-MC1 was available. A\ncomment reporting the possible mismatch was added.\n\nAs reported on OpenOCD mailing-list, the tecnical reference manual\nfor STAR-MC1 is now available [3] and it reports the implementer\nas ARM China (0x63) [3].\n\nFix the STAR-MC1 implementer accordingly.\n\nReported-by: Joseph Yiu \u003cJoseph.Yiu@arm.com\u003e\nChange-Id: I8ed1064a847b73065528ee7032be967b5c58b431\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLink: [1] 7dc4be3157d6 (\"target/arm: Add support with identify STAR-MC1\")\nFixes: [2] 05ee88915520 (\"target/cortex_m: check core implementor field\")\nLink: [3] https://www.armchina.com/download/Documents/Application-Notes/Technical-Reference-Manual?infoId\u003d160\n"}},"6f946a966f599fe299e536f1cf38184e90b7d257":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-06-05 13:39:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/16/8316/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/8316/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/2 \u0026\u0026 git checkout -b change-8316 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/8316/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-04 08:30:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-05 13:39:17.000000000","tz":0},"subject":"target: cortex_m: fix detection of STAR-MC1 device","message":"target: cortex_m: fix detection of STAR-MC1 device\n\nThe detection of Cortex-M STAR-MC1 was introduced with [1], at a\ntime when OpenOCD was only checking the field PartNo of the CPUID\nregister.\nLater-on [2], OpenOCD extended the check to the field implementer\nof CPUID register. The value for ARM (0x41) implementer was used\nto all the Cortex-M, but no feedback for STAR-MC1 was available. A\ncomment reporting the possible mismatch was added.\n\nAs reported on OpenOCD mailing-list, the technical reference manual\nfor STAR-MC1 is now available [3] and it reports the implementer\nas ARM China (0x63) [3].\n\nFix the STAR-MC1 implementer accordingly.\n\nReported-by: Joseph Yiu \u003cJoseph.Yiu@arm.com\u003e\nChange-Id: I8ed1064a847b73065528ee7032be967b5c58b431\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLink: [1] 7dc4be3157d6 (\"target/arm: Add support with identify STAR-MC1\")\nFixes: [2] 05ee88915520 (\"target/cortex_m: check core implementor field\")\nLink: [3] https://www.armchina.com/download/Documents/Application-Notes/Technical-Reference-Manual?infoId\u003d160\n"},"description":"Edit commit message"},"df7a31f5367d61e4b61b990a0e265a786ba90fd4":{"kind":"REWORK","_number":3,"created":"2024-07-13 22:19:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/16/8316/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/8316/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/3 \u0026\u0026 git checkout -b change-8316 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/8316/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/8316/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ed80a182ceadbf7ecbc921241526335a6d5cc65e","subject":"tcl: Replace \u0027hla_\u0027 prefix with \u0027hla\u0027 command group"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-04 08:30:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 22:19:04.000000000","tz":0},"subject":"target: cortex_m: fix detection of STAR-MC1 device","message":"target: cortex_m: fix detection of STAR-MC1 device\n\nThe detection of Cortex-M STAR-MC1 was introduced with [1], at a\ntime when OpenOCD was only checking the field PartNo of the CPUID\nregister.\nLater-on [2], OpenOCD extended the check to the field implementer\nof CPUID register. The value for ARM (0x41) implementer was used\nto all the Cortex-M, but no feedback for STAR-MC1 was available. A\ncomment reporting the possible mismatch was added.\n\nAs reported on OpenOCD mailing-list, the technical reference manual\nfor STAR-MC1 is now available [3] and it reports the implementer\nas ARM China (0x63) [3].\n\nFix the STAR-MC1 implementer accordingly.\n\nReported-by: Joseph Yiu \u003cJoseph.Yiu@arm.com\u003e\nChange-Id: I8ed1064a847b73065528ee7032be967b5c58b431\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nLink: [1] 7dc4be3157d6 (\"target/arm: Add support with identify STAR-MC1\")\nFixes: [2] 05ee88915520 (\"target/cortex_m: check core implementor field\")\nLink: [3] https://www.armchina.com/download/Documents/Application-Notes/Technical-Reference-Manual?infoId\u003d160\nReviewed-on: https://review.openocd.org/c/openocd/+/8316\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}