)]}'
{"id":"openocd~master~Ib090a97fd7a41579b3d4f6e6634a5fdf93836c83","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-07-13 22:21:54.000000000","reason":"removed on reply"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-07-13 22:22:00.000000000","reason":"Change was submitted"},"1002220":{"account":{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"},"last_update":"2024-07-13 22:22:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib090a97fd7a41579b3d4f6e6634a5fdf93836c83","subject":"flash/nor/nrf5: split chip and bank probes","status":"MERGED","created":"2024-06-08 09:53:58.000000000","updated":"2024-07-13 22:22:00.000000000","submitted":"2024-07-13 22:22:00.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8322","meta_rev_id":"1bbfd3cdcb46a90212e8e701c408d3f3842af4e1","_number":8322,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-13 22:22:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-13 22:22:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-08 10:51:40.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-06-11 02:51:20.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"},"state":"REVIEWER"},{"updated":"2024-06-23 21:50:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"22cc359d4c2b216ab760f4b326438930db41525a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-08 09:53:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5638f60411f9472659162d46d66ff6e27b59574","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-08 10:51:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19681/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18838/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a90a03941b543eb1fbd108911964e0962b32cf54","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 21:50:35.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"eef1afaf73a9e1624204781a9273572682c67da3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-24 05:16:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f8dbd06d1a52b80771a30b8296d36454a7a24c60","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 22:21:54.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1bbfd3cdcb46a90212e8e701c408d3f3842af4e1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 22:22:00.000000000","message":"Change has been successfully cherry-picked as f09ccc817b76683b42dc6ad410adddee16a351ed","accounts_in_message":[],"_revision_number":2}],"current_revision":"f09ccc817b76683b42dc6ad410adddee16a351ed","revisions":{"f09ccc817b76683b42dc6ad410adddee16a351ed":{"kind":"REWORK","_number":2,"created":"2024-07-13 22:22:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/22/8322/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/22/8322/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/2 \u0026\u0026 git checkout -b change-8322 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/22/8322/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c322060fbda4a162b55acd3658388eb145b4c73f","subject":"target/xtensa: flag additional write-only registers"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-06-08 09:33:35.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 22:22:00.000000000","tz":0},"subject":"flash/nor/nrf5: split chip and bank probes","message":"flash/nor/nrf5: split chip and bank probes\n\nnrf5_auto_probe() always re-probed chip hardware to\nget flash geometry.\n\nIntroduce nrf5_probe_chip() and move chip related probing to it.\nSave all flash parameters needed for bank setup to struct nrf5_info.\n\nIntroduce nrf5_setup_bank() and move bank setup code to it.\n\nCall both chip probe and bank setup unconditionally from nrf5_probe():\nin case of manual issuing \u0027flash probe\u0027 command, we should refresh actual\nvalues from the device.\n\nCall chip probe and bank setup only if not done before from\nnrf5_auto_probe().\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ib090a97fd7a41579b3d4f6e6634a5fdf93836c83\nReviewed-on: https://review.openocd.org/c/openocd/+/8322\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0348bacf536cb25322b83421f7ac9dad3504c6c5":{"kind":"REWORK","_number":1,"created":"2024-06-08 09:53:58.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/22/8322/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/22/8322/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/1 \u0026\u0026 git checkout -b change-8322 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/22/8322/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/22/8322/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9a8704eeba2cce7ccc2844b56c06a3b86cf33185","subject":"flash/nor/nrf5: handle ERROR_WAIT during nRF91 flash erase"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-06-08 09:33:35.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-06-08 09:49:47.000000000","tz":120},"subject":"flash/nor/nrf5: split chip and bank probes","message":"flash/nor/nrf5: split chip and bank probes\n\nnrf5_auto_probe() always re-probed chip hardware to\nget flash geometry.\n\nIntroduce nrf5_probe_chip() and move chip related probing to it.\nSave all flash parameters needed for bank setup to struct nrf5_info.\n\nIntroduce nrf5_setup_bank() and move bank setup code to it.\n\nCall both chip probe and bank setup unconditionally from nrf5_probe():\nin case of manual issuing \u0027flash probe\u0027 command, we should refresh actual\nvalues from the device.\n\nCall chip probe and bank setup only if not done before from\nnrf5_auto_probe().\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ib090a97fd7a41579b3d4f6e6634a5fdf93836c83\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}