)]}'
{"id":"openocd~master~Idb1942bfd31d370a74610b8a8836bc2e64370557","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-07-13 22:22:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idb1942bfd31d370a74610b8a8836bc2e64370557","subject":"flash/nor/nrf5: remove asserts on dereferenced pointers","status":"MERGED","created":"2024-06-08 10:10:30.000000000","updated":"2024-07-13 22:22:17.000000000","submitted":"2024-07-13 22:22:17.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8324","meta_rev_id":"25614fc7ec2b3ba9343afd27b1149ecbc9774dfa","_number":8324,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-13 22:22:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-13 22:22:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-08 11:07:26.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-06-23 21:51:41.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"2f2b544f35a685d3773282fce456f23708dc19b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-08 10:10:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"97b8e32ee12ba7a02eebf4cb94315f944fa38759","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-08 11:07:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19682/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18839/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c4b7e2bf526c3b8526efecee1e8b98e96fff67ed","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 21:51:41.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d10c991a7348b740909007382dc3a6df229a8bea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 22:22:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"25614fc7ec2b3ba9343afd27b1149ecbc9774dfa","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 22:22:17.000000000","message":"Change has been successfully cherry-picked as c97a8ff10d250ad98597054322fd727dc292a332","accounts_in_message":[],"_revision_number":2}],"current_revision":"c97a8ff10d250ad98597054322fd727dc292a332","revisions":{"c97a8ff10d250ad98597054322fd727dc292a332":{"kind":"REWORK","_number":2,"created":"2024-07-13 22:22:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/8324/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8324/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/2 \u0026\u0026 git checkout -b change-8324 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8324/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f09ccc817b76683b42dc6ad410adddee16a351ed","subject":"flash/nor/nrf5: split chip and bank probes"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-06-08 09:59:29.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 22:22:17.000000000","tz":0},"subject":"flash/nor/nrf5: remove asserts on dereferenced pointers","message":"flash/nor/nrf5: remove asserts on dereferenced pointers\n\nThe driver code works reliably, no need to use assert() everywhere.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Idb1942bfd31d370a74610b8a8836bc2e64370557\nReviewed-on: https://review.openocd.org/c/openocd/+/8324\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"c95d697f26c78d2204beb9aaa62bc13c811dc929":{"kind":"REWORK","_number":1,"created":"2024-06-08 10:10:30.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/24/8324/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8324/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/1 \u0026\u0026 git checkout -b change-8324 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8324/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8324/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0348bacf536cb25322b83421f7ac9dad3504c6c5","subject":"flash/nor/nrf5: split chip and bank probes"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-06-08 09:59:29.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-06-08 09:59:29.000000000","tz":120},"subject":"flash/nor/nrf5: remove asserts on dereferenced pointers","message":"flash/nor/nrf5: remove asserts on dereferenced pointers\n\nThe driver code works reliably, no need to use assert() everywhere.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Idb1942bfd31d370a74610b8a8836bc2e64370557\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}