)]}'
{"id":"openocd~master~I02ed484e61fb776c1625f6e36ab14c85891939b2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-06-23 09:32:04.000000000","reason":"removed on reply"},"1002283":{"account":{"_account_id":1002283,"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","username":"tgs-sc"},"last_update":"2024-06-23 09:32:08.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I02ed484e61fb776c1625f6e36ab14c85891939b2","subject":"remote_bitbang: fix assertion failure for the cases when connection is abruptly terminated","status":"MERGED","created":"2024-06-08 22:02:05.000000000","updated":"2024-06-23 09:32:08.000000000","submitted":"2024-06-23 09:32:08.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8325","meta_rev_id":"b63d31e95cfe89ba42f3575c7bfecaa42946c615","_number":8325,"owner":{"_account_id":1002283,"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","username":"tgs-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-23 09:32:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-23 09:32:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-23 09:32:08.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-08 22:18:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-06-09 16:41:38.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-06-10 14:44:42.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2024-06-11 09:54:02.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"8e109b94e321e75e2b28cc1771707cc7f0745a7f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002283,"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","username":"tgs-sc"},"real_author":{"_account_id":1002283,"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","username":"tgs-sc"},"date":"2024-06-08 22:02:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"592e075863de4c5b2b80c870745082c9b84686c0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-08 22:18:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19687/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18843/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"716a0bd3ec7f7c0d940d925b406a4716efc45769","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-09 16:41:38.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ff03cb10c74c157d1aa8c633dc6bc3aa2b1026df","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-10 14:44:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f59ba681eaefa234edb847fdb25b87a8b619867c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002283,"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","username":"tgs-sc"},"real_author":{"_account_id":1002283,"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","username":"tgs-sc"},"date":"2024-06-11 09:28:24.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f4859b69bec58da0e430e905385163e62da748a7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-11 09:42:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19692/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18848/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"86d65ce8ab3b670783c62472b94ff5a746ce05f4","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-11 09:54:02.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"4753c27b82f5e287cc30ed643959bc241212792f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 09:32:04.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b63d31e95cfe89ba42f3575c7bfecaa42946c615","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 09:32:08.000000000","message":"Change has been successfully cherry-picked as 23ba602ca5be4a4c0841a178775bc82b3be0b38f","accounts_in_message":[],"_revision_number":3}],"current_revision":"23ba602ca5be4a4c0841a178775bc82b3be0b38f","revisions":{"05ee14db38acb84ce5a9b72f40e45385acc5fe61":{"kind":"REWORK","_number":2,"created":"2024-06-11 09:28:24.000000000","uploader":{"_account_id":1002283,"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","username":"tgs-sc"},"ref":"refs/changes/25/8325/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/8325/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/2 \u0026\u0026 git checkout -b change-8325 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/8325/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","date":"2024-06-07 13:42:16.000000000","tz":180},"committer":{"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","date":"2024-06-11 09:22:51.000000000","tz":180},"subject":"remote_bitbang: fix assertion failure for the cases when connection is abruptly terminated","message":"remote_bitbang: fix assertion failure for the cases when connection is abruptly terminated\n\nChanges affect the function remote_bitbang_fill_buf.\nWhen read_socket returns 0, socket reached EOF and there is\nno data to read. But if request was blocking, the caller\nexpected some data. Such situations should be treated as ERROR.\n\nChange-Id: I02ed484e61fb776c1625f6e36ab14c85891939b2\nSigned-off-by: Timur Golubovich \u003ctimur.golubovich@syntacore.com\u003e\n"}},"23ba602ca5be4a4c0841a178775bc82b3be0b38f":{"kind":"REWORK","_number":3,"created":"2024-06-23 09:32:08.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/25/8325/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/8325/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/3 \u0026\u0026 git checkout -b change-8325 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/8325/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dde096e03fa4912aa44b2b72cfbdb7676340a3d1","subject":"itm: fix default initialization"}],"author":{"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","date":"2024-06-07 13:42:16.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-23 09:32:08.000000000","tz":0},"subject":"remote_bitbang: fix assertion failure for the cases when connection is abruptly terminated","message":"remote_bitbang: fix assertion failure for the cases when connection is abruptly terminated\n\nChanges affect the function remote_bitbang_fill_buf.\nWhen read_socket returns 0, socket reached EOF and there is\nno data to read. But if request was blocking, the caller\nexpected some data. Such situations should be treated as ERROR.\n\nChange-Id: I02ed484e61fb776c1625f6e36ab14c85891939b2\nSigned-off-by: Timur Golubovich \u003ctimur.golubovich@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8325\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"731592f4dd15ae14667425a4b05011e9cf4ed2d4":{"kind":"REWORK","_number":1,"created":"2024-06-08 22:02:05.000000000","uploader":{"_account_id":1002283,"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","username":"tgs-sc"},"ref":"refs/changes/25/8325/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/25/8325/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/1 \u0026\u0026 git checkout -b change-8325 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/25/8325/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/25/8325/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","date":"2024-06-07 13:42:16.000000000","tz":180},"committer":{"name":"Timur Golubovich","email":"timur.golubovich@syntacore.com","date":"2024-06-08 21:58:18.000000000","tz":180},"subject":"remote_bitbang: fix assertion failure for the cases when connection is abruptly terminated","message":"remote_bitbang: fix assertion failure for the cases when connection is abruptly terminated\n\nChanges affect the function remote_bitbang_fill_buf.\nWhen read_socket returns 0, socket reached EOF and there is\nno data to read. But if request was blocking, the caller\nexpected some data. Such situations should be treated as ERROR.\n\nChange-Id: I02ed484e61fb776c1625f6e36ab14c85891939b2\nSigned-off-by: Timur Golubovich \u003ctimur.golubovich@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}