)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"change_message_id":"54061509329fdc3aceec0ade274ed2717ce9955b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42acdf7c_b33fffd4","updated":"2024-07-13 08:24:23.000000000","message":"@zapb I noticed you implemented the initial RTT support, what are your thoughts on this?\nI have a multicore (AMP) device where each core should be able to use RTT.\nThis could *maybe* be achieved by putting the RTT control block in shared memory for each core, but having an RTT control block per core seems much cleaner and has little overhead.\nThis PR is large, although most of it is just adding a context parameter to each usage of RTT","commit_id":"f9e5584fb3fc93e47542f83bafb71ec08e7e8175"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"70f55d1130ef11d7b252911a2d176621815a4ba4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83fd6426_540b372a","updated":"2024-07-27 10:30:21.000000000","message":"Hi Grant, thanks for your contribution!\n\nWhen I implemented RTT in OpenOCD I did not have multiple cores in mind. Therefore, the current code base is not really suitable to add support for multiple cores.\nI think the best and cleanest solution is something similar to TPIU/SWO where you can create an object and \"assign\" it to a core. For example, you would have an RTT object for each core: cpu0.rtt and cpu1.rtt. I have some rtt-v2 code locally but it is not ready for review and needs more testing. Also the current \"RTT server\" implementation needs to be reconsidered, with multiple cores it becomes too complicated IMO.\n\nLong story short, I would be reluctant to add more features to the current code base and would rather go straight for a new implementation, e.g. rtt-v2.","commit_id":"f9e5584fb3fc93e47542f83bafb71ec08e7e8175"},{"author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"change_message_id":"f7c7ab032e2a21036a007717d9c47983b1807d55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3a64feb_026194cc","updated":"2024-06-16 09:25:38.000000000","message":"Hi, first time openocd contributor here.\n\nI would have preferred to add the RTT instance ID to the existing RTT commands. Although, I wasn\u0027t sure how to differentiate optional parameters from each other. So instead added the stateful \"rtt select_instance \u003cinstance_id\u003e\" command.\n\nHappy to make adjustments and/or fix up any mistakes, thanks!","commit_id":"f9e5584fb3fc93e47542f83bafb71ec08e7e8175"}]}