)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"7eba474ebc1c945e6f0ca27f8222d606c3be54ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2a5eae64_2ec9181c","updated":"2025-09-08 07:26:26.000000000","message":"May I know whether still have some comments for this patch? thanks.","commit_id":"f46912f2889f0d90ff1940d18333094ba697ff52"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"83445b90f0f0046e5df023b5630a05b1f5482f48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"00fde51d_9cd2123c","updated":"2025-09-10 21:11:33.000000000","message":"Sorry, my mistake. I have incorrectly archived the gerrit notification emails of patchset 7 as \"done\".\nWe have recently modified the folder structure of the config scripts\nhttps://openocd.org/doc/doxygen/html/config_files.html\nWould you mind re-posting this patch with path\ntcl/board/nxp/imx93-evk.cfg\ntcl/board/nxp/imx93-evk-reset.cfg\ntcl/interface/nxp/imx93-evk.cfg\ntcl/target/nxp/imx93.cfg\n\nSimilarly for the other 2 patches in this series","commit_id":"ab0eb983c1a6ead85a98366db2175d3262bd6329"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"f52d8d252e7f5d4378d49bec0dd61cde1efc0e13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"378f070d_332ce6aa","in_reply_to":"00fde51d_9cd2123c","updated":"2025-10-16 10:26:02.000000000","message":"sorry for late response, have updated, please review again, thanks.","commit_id":"ab0eb983c1a6ead85a98366db2175d3262bd6329"},{"author":{"_account_id":1001410,"name":"Diego Herranz","email":"diegoherranz@diegoherranz.com","username":"diegoherranz"},"change_message_id":"524db017a65083907ef724fb958fc9e7866ad3e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6d394c7a_3498ced1","updated":"2025-10-27 22:07:23.000000000","message":"Happy to see support for this SoC getting added. Just one SWD comment from me. Thanks!","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"395ed6b71c77da1bffd20a6e846e8e70a8e583ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4ed0d6d9_3ea76e4a","updated":"2025-10-16 11:08:35.000000000","message":"Please also update the commit message and remove the `nxp_` prefix in the filename.","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"c34507a49003c441d263b3d18f969c25f62bdcf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e6558c7a_d6926d49","in_reply_to":"4ed0d6d9_3ea76e4a","updated":"2025-11-03 08:15:20.000000000","message":"fixed, thanks.","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"c34507a49003c441d263b3d18f969c25f62bdcf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4588a4c5_731abd59","updated":"2025-11-03 08:15:20.000000000","message":"Updated to address review comments, thanks.","commit_id":"0f1625d6759b33dee7bdc56818585f41536d77f4"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"eee9ff60792afd11c3968dd75b805cbfd4c537da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5d95c9d0_40850680","updated":"2025-11-12 08:03:37.000000000","message":"Do we really need a dedicated \u0027reset\u0027 configuration file? Isn\u0027t that something that can be enabled via a variable? The regular and the \u0027reset\u0027 file are almost identical.","commit_id":"2ea6c628d29f8ee53d498b72038fb47e84a8ea93"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e3a03ff301fc4dafe0a677c4cb11e11fc489365c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"10b6f8a6_05ce56ba","updated":"2025-11-08 16:27:58.000000000","message":"same typos, copy-paste from https://review.openocd.org/c/openocd/+/9016","commit_id":"2ea6c628d29f8ee53d498b72038fb47e84a8ea93"}],"tcl/board/nxp/imx93-evk.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e3a03ff301fc4dafe0a677c4cb11e11fc489365c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# configuration file for NXP i.MX93 EVK"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Could specify external adpater by:"},{"line_number":6,"context_line":"# openocd -f interface/jlink.cfg -f board/nxp/imx8ulp-evk.cfg"},{"line_number":7,"context_line":"# otherwise use FTDI-based JTAG adapte by default."},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"9df18d77_b7ad4618","line":5,"updated":"2025-11-08 16:27:58.000000000","message":"s/adpater/adapter/","commit_id":"2ea6c628d29f8ee53d498b72038fb47e84a8ea93"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e3a03ff301fc4dafe0a677c4cb11e11fc489365c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Could specify external adpater by:"},{"line_number":6,"context_line":"# openocd -f interface/jlink.cfg -f board/nxp/imx8ulp-evk.cfg"},{"line_number":7,"context_line":"# otherwise use FTDI-based JTAG adapte by default."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"if { [adapter name] eq \"undefined\" } {"},{"line_number":10,"context_line":"  # Use on-board FTDI-based adapter"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"f5aa4458_fad9dc3b","line":7,"updated":"2025-11-08 16:27:58.000000000","message":"s/adapte/adapter/","commit_id":"2ea6c628d29f8ee53d498b72038fb47e84a8ea93"}],"tcl/board/nxp/nxp_imx93-evk.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca25006acff4e2897188abefd67e7b23033f0a19","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# configuration file for NXP i.MX93 EVK"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# only JTAG supported"},{"line_number":7,"context_line":"transport select jtag"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# set a safe JTAG clock speed, can be overridden"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"afa8bc14_49283ee7","line":6,"updated":"2025-10-17 15:35:53.000000000","message":"I have not checked the image of the board, but I think here could it apply the same comment as in\nhttps://review.openocd.org/c/openocd/+/9016","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"c34507a49003c441d263b3d18f969c25f62bdcf1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# configuration file for NXP i.MX93 EVK"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# only JTAG supported"},{"line_number":7,"context_line":"transport select jtag"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# set a safe JTAG clock speed, can be overridden"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"f6771f2b_7f0074e1","line":6,"in_reply_to":"afa8bc14_49283ee7","updated":"2025-11-03 08:15:20.000000000","message":"Done","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"395ed6b71c77da1bffd20a6e846e8e70a8e583ab","unresolved":true,"context_lines":[{"line_number":21,"context_line":"set CHIPCORES 2"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# source SoC configuration"},{"line_number":24,"context_line":"source [find target/imx93.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"6fe9116b_a172219f","line":24,"updated":"2025-10-16 11:08:35.000000000","message":"You forgot to update the includes, no?","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"c34507a49003c441d263b3d18f969c25f62bdcf1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set CHIPCORES 2"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# source SoC configuration"},{"line_number":24,"context_line":"source [find target/imx93.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"0aeed272_59f001aa","line":24,"in_reply_to":"6fe9116b_a172219f","updated":"2025-11-03 08:15:20.000000000","message":"Done","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"}],"tcl/interface/ftdi/imx93-evk.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"46b5b2c3d15e56ba4f81b135e58378115de3bb7c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Configuration file for NXP MC-IMX93-EVK on-board internal JTAG"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Using this interface requires enabling \"remote mode\" for the board using the"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"ef4d4587_f00fd285","line":1,"updated":"2024-09-01 14:49:33.000000000","message":"Checkpatch script requires a SPDX line with the license as first line of this file","commit_id":"ad87011447d29d6d10808b8ca51f0ea609700e07"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"13728428edc662d3fd37a20e18f04fca627b865b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Configuration file for NXP MC-IMX93-EVK on-board internal JTAG"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Using this interface requires enabling \"remote mode\" for the board using the"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"a9f34afa_6e8ada07","line":1,"in_reply_to":"ef4d4587_f00fd285","updated":"2024-10-21 03:18:16.000000000","message":"Sorry for missed this comments and late response, updated, please review again, thanks.","commit_id":"ad87011447d29d6d10808b8ca51f0ea609700e07"}],"tcl/target/imx93.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"77896b0d7b5507706abc6ed42059dff18c1ac4c9","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    cti create $_CTINAME.$_core -dap $_CHIPNAME.dap -ap-num 1 \\"},{"line_number":39,"context_line":"        -baseaddr [lindex $CTIBASE $_core]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    set _command \"target create $_TARGETNAME.$_core aarch64 -dap $_CHIPNAME.dap \\"},{"line_number":42,"context_line":"        -dbgbase [lindex $DBGBASE $_core] -cti $_CTINAME.$_core -coreid $_core\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    eval $_command"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"a16d7674_bfc2a58a","line":41,"updated":"2024-06-23 14:51:42.000000000","message":"same as in previous patch of this series. Would it work with this?\n```\ntarget create $_TARGETNAME.$_core aarch64 -dap $_CHIPNAME.dap \\\n        -dbgbase [lindex $DBGBASE $_core] -cti $_CTINAME.$_core -coreid $_core\n```","commit_id":"a2191a2404b65a7db4cb7afbe2dca09186bd060b"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"512386b7a5994590013bc212d0ff68e7561583f1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cti create $_CTINAME.$_core -dap $_CHIPNAME.dap -ap-num 1 \\"},{"line_number":39,"context_line":"        -baseaddr [lindex $CTIBASE $_core]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    set _command \"target create $_TARGETNAME.$_core aarch64 -dap $_CHIPNAME.dap \\"},{"line_number":42,"context_line":"        -dbgbase [lindex $DBGBASE $_core] -cti $_CTINAME.$_core -coreid $_core\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    eval $_command"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"0e5155f2_17bccda6","line":41,"in_reply_to":"a16d7674_bfc2a58a","updated":"2024-07-01 03:05:59.000000000","message":"sorry for late response, verified and it works, thanks for your comments.","commit_id":"a2191a2404b65a7db4cb7afbe2dca09186bd060b"}],"tcl/target/nxp/imx93.cfg":[{"author":{"_account_id":1001410,"name":"Diego Herranz","email":"diegoherranz@diegoherranz.com","username":"diegoherranz"},"change_message_id":"524db017a65083907ef724fb958fc9e7866ad3e3","unresolved":true,"context_lines":[{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# the DAP tap"},{"line_number":25,"context_line":"jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x01 -irmask 0x0f \\"},{"line_number":26,"context_line":"        -expected-id $_DAP_TAPID"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"dap create $_CHIPNAME.dap -chain-position $_CHIPNAME.cpu"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"912e8530_bebc8ef1","line":25,"updated":"2025-10-27 22:07:23.000000000","message":"Given that the iMX93 supports SWD, and in fact NXP\u0027s own FRDM-IMX93 board only exposes SWD on the debug header, shouldn\u0027t this use the swj_newdap helper?","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1001410,"name":"Diego Herranz","email":"diegoherranz@diegoherranz.com","username":"diegoherranz"},"change_message_id":"a3b7763bef82a9a2920a93c7fa48fc433ccae7cb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# the DAP tap"},{"line_number":25,"context_line":"jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x01 -irmask 0x0f \\"},{"line_number":26,"context_line":"        -expected-id $_DAP_TAPID"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"dap create $_CHIPNAME.dap -chain-position $_CHIPNAME.cpu"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"949659bb_19695305","line":25,"in_reply_to":"6fee698c_5d949ae5","updated":"2025-11-09 10:39:19.000000000","message":"Thanks!","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"c34507a49003c441d263b3d18f969c25f62bdcf1","unresolved":true,"context_lines":[{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# the DAP tap"},{"line_number":25,"context_line":"jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x01 -irmask 0x0f \\"},{"line_number":26,"context_line":"        -expected-id $_DAP_TAPID"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"dap create $_CHIPNAME.dap -chain-position $_CHIPNAME.cpu"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"acf9939c_a1126384","line":25,"in_reply_to":"912e8530_bebc8ef1","updated":"2025-11-03 08:15:20.000000000","message":"Changed to use swj_newdap, so it could works both for jtag and swd, thanks for your comments. and I also added frdm-imx93 board support.","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"},{"author":{"_account_id":1002287,"name":"Peter pan","email":"peter.panjf@gmail.com","username":"PeterPanJF"},"change_message_id":"b5023dced1ed21d68006d7acd9a756f92b3f6b02","unresolved":false,"context_lines":[{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# the DAP tap"},{"line_number":25,"context_line":"jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x01 -irmask 0x0f \\"},{"line_number":26,"context_line":"        -expected-id $_DAP_TAPID"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"dap create $_CHIPNAME.dap -chain-position $_CHIPNAME.cpu"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"6fee698c_5d949ae5","line":25,"in_reply_to":"acf9939c_a1126384","updated":"2025-11-03 08:15:48.000000000","message":"Done","commit_id":"b24f44416afcdf122a9a302b575842b17760327a"}]}