)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"dd91a7052200a702a18e7d329028d5aa9facad41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e23c0c65_da3a78d3","updated":"2024-07-31 22:01:11.000000000","message":".","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"02efa8b5a263847e2c45093ee43a0ca913ecbc0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de29ca17_a24e4ff4","updated":"2024-07-28 15:06:52.000000000","message":"Apart for the complain from checkpatch, I think this is ok.\nMarc, any concern?","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a8b2d55f72e4f52408f271b3ab2454b298b45481","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ef86547_550834db","in_reply_to":"a037423a_0a6d8597","updated":"2024-08-06 14:47:23.000000000","message":"Done","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"cdd9d36ce3f1a1e8120f1c2a1f3b69480793011e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a037423a_0a6d8597","in_reply_to":"de29ca17_a24e4ff4","updated":"2024-07-30 21:20:59.000000000","message":"Nope, fine for me. I think most RTT implementations use the \"SEGGER RTT\" ID.","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8600a7e9e4e514d96ce735ecfc0b8054ba90ea7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cde11c5d_91448d6b","updated":"2024-08-06 14:46:59.000000000","message":"Thanks!","commit_id":"ca197b7bf400cc511e11c25b7d94802508a56a97"}],"src/rtt/tcl.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"02efa8b5a263847e2c45093ee43a0ca913ecbc0a","unresolved":true,"context_lines":[{"line_number":23,"context_line":"\tconst char *selected_id;"},{"line_number":24,"context_line":"\tif (CMD_ARGC \u003c 2 || CMD_ARGC \u003e 3)"},{"line_number":25,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":26,"context_line":"\tif (CMD_ARGC \u003d\u003d 2) {"},{"line_number":27,"context_line":"\t\tselected_id \u003d DEFAULT_ID;"},{"line_number":28,"context_line":"\t} else {"},{"line_number":29,"context_line":"\t\tselected_id \u003d CMD_ARGV[2];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0d62d53e_c6629bd8","line":26,"updated":"2024-07-28 15:06:52.000000000","message":"checkpatch complains about the unnecessarily curly brackets in this if/then/else","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"},{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"dd91a7052200a702a18e7d329028d5aa9facad41","unresolved":true,"context_lines":[{"line_number":23,"context_line":"\tconst char *selected_id;"},{"line_number":24,"context_line":"\tif (CMD_ARGC \u003c 2 || CMD_ARGC \u003e 3)"},{"line_number":25,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":26,"context_line":"\tif (CMD_ARGC \u003d\u003d 2) {"},{"line_number":27,"context_line":"\t\tselected_id \u003d DEFAULT_ID;"},{"line_number":28,"context_line":"\t} else {"},{"line_number":29,"context_line":"\t\tselected_id \u003d CMD_ARGV[2];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c7ccc4a9_a771f6d8","line":26,"in_reply_to":"0d62d53e_c6629bd8","updated":"2024-07-31 22:01:11.000000000","message":"so is it a warning or an error then?  If it\u0027s a hard style item, let\u0027s fix checkpatch to make it an error. if it\u0027s not, it\u0027s not?","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c2df2eee8ef2dd2f495448e871e2d0f7e988452","unresolved":true,"context_lines":[{"line_number":23,"context_line":"\tconst char *selected_id;"},{"line_number":24,"context_line":"\tif (CMD_ARGC \u003c 2 || CMD_ARGC \u003e 3)"},{"line_number":25,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":26,"context_line":"\tif (CMD_ARGC \u003d\u003d 2) {"},{"line_number":27,"context_line":"\t\tselected_id \u003d DEFAULT_ID;"},{"line_number":28,"context_line":"\t} else {"},{"line_number":29,"context_line":"\t\tselected_id \u003d CMD_ARGV[2];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bb58a3f3_a5bdba86","line":26,"in_reply_to":"ad7d90f8_3251cf48","updated":"2024-08-01 09:25:16.000000000","message":"Please check\nhttps://review.openocd.org/c/openocd/+/8424","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8600a7e9e4e514d96ce735ecfc0b8054ba90ea7d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\tconst char *selected_id;"},{"line_number":24,"context_line":"\tif (CMD_ARGC \u003c 2 || CMD_ARGC \u003e 3)"},{"line_number":25,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":26,"context_line":"\tif (CMD_ARGC \u003d\u003d 2) {"},{"line_number":27,"context_line":"\t\tselected_id \u003d DEFAULT_ID;"},{"line_number":28,"context_line":"\t} else {"},{"line_number":29,"context_line":"\t\tselected_id \u003d CMD_ARGV[2];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f14dbecc_1e6c3841","line":26,"in_reply_to":"bb58a3f3_a5bdba86","updated":"2024-08-06 14:46:59.000000000","message":"Done","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"626545b9f6796d08bc4d48ed5a9ab052df2c0440","unresolved":true,"context_lines":[{"line_number":23,"context_line":"\tconst char *selected_id;"},{"line_number":24,"context_line":"\tif (CMD_ARGC \u003c 2 || CMD_ARGC \u003e 3)"},{"line_number":25,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":26,"context_line":"\tif (CMD_ARGC \u003d\u003d 2) {"},{"line_number":27,"context_line":"\t\tselected_id \u003d DEFAULT_ID;"},{"line_number":28,"context_line":"\t} else {"},{"line_number":29,"context_line":"\t\tselected_id \u003d CMD_ARGV[2];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ad7d90f8_3251cf48","line":26,"in_reply_to":"c7ccc4a9_a771f6d8","updated":"2024-08-01 08:32:33.000000000","message":"We use Linux checkpatch, which has 3 levels of reports: error, warning, check.\nSuch levels could have some meaning for Linux dev, but for our Jenkins they are all blocking, so they are all flatten to a single error level.\n\nLinux reviewers are free to ignore the report from checkpatch.\nIn OpenOCD we use the extra tag `Checkpatch-ignore:` to let Jenkins ignore specific cases (see HACKING).\n\nTo address uniform code, please drop the curly brackets in this case, and use `Checkpatch-ignore:` when you think checkpatch has hit a false positive.\n\nI\u0027m checking how to let checkpatch only report error.","commit_id":"9675f039a78f658f294f59a96bcec13256ba4bcc"}]}