)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7795bfe6afbb0b1c40393ad50df1092916f04dac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68a17f14_d1a90c7c","updated":"2024-09-02 12:57:49.000000000","message":"Thanks for the patch upstream\n\nWhen you send a new version of the same patch, keep the same `Change-Id:` in the commit message, so gerrit understands it\u0027s a new version","commit_id":"dfdcd768275eede11dd0a939b2b7edd68b8e116c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fd0bd8050e3a414c590d2b1525aee52a920732cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41bdeee4_6e5ced99","updated":"2024-09-02 12:59:57.000000000","message":"The failure looks due to some line of the commit message that exceed 75 characters\nand the script checkpatch complains.\n\nYou can run the script checkpatch locally in your PC to verify the patch before pushing it in gerrit. Check in file HACKING for the details","commit_id":"dfdcd768275eede11dd0a939b2b7edd68b8e116c"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"2258a1ab1e7933e9dd853ae09e8a585d7f2f7b0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74016d0a_92dadc4c","in_reply_to":"68a17f14_d1a90c7c","updated":"2024-09-02 15:08:09.000000000","message":"OK, thanks, fixed the commit message which was the only error now, so how to I trigger rebuild? I have abandoned the older two so this one is the only one to go now.","commit_id":"dfdcd768275eede11dd0a939b2b7edd68b8e116c"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"2258a1ab1e7933e9dd853ae09e8a585d7f2f7b0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b79681b7_7593a862","updated":"2024-09-02 15:08:09.000000000","message":"OK not sure if you triggered the rebuild or it just took time, but it looks fine now. So now what? I should just wait for someone to do the review?","commit_id":"ecd778bd7892c0514422682f59b799a5c7f106b4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"33caec43cc697a556e5de35c5732fe3fc0ebcc92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"260bfd3e_65447452","updated":"2024-09-02 19:41:49.000000000","message":"Thanks for this patch.\nI only have few minor remarks, for the rest it looks ok.\n\nMarc, do you have any comment on this patch?","commit_id":"3fc039e7a5414d15577b2f6c41cac3fda9272f89"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"5b58f385c9e49a296669802da94ab3f4e33ecafe","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"75686567_592a44f7","updated":"2024-11-13 09:11:04.000000000","message":"I\u0027ll fix those other ones, but idx,len are typical for handling buffer index and length, can\u0027t really think of anything better, please suggest.","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"83b47c2b1d717b86e559cb90323fcb55a14e341c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"66c3d31b_a8324358","updated":"2024-09-02 21:21:51.000000000","message":"Looks ok for me, thanks.\nLet\u0027s keep it on hold for 1~2 weeks waiting for further comments, then I will merge it.","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"ff49bf5caa7e29c5f2bc2aef0f7bd79a90ad7d93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7ac60d7_7c01f1ee","updated":"2024-09-02 21:02:56.000000000","message":"OK, fixed also other similar code with the missing out of memory.\n\nNot sure I should always squish commits into one or leave more of them with comments like \"code review fix\".","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c47e46575167dad9c7ad2270c500f199bbd5fce8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa907f90_6ce46434","updated":"2024-11-12 20:37:13.000000000","message":"Tested the current implementation and your patch, works as expected. Thanks! Just a few minor comments from my side.","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"6f4c64b5f9a93a3df243a40f34555df00e460014","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51728db5_75a79457","updated":"2024-09-11 12:18:38.000000000","message":"Thanks for the patch!\n\n@Antonio, give me some time to review and throw some regression tests etc. on it. I have a large backlog of reviews and patches ;)","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b1ba54de3e64c49cc38fcc5a10bda926df65131a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c86812a_4031597d","in_reply_to":"2a3bd18a_8a945525","updated":"2024-09-07 16:56:52.000000000","message":"The web page you report (generated from `HACKING` file) suggests the use of `git commit --amend` as a simple way to modify a commit that preserves the Change-Id.\n\nPersonally I don\u0027t like and I don\u0027t use this method; I first create some new commit with the extra changes and if it passes my tests I squash them with the old commit. It\u0027s similar to what you have done. In this case, the Change-Id has to be kept from the original commit.\nThis could be included in the document, but then it risks to get too complex for a new user; it\u0027s a kind of advanced `git` course that is out of the scope of the document.\n\nIf you have some simple wording that you think could work, feel free to propose a change to the `HACKING` file.","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"ac6697c5d9af653ac84da99d3b167ac8bd085cbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de092bc0_b9b807fa","in_reply_to":"4c86812a_4031597d","updated":"2024-09-08 09:48:18.000000000","message":"Oh, thanks, that explains it. I did not know how --ammend works exactly, was thinking it just modifies previous commit message. Probably got it from https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message where it does not explain more. Did not know it also takes staged local changes so did not know it is there in the HACKING guide to keep just one commit. So yes, --ammend would be easier then. But I already made more commits and the way you describe - first make next commit(s) until it is OK  and then squash and push if I think I am done feels more natural to me.","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"6f0c5567682ca1b74518954d34f1e6dea4e1b2d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2f1e3c02_278ae724","in_reply_to":"75686567_592a44f7","updated":"2024-12-12 11:00:48.000000000","message":"Done","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"83b47c2b1d717b86e559cb90323fcb55a14e341c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c84e1499_5b685822","in_reply_to":"c7ac60d7_7c01f1ee","updated":"2024-09-02 21:21:51.000000000","message":"Every fix required during the review should be squashed immediately.\nGerrit keep the history, so it\u0027s easy to navigate inside the history and see the comments and the changes.\n\nGithub, instead, horribly erases the history when you push a new version, making impossible to detect the delta. There it\u0027s common to push extra commit for the fixes, and then squash only when the review is going to be finalized (while loosing the history)","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"3cdb715359d8e071afb04334e844da7000294b13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a3bd18a_8a945525","in_reply_to":"c84e1499_5b685822","updated":"2024-09-03 09:21:28.000000000","message":"OK, thanks, basically I followed https://openocd.org/doc/doxygen/html/patchguide.html#stepbystep\nbut did not find anything about squashing into one commit there. Also was not sure on which branch I should work on and which should I push for review. It says \"contributions should be pushed to refs/for/master on the Gerrit server, even if you plan to use several local branches for different topics.\" which does not say which branch should I push/work on but maybe it is not clear because I don\u0027t understand git that much. Also it does not mention keeping the same Change-Id: so I was not sure which to keep when squashing commits - there were two IDs so somehow keeping the newest made better sense to me.","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"ed7d15893de48047e95589081139acdc5a5abe3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a456deec_c005b4b4","updated":"2024-12-12 10:54:10.000000000","message":"Hi Mark, I hope all your comments are resolved now, please check.","commit_id":"3383ea82ced862ff94afe2520a556db81cbb334a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b9435b3021c22a39bfc5701b59cb556058e3f961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7bcad685_793f0e35","updated":"2024-12-12 14:42:07.000000000","message":"Tested the latest version on hardware and it fixes the problem. Thanks!","commit_id":"3383ea82ced862ff94afe2520a556db81cbb334a"}],"src/server/rtt_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"33caec43cc697a556e5de35c5732fe3fc0ebcc92","unresolved":true,"context_lines":[{"line_number":67,"context_line":"\tdata \u003d calloc(1, sizeof(struct rtt_connection_data));"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"\tif (!data)"},{"line_number":70,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"\tconnection-\u003epriv \u003d (void *)data;"},{"line_number":73,"context_line":"\tservice \u003d connection-\u003eservice-\u003epriv;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"efc89aad_049fdb69","line":70,"updated":"2024-09-02 19:41:49.000000000","message":"Please add a line\n`LOG_ERROR(\"Out of memory\");`","commit_id":"3fc039e7a5414d15577b2f6c41cac3fda9272f89"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"ff49bf5caa7e29c5f2bc2aef0f7bd79a90ad7d93","unresolved":false,"context_lines":[{"line_number":67,"context_line":"\tdata \u003d calloc(1, sizeof(struct rtt_connection_data));"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"\tif (!data)"},{"line_number":70,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"\tconnection-\u003epriv \u003d (void *)data;"},{"line_number":73,"context_line":"\tservice \u003d connection-\u003eservice-\u003epriv;"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"08cddd87_4bb2c073","line":70,"in_reply_to":"efc89aad_049fdb69","updated":"2024-09-02 21:02:56.000000000","message":"Done","commit_id":"3fc039e7a5414d15577b2f6c41cac3fda9272f89"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"33caec43cc697a556e5de35c5732fe3fc0ebcc92","unresolved":true,"context_lines":[{"line_number":69,"context_line":"\tif (!data)"},{"line_number":70,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"\tconnection-\u003epriv \u003d (void *)data;"},{"line_number":73,"context_line":"\tservice \u003d connection-\u003eservice-\u003epriv;"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"\tLOG_DEBUG(\"rtt: New connection for channel %u\", service-\u003echannel);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a6e2c023_2cfbe571","line":72,"updated":"2024-09-02 19:41:49.000000000","message":"No need for cast when assigning something to a `void *`","commit_id":"3fc039e7a5414d15577b2f6c41cac3fda9272f89"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"ff49bf5caa7e29c5f2bc2aef0f7bd79a90ad7d93","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\tif (!data)"},{"line_number":70,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"\tconnection-\u003epriv \u003d (void *)data;"},{"line_number":73,"context_line":"\tservice \u003d connection-\u003eservice-\u003epriv;"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"\tLOG_DEBUG(\"rtt: New connection for channel %u\", service-\u003echannel);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a85316d9_c2590489","line":72,"in_reply_to":"a6e2c023_2cfbe571","updated":"2024-09-02 21:02:56.000000000","message":"Done","commit_id":"3fc039e7a5414d15577b2f6c41cac3fda9272f89"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"33caec43cc697a556e5de35c5732fe3fc0ebcc92","unresolved":true,"context_lines":[{"line_number":106,"context_line":"\tstruct rtt_connection_data *data;"},{"line_number":107,"context_line":"\tsize_t length, to_write;"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\tdata \u003d (struct rtt_connection_data *)connection-\u003epriv;"},{"line_number":110,"context_line":"\tservice \u003d (struct rtt_service *)connection-\u003eservice-\u003epriv;"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"\tif (!connection-\u003einput_pending) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6d5f805e_0d9c23cb","line":109,"updated":"2024-09-02 19:41:49.000000000","message":"No need for cast here too.\nActually also next line (not part of you patch) would need to drop the cast. Up to you if you want to clean it in your same patch.","commit_id":"3fc039e7a5414d15577b2f6c41cac3fda9272f89"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"ff49bf5caa7e29c5f2bc2aef0f7bd79a90ad7d93","unresolved":false,"context_lines":[{"line_number":106,"context_line":"\tstruct rtt_connection_data *data;"},{"line_number":107,"context_line":"\tsize_t length, to_write;"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\tdata \u003d (struct rtt_connection_data *)connection-\u003epriv;"},{"line_number":110,"context_line":"\tservice \u003d (struct rtt_service *)connection-\u003eservice-\u003epriv;"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"\tif (!connection-\u003einput_pending) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"aedfd2c3_0fe7cbb7","line":109,"in_reply_to":"6d5f805e_0d9c23cb","updated":"2024-09-02 21:02:56.000000000","message":"Done","commit_id":"3fc039e7a5414d15577b2f6c41cac3fda9272f89"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c47e46575167dad9c7ad2270c500f199bbd5fce8","unresolved":true,"context_lines":[{"line_number":31,"context_line":"struct rtt_connection_data {"},{"line_number":32,"context_line":"\tunsigned char data[64];"},{"line_number":33,"context_line":"\tunsigned int len;"},{"line_number":34,"context_line":"\tunsigned int idx;"},{"line_number":35,"context_line":"};"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"static int read_callback(unsigned int channel, const uint8_t *buffer,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"efa29bd4_804bc184","line":34,"updated":"2024-11-12 20:37:13.000000000","message":"Please use a more meaningful variable name","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"0f4fcd588ce71ea87ff5ee17775076e2eeab04d5","unresolved":true,"context_lines":[{"line_number":31,"context_line":"struct rtt_connection_data {"},{"line_number":32,"context_line":"\tunsigned char data[64];"},{"line_number":33,"context_line":"\tunsigned int len;"},{"line_number":34,"context_line":"\tunsigned int idx;"},{"line_number":35,"context_line":"};"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"static int read_callback(unsigned int channel, const uint8_t *buffer,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"c5288052_95dc0c6e","line":34,"in_reply_to":"af59863a_1fafbede","updated":"2024-11-14 16:52:48.000000000","message":"What about\n```\nunsigned char buffer[64];\nunsigned int length;\nunsigned int offset;\n```\n\n?","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"6f0c5567682ca1b74518954d34f1e6dea4e1b2d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"struct rtt_connection_data {"},{"line_number":32,"context_line":"\tunsigned char data[64];"},{"line_number":33,"context_line":"\tunsigned int len;"},{"line_number":34,"context_line":"\tunsigned int idx;"},{"line_number":35,"context_line":"};"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"static int read_callback(unsigned int channel, const uint8_t *buffer,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"ed1ba555_555bb11a","line":34,"in_reply_to":"c5288052_95dc0c6e","updated":"2024-12-12 11:00:48.000000000","message":"Done","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"5b58f385c9e49a296669802da94ab3f4e33ecafe","unresolved":true,"context_lines":[{"line_number":31,"context_line":"struct rtt_connection_data {"},{"line_number":32,"context_line":"\tunsigned char data[64];"},{"line_number":33,"context_line":"\tunsigned int len;"},{"line_number":34,"context_line":"\tunsigned int idx;"},{"line_number":35,"context_line":"};"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"static int read_callback(unsigned int channel, const uint8_t *buffer,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"af59863a_1fafbede","line":34,"in_reply_to":"efa29bd4_804bc184","updated":"2024-11-13 09:11:04.000000000","message":"Can you suggest one? I can\u0027t think of anything better.","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c47e46575167dad9c7ad2270c500f199bbd5fce8","unresolved":true,"context_lines":[{"line_number":103,"context_line":"static int rtt_input(struct connection *connection)"},{"line_number":104,"context_line":"{"},{"line_number":105,"context_line":"\tint bytes_read;"},{"line_number":106,"context_line":"\tunsigned char *ptr;"},{"line_number":107,"context_line":"\tstruct rtt_service *service;"},{"line_number":108,"context_line":"\tstruct rtt_connection_data *data;"},{"line_number":109,"context_line":"\tsize_t length, to_write;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a2ddaf88_6819af07","line":106,"updated":"2024-11-12 20:37:13.000000000","message":"Do not declare variables at the top of the function but as close as possible to their usage","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"6f0c5567682ca1b74518954d34f1e6dea4e1b2d5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"static int rtt_input(struct connection *connection)"},{"line_number":104,"context_line":"{"},{"line_number":105,"context_line":"\tint bytes_read;"},{"line_number":106,"context_line":"\tunsigned char *ptr;"},{"line_number":107,"context_line":"\tstruct rtt_service *service;"},{"line_number":108,"context_line":"\tstruct rtt_connection_data *data;"},{"line_number":109,"context_line":"\tsize_t length, to_write;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"b26cc87a_15a9138a","line":106,"in_reply_to":"a2ddaf88_6819af07","updated":"2024-12-12 11:00:48.000000000","message":"Done","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c47e46575167dad9c7ad2270c500f199bbd5fce8","unresolved":true,"context_lines":[{"line_number":125,"context_line":"\t\tdata-\u003eidx \u003d 0;"},{"line_number":126,"context_line":"\t}"},{"line_number":127,"context_line":"\tif (data-\u003elen \u003e 0) {"},{"line_number":128,"context_line":"\t\t// try sending data"},{"line_number":129,"context_line":"\t\tptr \u003d data-\u003edata + data-\u003eidx;"},{"line_number":130,"context_line":"\t\tlength \u003d data-\u003elen - data-\u003eidx;"},{"line_number":131,"context_line":"\t\tto_write \u003d length;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d94c19f0_6d4ac433","line":128,"updated":"2024-11-12 20:37:13.000000000","message":"In my opinion these comments are not necessary, better write a general (longer) comment what is the intention of this code block","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"6f0c5567682ca1b74518954d34f1e6dea4e1b2d5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"\t\tdata-\u003eidx \u003d 0;"},{"line_number":126,"context_line":"\t}"},{"line_number":127,"context_line":"\tif (data-\u003elen \u003e 0) {"},{"line_number":128,"context_line":"\t\t// try sending data"},{"line_number":129,"context_line":"\t\tptr \u003d data-\u003edata + data-\u003eidx;"},{"line_number":130,"context_line":"\t\tlength \u003d data-\u003elen - data-\u003eidx;"},{"line_number":131,"context_line":"\t\tto_write \u003d length;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"05579161_69baf25e","line":128,"in_reply_to":"d94c19f0_6d4ac433","updated":"2024-12-12 11:00:48.000000000","message":"Done","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c47e46575167dad9c7ad2270c500f199bbd5fce8","unresolved":true,"context_lines":[{"line_number":165,"context_line":"\tservice \u003d calloc(1, sizeof(struct rtt_service));"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"\tif (!service) {"},{"line_number":168,"context_line":"\t\tLOG_ERROR(\"Out of memory\");"},{"line_number":169,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":170,"context_line":"\t}"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"092785cd_850552d3","line":168,"updated":"2024-11-12 20:37:13.000000000","message":"This is out of context for this patch actually, but we can keep it","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"},{"author":{"_account_id":1002314,"name":"fanoush","email":"fanoush@gmail.com","username":"fanoush"},"change_message_id":"6f0c5567682ca1b74518954d34f1e6dea4e1b2d5","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\tservice \u003d calloc(1, sizeof(struct rtt_service));"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"\tif (!service) {"},{"line_number":168,"context_line":"\t\tLOG_ERROR(\"Out of memory\");"},{"line_number":169,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":170,"context_line":"\t}"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"682d0bcf_2cbd1555","line":168,"in_reply_to":"092785cd_850552d3","updated":"2024-12-12 11:00:48.000000000","message":"Done","commit_id":"c7a70ddcb4c4159c16118279911f85e8cd79ce96"}]}