)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"693577344a70a13a2ec23733bca92febdca26f3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b7c2aaad_375eae27","updated":"2024-09-02 20:38:37.000000000","message":"Thanks for the patch.\nI have few comments below","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"change_message_id":"fc7cdec2ea4f0051c7c625024bfd5fc3c145a2b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c972a793_91a58bf8","in_reply_to":"b7c2aaad_375eae27","updated":"2024-09-03 07:18:38.000000000","message":"Verified and it works, thanks for your comments.","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"}],"tcl/target/spacemit-k1.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"693577344a70a13a2ec23733bca92febdca26f3e","unresolved":true,"context_lines":[{"line_number":6,"context_line":"# https://www.spacemit.com/key-stone-k1"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"source [find interface/jlink.cfg]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"transport select jtag"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"36386edf_41490be3","line":9,"updated":"2024-09-02 20:38:37.000000000","message":"We usually put in `tcl/target/` only the SoC information, so the external adapter `jlink` is not supposed to be here.\nIf is there any board that host both the SoC and the `jlink` adapter, then a separate file in `tcl/board/` can be used for the setup.\n\nAlso the line `bindto 0.0.0.0` below is not supposed to be in this file.","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9da76c8695212b1914e90c4ea6a5f65deb108eb4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# https://www.spacemit.com/key-stone-k1"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"source [find interface/jlink.cfg]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"transport select jtag"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"927bc696_6fc0f626","line":9,"in_reply_to":"36386edf_41490be3","updated":"2024-09-03 06:43:03.000000000","message":"Done","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"693577344a70a13a2ec23733bca92febdca26f3e","unresolved":true,"context_lines":[{"line_number":53,"context_line":"set _smp_command \"target smp\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"for { set _core 0 } { $_core \u003c $_cores } { incr _core } {"},{"line_number":56,"context_line":"    set _command \"target create $_TARGETNAME.$_core riscv -chain-position $_TARGETNAME \\"},{"line_number":57,"context_line":"        -coreid [expr {$_core % 4}] -dbgbase [lindex $DBGBASE [expr {$_core / 4}]]\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if { [expr {$_core % 4}] \u003d\u003d 0 } {"},{"line_number":60,"context_line":"        set _command \"$_command -rtos hwthread\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"27a68dc8_9ee90970","line":57,"range":{"start_line":56,"start_character":4,"end_line":57,"end_character":83},"updated":"2024-09-02 20:38:37.000000000","message":"The information in `-coreid` has changed meaning, recently, with commits\nhttps://review.openocd.org/c/openocd/+/7957\nhttps://review.openocd.org/c/openocd/+/8129\nI think it is used correctly, here, to specify the hart ID in the Debug Module at address `-dbgbase`. Do you confirm my interpretation?\n\nThen, for readability, please use here directly:\n```\ntarget create $_TARGETNAME.$_core riscv -chain-position $_TARGETNAME \\\n -coreid [expr {$_core % 4}] -dbgbase [lindex $DBGBASE [expr {$_core / 4}]]\n```","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"change_message_id":"fc7cdec2ea4f0051c7c625024bfd5fc3c145a2b2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"set _smp_command \"target smp\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"for { set _core 0 } { $_core \u003c $_cores } { incr _core } {"},{"line_number":56,"context_line":"    set _command \"target create $_TARGETNAME.$_core riscv -chain-position $_TARGETNAME \\"},{"line_number":57,"context_line":"        -coreid [expr {$_core % 4}] -dbgbase [lindex $DBGBASE [expr {$_core / 4}]]\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if { [expr {$_core % 4}] \u003d\u003d 0 } {"},{"line_number":60,"context_line":"        set _command \"$_command -rtos hwthread\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"49474dfb_1960f8f2","line":57,"range":{"start_line":56,"start_character":4,"end_line":57,"end_character":83},"in_reply_to":"27a68dc8_9ee90970","updated":"2024-09-03 07:18:38.000000000","message":"Do you confirm my interpretation?  --\u003e Yes, we already test it with these commits","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7d6c0fa5a0c2d0ac9b14653e61cb0445b0ce025e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"set _smp_command \"target smp\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"for { set _core 0 } { $_core \u003c $_cores } { incr _core } {"},{"line_number":56,"context_line":"    set _command \"target create $_TARGETNAME.$_core riscv -chain-position $_TARGETNAME \\"},{"line_number":57,"context_line":"        -coreid [expr {$_core % 4}] -dbgbase [lindex $DBGBASE [expr {$_core / 4}]]\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if { [expr {$_core % 4}] \u003d\u003d 0 } {"},{"line_number":60,"context_line":"        set _command \"$_command -rtos hwthread\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"bb25b4d1_045f6090","line":57,"range":{"start_line":56,"start_character":4,"end_line":57,"end_character":83},"in_reply_to":"49474dfb_1960f8f2","updated":"2024-09-03 07:38:55.000000000","message":"Thanks!","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"693577344a70a13a2ec23733bca92febdca26f3e","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        -coreid [expr {$_core % 4}] -dbgbase [lindex $DBGBASE [expr {$_core / 4}]]\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if { [expr {$_core % 4}] \u003d\u003d 0 } {"},{"line_number":60,"context_line":"        set _command \"$_command -rtos hwthread\""},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    eval $_command"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ffd0fc36_caf7f7cb","line":60,"updated":"2024-09-02 20:38:37.000000000","message":"and here:\n`$_TARGETNAME.$_core configure -rtos hwthread`","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9da76c8695212b1914e90c4ea6a5f65deb108eb4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        -coreid [expr {$_core % 4}] -dbgbase [lindex $DBGBASE [expr {$_core / 4}]]\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if { [expr {$_core % 4}] \u003d\u003d 0 } {"},{"line_number":60,"context_line":"        set _command \"$_command -rtos hwthread\""},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    eval $_command"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"58c3bf15_ea30496d","line":60,"in_reply_to":"ffd0fc36_caf7f7cb","updated":"2024-09-03 06:43:03.000000000","message":"Done","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"693577344a70a13a2ec23733bca92febdca26f3e","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        set _command \"$_command -rtos hwthread\""},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    eval $_command"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    set _smp_command \"$_smp_command $_TARGETNAME.$_core\""},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"8262d727_018e8ec7","line":63,"updated":"2024-09-02 20:38:37.000000000","message":"then this line can be dropped","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9da76c8695212b1914e90c4ea6a5f65deb108eb4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        set _command \"$_command -rtos hwthread\""},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    eval $_command"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    set _smp_command \"$_smp_command $_TARGETNAME.$_core\""},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"65149cb7_c8efe6b6","line":63,"in_reply_to":"8262d727_018e8ec7","updated":"2024-09-03 06:43:03.000000000","message":"Done","commit_id":"88baf29e3a6e79cf2837d0b8ceb3e8a3277fb93a"}]}