)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c47deaa39ba1223d6197f6f93171c1b26cedeaa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5666c97_c7fd0936","updated":"2024-10-25 07:47:07.000000000","message":"Thanks for the patch!\nThe current coding style in `doc/manual/style.txt` reports:\n`- limit adjacent empty lines to at most two (2).`\nWith this patch merged, two consecutive empty line would be reported as error, while allowed in the coding stye.\n\nPossible improvements:\n- or modify the coding style in this same patch (but this would require more discussion to agree and to be approved);\n- or keep the current coding style and modify checkpatch to add detection of 3 or more empty lines. In this case you can use a new type `OPENOCD_LINE_SPACING` that would not clash with Linux `LINE_SPACING`.\n\nThen, checkpatch does not check LINE_SPACING on files `*.cfg`, `*.tcl`, `Makefile*`. I haven\u0027t investigated how to improve it, but it would be nice to have it too.","commit_id":"5a806add5a23853f40c92d3ab6d9c3c99060d14c"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"02c7e884fbfede4ef49be990b533b309c2ee9de0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71894da6_f7d1d36e","in_reply_to":"63248feb_6dfe5842","updated":"2024-10-26 11:16:30.000000000","message":"Thanks for your patch Mark! No need for multiple empty lines.","commit_id":"5a806add5a23853f40c92d3ab6d9c3c99060d14c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d42fcd56275dbfbce995b941512af045491b478f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a0d95a35_975d1bb5","in_reply_to":"71894da6_f7d1d36e","updated":"2025-11-16 16:05:37.000000000","message":"Waited one full year for comments! (actually lost this in my todo!)\nTime to proceed","commit_id":"5a806add5a23853f40c92d3ab6d9c3c99060d14c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f9b3d59a076c91ec57f76a4b88fe98a703717806","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63248feb_6dfe5842","in_reply_to":"731b2f9f_2c7864ad","updated":"2024-10-25 09:24:07.000000000","message":"I believe it\u0027s for historical reason and personal taste about code layout.\nI don\u0027t have any preference, so I\u0027m adding other people as reviewer for having their feedback.","commit_id":"5a806add5a23853f40c92d3ab6d9c3c99060d14c"},{"author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"change_message_id":"c4a8edf51594a638013a65a07cd849c0bed2d8e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"731b2f9f_2c7864ad","in_reply_to":"a5666c97_c7fd0936","updated":"2024-10-25 09:07:43.000000000","message":"Thanks, I\u0027ve looked at the git log and it doesn\u0027t seem to indicate when it\u0027s better to use 2 empty lines. Do you know the reason for this rule?","commit_id":"5a806add5a23853f40c92d3ab6d9c3c99060d14c"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"0ce17ca70cd29c0dee4fea8a47f1ff7356f7a285","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c58b7a5f_ff48bb58","updated":"2024-10-30 07:02:48.000000000","message":"Overall this looks good to me. I have just one question.","commit_id":"b838a59d15cc559ab96667e369e4173dcae7c426"},{"author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"change_message_id":"11d9d808b110bdd007def67cf6e38637891beb6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"20b1af4e_70ce71b4","updated":"2025-11-13 08:47:45.000000000","message":"ping","commit_id":"b838a59d15cc559ab96667e369e4173dcae7c426"}],"tools/scripts/checkpatch.pl":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"0ce17ca70cd29c0dee4fea8a47f1ff7356f7a285","unresolved":true,"context_lines":[{"line_number":4037,"context_line":"\t\t\t}"},{"line_number":4038,"context_line":"\t\t}"},{"line_number":4039,"context_line":""},{"line_number":4040,"context_line":"if (!$OpenOCD) {"},{"line_number":4041,"context_line":"# check for missing blank lines after struct/union declarations"},{"line_number":4042,"context_line":"# with exceptions for various attributes and macros"},{"line_number":4043,"context_line":"\t\tif ($prevline \u003d~ /^[\\+ ]};?\\s*$/ \u0026\u0026"}],"source_content_type":"text/x-perl","patch_set":2,"id":"ae596692_1f9b6dd0","line":4040,"updated":"2024-10-30 07:02:48.000000000","message":"What is please the reason for making these manual changes into checkpatch?\n\nWhat would be different if checkpatch.pl remained unchanged?","commit_id":"b838a59d15cc559ab96667e369e4173dcae7c426"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"766cff64deb5886c78eb59d8fd4f98a1d6b50295","unresolved":false,"context_lines":[{"line_number":4037,"context_line":"\t\t\t}"},{"line_number":4038,"context_line":"\t\t}"},{"line_number":4039,"context_line":""},{"line_number":4040,"context_line":"if (!$OpenOCD) {"},{"line_number":4041,"context_line":"# check for missing blank lines after struct/union declarations"},{"line_number":4042,"context_line":"# with exceptions for various attributes and macros"},{"line_number":4043,"context_line":"\t\tif ($prevline \u003d~ /^[\\+ ]};?\\s*$/ \u0026\u0026"}],"source_content_type":"text/x-perl","patch_set":2,"id":"bd1d52a1_b830cffe","line":4040,"in_reply_to":"a50d4bea_59f31682","updated":"2024-10-30 11:25:10.000000000","message":"Makes sense. Thank you for explanation.","commit_id":"b838a59d15cc559ab96667e369e4173dcae7c426"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7c8bf21b9e0857f26ad9032bc38481a67f0fa799","unresolved":true,"context_lines":[{"line_number":4037,"context_line":"\t\t\t}"},{"line_number":4038,"context_line":"\t\t}"},{"line_number":4039,"context_line":""},{"line_number":4040,"context_line":"if (!$OpenOCD) {"},{"line_number":4041,"context_line":"# check for missing blank lines after struct/union declarations"},{"line_number":4042,"context_line":"# with exceptions for various attributes and macros"},{"line_number":4043,"context_line":"\t\tif ($prevline \u003d~ /^[\\+ ]};?\\s*$/ \u0026\u0026"}],"source_content_type":"text/x-perl","patch_set":2,"id":"a50d4bea_59f31682","line":4040,"in_reply_to":"ae596692_1f9b6dd0","updated":"2024-10-30 09:01:57.000000000","message":"Checkpatch is copied from the Linux kernel and has hardcoded the coding style of the kernel, which differs from OpenOCD one.\nThe type `LINE_SPACING` enables three checks and we want only the second to be used in OpenOCD.\nThe other two require all declaration at the beginning of a block, followed by an empty line, then by the code. Instead in OpenOCD we accept declarations inside the code, so this should be considered as correct:\n```\n  int ret \u003d something(...);\n  if (ret !\u003d ERROR_OK) {\n    whatever;\n  }\n```\n\nIn the past OpenOCD version of checkpatch had parts deleted or replaced. Using this crap `(!$OpenOCD)` and similar is helpful to track the changes and to update checkpatch to new versions from Linux.","commit_id":"b838a59d15cc559ab96667e369e4173dcae7c426"}]}