)]}'
{"bootstrap":[{"author":{"_account_id":1002288,"name":"Ahmadi, Ehsan","email":"Ehsan.Ahmadi@analog.com","username":"Ehsan-Ahmadi_adi"},"change_message_id":"80a88c89b8f542249609cf53b8781041caefb741","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    echo \"Skipping submodule setup\""},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"    echo \"Setting up submodules\""},{"line_number":41,"context_line":"    git submodule init"},{"line_number":42,"context_line":"    git submodule sync"},{"line_number":43,"context_line":"    git submodule update"},{"line_number":44,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3dfb27f2_10f2685c","line":41,"updated":"2024-06-21 17:05:05.000000000","message":"I suggest changing the 3 lines with these 2. Been dealing with automating git workflows involving 10s of submodules and this has been reliable. --recursive is technically not needed right now but doesn\u0027t hurt and makes this future-proof.\n\ngit submodule sync --recursive\ngit submodule update --init --recursive","commit_id":"77a93f4bb0934f022e303aff3b9f3f400176d2aa"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e5748dea6bc2f83f65fffd3bcf3f94a50ba26ca8","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    echo \"Skipping submodule setup\""},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"    echo \"Setting up submodules\""},{"line_number":41,"context_line":"    git submodule init"},{"line_number":42,"context_line":"    git submodule sync"},{"line_number":43,"context_line":"    git submodule update"},{"line_number":44,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"673d500d_8a22a3e0","line":41,"in_reply_to":"3dfb27f2_10f2685c","updated":"2024-06-23 08:46:30.000000000","message":"Thanks for your review.\nThe recursive option is not needed and we are discussing about dropping the submodules completely from OpenOCD, so it will probably never be needed.\nYes, init and update can be fused in a single command. Running sync before update --init is ok.\n\nI will send a v2","commit_id":"77a93f4bb0934f022e303aff3b9f3f400176d2aa"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e952ac8100667265aefcf001a1ccbb001f3b7921","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    echo \"Skipping submodule setup\""},{"line_number":39,"context_line":"else"},{"line_number":40,"context_line":"    echo \"Setting up submodules\""},{"line_number":41,"context_line":"    git submodule init"},{"line_number":42,"context_line":"    git submodule sync"},{"line_number":43,"context_line":"    git submodule update"},{"line_number":44,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"52c64a17_db5d858d","line":41,"in_reply_to":"673d500d_8a22a3e0","updated":"2024-06-23 13:00:01.000000000","message":"Done","commit_id":"77a93f4bb0934f022e303aff3b9f3f400176d2aa"}]}
