)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"fe3fc6be6f183aa196e88118504354a633e4e6fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c4d7372_ebb06c6a","updated":"2024-07-11 23:53:09.000000000","message":"Could you elaborate on what problems this caused? and what platforms you were testing this against?","commit_id":"f7bef5149fe43e222681289809287d485c2bc0fe"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"aba458a99f576484a50e6fb872e317a9fac53a2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea14d7db_40be33a2","updated":"2024-07-13 07:33:02.000000000","message":"Thanks!","commit_id":"f7bef5149fe43e222681289809287d485c2bc0fe"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f4d88d71519ecec661ef7fe0c20a483375a57c79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"218bbdbb_91871f67","in_reply_to":"02980291_443184ae","updated":"2024-07-14 18:13:05.000000000","message":"Actually if the flash driver misses `-\u003e verify()` the default is to use `default_flash_verify()` that runs a crc check.\nSo the fallback is equivalent to `verify_image_checksum`, not to `verify_image`.\nAny concern on this?","commit_id":"f7bef5149fe43e222681289809287d485c2bc0fe"},{"author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"change_message_id":"a49e4842a39197b6d67add6f5292f72b98b34228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a0638a1_0b005d45","in_reply_to":"218bbdbb_91871f67","updated":"2024-07-15 00:56:31.000000000","message":"Good point, `verify_image` falls back to a binary compare if the CRC fails.\nI am unsure if this would cause any issues","commit_id":"f7bef5149fe43e222681289809287d485c2bc0fe"},{"author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"change_message_id":"15a84b19f6bd1c73b6119b8f597ae45105d6ff15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02980291_443184ae","in_reply_to":"48cbd23e_af4c9737","updated":"2024-07-13 08:08:10.000000000","message":"Done","commit_id":"f7bef5149fe43e222681289809287d485c2bc0fe"},{"author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"change_message_id":"d1c839a5246c32d6605e811e003369d3285a614b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48cbd23e_af4c9737","in_reply_to":"8c4d7372_ebb06c6a","updated":"2024-07-12 01:18:11.000000000","message":"I have a custom ASIC where the target does not have a complete view/mapping of external flash.\nI created a flash driver which implements the `struct flash_driver -\u003e verify()` interface, this works as intended.\n\nAlthough, the `program` procedure uses `verify_image` rather than `flash verify_image`.\n`verify_image` bypasses the flash driver interface, so only works for memory mapped flash.\n`flash verify_image` lets the flash driver determine how to do the verification (`struct flash_driver -\u003e verify()`) and falls back to a similar approach to `verify_image` if not implemented.\n\n`program` is part of the flash TCL and uses `flash write_image`, so IMO it would make sense to use `flash verify_image`.","commit_id":"f7bef5149fe43e222681289809287d485c2bc0fe"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"388f707fb184cf2dde134d2696ab9225cdf7f20a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad49c623_40cc2394","in_reply_to":"9a0638a1_0b005d45","updated":"2024-07-25 04:56:02.000000000","message":"In the case of verify error `verify_image` outputs the detailed comparison of the first 128 different bytes.\nUnfortunately `flash verify_image` just shows verify failed error without details. It seems me too complicated to run binary compare and show diff in `flash_driver_verify()`\n\nThis is the reason why `program` Tcl command still uses the former command.","commit_id":"f7bef5149fe43e222681289809287d485c2bc0fe"},{"author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"change_message_id":"98cde56e1bfc173fb225d7c9ecffe486c06ba53a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d8abf8a_942ad3cf","in_reply_to":"ad49c623_40cc2394","updated":"2024-07-25 07:58:40.000000000","message":"Ok that is understandable.\nI can override the `program` TCL command for my quirky use-case.\nI\u0027ll close this","commit_id":"f7bef5149fe43e222681289809287d485c2bc0fe"}]}