)]}'
{"id":"openocd~master~I5e88632fa0d0ce5a8129e9fcf5ae743fc5b093cb","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-09-21 09:05:36.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-09-14 16:53:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I5e88632fa0d0ce5a8129e9fcf5ae743fc5b093cb","subject":"server/telnet: Restructure commands","status":"MERGED","created":"2024-06-26 12:35:13.000000000","updated":"2024-09-21 09:05:36.000000000","submitted":"2024-09-21 09:05:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8378","meta_rev_id":"84414afe258ce1a562a440bd15e6dd187f2c7fb7","_number":8378,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-21 09:05:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-21 09:05:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-21 09:05:36.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-26 12:50:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-29 20:33:59.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-08-31 22:15:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"1304e0e3c410b141074f5aa5b102c869aea584e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-06-26 12:35:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c2a91b714310a7d0802018384fc3fa9e265a9520","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-26 12:50:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19749/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18905/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9e22d33e8ff786b76f207e894874fdea93addd8d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-31 22:15:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3b59ed333eb3a1e6917eb34af2ac5d3b65d8481f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-31 22:20:57.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"95c027f135b090f77eb96d0ff8fd7fb98fae8663","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-09-11 15:56:42.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"40cbe3e3e9e7703c3af40d16d0331a6193c8e4dd","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-09-11 15:59:01.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0e1631586b73b053ddf9077e18b21aca7a018040","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-11 16:11:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20002/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19157/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e0a176fb1e90af5f1f88ef52ca5b7f3e9077e879","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-14 16:53:32.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ea99aa228b4a5cd41172e93f57733c671630cd6d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-21 09:05:31.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"84414afe258ce1a562a440bd15e6dd187f2c7fb7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-21 09:05:36.000000000","message":"Change has been successfully cherry-picked as ad216136180e0cd482f414eb072c9dd25dd1c559","accounts_in_message":[],"_revision_number":3}],"current_revision":"ad216136180e0cd482f414eb072c9dd25dd1c559","revisions":{"d54cc7e02f0c17298d0b747ba4d040495e400e11":{"kind":"REWORK","_number":1,"created":"2024-06-26 12:35:13.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/78/8378/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/8378/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/1 \u0026\u0026 git checkout -b change-8378 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/8378/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a72e845d1be247b60348674addbfcd8917b6fff","subject":"server/gdb: Restructure commands"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-06-24 14:26:02.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-06-26 12:24:01.000000000","tz":120},"subject":"server/telnet: Restructure commands","message":"server/telnet: Restructure commands\n\nUse a command group \u0027telnet\u0027 with subcommands instead of individual\ncommands with \u0027telnet_\u0027 prefix. Even though there is only one subcommand\nat the moment, make this change to ensure consistency with other commands.\n\nThe old command is still available to ensure backwards compatibility,\nbut are marked as deprecated.\n\nChange-Id: I5e88632fa0d0ce5a8129e9fcf5ae743fc5b093cb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"df3ee2084a522d93354785e59757881c6d1d1565":{"kind":"REWORK","_number":2,"created":"2024-09-11 15:56:42.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/78/8378/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/8378/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/2 \u0026\u0026 git checkout -b change-8378 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/8378/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cbed09ee9bdbba27ca93f5883b79595f7e9d347d","subject":"tcl/target: Make sure R-Car Gen3 _targets variable is global"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-06-24 14:26:02.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-09-11 15:55:34.000000000","tz":120},"subject":"server/telnet: Restructure commands","message":"server/telnet: Restructure commands\n\nUse a command group \u0027telnet\u0027 with subcommands instead of individual\ncommands with \u0027telnet_\u0027 prefix. Even though there is only one subcommand\nat the moment, make this change to ensure consistency with other commands.\n\nThe old command is still available to ensure backwards compatibility,\nbut are marked as deprecated.\n\nChange-Id: I5e88632fa0d0ce5a8129e9fcf5ae743fc5b093cb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"ad216136180e0cd482f414eb072c9dd25dd1c559":{"kind":"REWORK","_number":3,"created":"2024-09-21 09:05:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/78/8378/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/8378/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/3 \u0026\u0026 git checkout -b change-8378 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/8378/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/8378/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e6ade35305fa32674d615a26713487b5ad00b352","subject":"server/gdb_server: improve error handling for `Z/z` packet"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-06-24 14:26:02.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-21 09:05:36.000000000","tz":0},"subject":"server/telnet: Restructure commands","message":"server/telnet: Restructure commands\n\nUse a command group \u0027telnet\u0027 with subcommands instead of individual\ncommands with \u0027telnet_\u0027 prefix. Even though there is only one subcommand\nat the moment, make this change to ensure consistency with other commands.\n\nThe old command is still available to ensure backwards compatibility,\nbut are marked as deprecated.\n\nChange-Id: I5e88632fa0d0ce5a8129e9fcf5ae743fc5b093cb\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8378\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}