)]}'
{"id":"openocd~master~I14447ecde63e579f1c523d606f048ad29cc84a35","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-08-06 14:31:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I14447ecde63e579f1c523d606f048ad29cc84a35","subject":"server/telnet: Always allow \u0027exit\u0027 command","status":"MERGED","created":"2024-06-26 12:35:13.000000000","updated":"2024-08-06 14:31:29.000000000","submitted":"2024-08-06 14:31:29.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8379","meta_rev_id":"74f4acd02c5bee3a27a83db8c1c2b603713d2d78","_number":8379,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-06 14:31:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-06 14:31:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-26 13:01:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-06-26 13:28:38.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"fa08b425d33e8bf755b8295cd54f6a2dcbe9531f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-06-26 12:35:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aad714aab423ea14ad142d4ba26a3415ed10b2d6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-26 13:01:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19750/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18906/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8e853116956a514ad933d421efbcbbad5b873cba","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-26 13:28:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"74f4acd02c5bee3a27a83db8c1c2b603713d2d78","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-06 14:31:29.000000000","message":"Change has been successfully cherry-picked as efe90221979458960618a5a5c8f90b116e91f011","accounts_in_message":[],"_revision_number":2}],"current_revision":"efe90221979458960618a5a5c8f90b116e91f011","revisions":{"d4f956298f2eb3c1439097f2977d2379b9300d21":{"kind":"REWORK","_number":1,"created":"2024-06-26 12:35:13.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/79/8379/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/8379/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/1 \u0026\u0026 git checkout -b change-8379 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/8379/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d54cc7e02f0c17298d0b747ba4d040495e400e11","subject":"server/telnet: Restructure commands"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-06-24 14:26:46.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-06-26 12:24:55.000000000","tz":120},"subject":"server/telnet: Always allow \u0027exit\u0027 command","message":"server/telnet: Always allow \u0027exit\u0027 command\n\nThe telnet \u0027exit\u0027 command is only available in the execution phase of\nOpenOCD. Thus, a telnet session cannot be closed via \u0027exit\u0027 if OpenOCD\nis started with \u0027noinit\u0027. Make the \u0027exit\u0027 command always available.\n\nChange-Id: I14447ecde63e579f1c523d606f048ad29cc84a35\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"efe90221979458960618a5a5c8f90b116e91f011":{"kind":"REWORK","_number":2,"created":"2024-08-06 14:31:29.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/79/8379/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/8379/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/2 \u0026\u0026 git checkout -b change-8379 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/8379/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/8379/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b9224c0c0f2a3d1ec52aab6ca985d1affa9a18b9","subject":"transport: Remove echo in transport selection"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-06-24 14:26:46.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-06 14:31:29.000000000","tz":0},"subject":"server/telnet: Always allow \u0027exit\u0027 command","message":"server/telnet: Always allow \u0027exit\u0027 command\n\nThe telnet \u0027exit\u0027 command is only available in the execution phase of\nOpenOCD. Thus, a telnet session cannot be closed via \u0027exit\u0027 if OpenOCD\nis started with \u0027noinit\u0027. Make the \u0027exit\u0027 command always available.\n\nChange-Id: I14447ecde63e579f1c523d606f048ad29cc84a35\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8379\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
