)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0cc2186903367c1f142750f91a5c546fe231efc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be743f6f_47a6fd9e","updated":"2024-07-15 15:42:45.000000000","message":"This patch should be the very first of this series because merged or tested alone still allows the build in current Jenkins.\nWe can merge this alone, then Paul can install `libjim-dev`, modify the build script to pass `--disable-internal-jimtcl` and force a dummy build for testing the new Jenkins setup.\nAfter this step, we can go ahead with the other patches in this series","commit_id":"c9b2133553dc240fd6658aa9d87cb9bb553ee250"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"095a6bf0be6c5f5d99b4a762831eff789653b8d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6221d8a7_210428ce","in_reply_to":"be743f6f_47a6fd9e","updated":"2024-07-16 12:08:13.000000000","message":"I was wrong about my proposal for Paul.\nSince debian don\u0027t use pkg-config on libjim, there is no need for this patch to proceed.\nWe can start right now to install `libjim-dev` and modify the build script to pass `--disable-internal-jimtcl`.It will already work!\n\nAnyway, having this patch as the first in the series helps the other developers to use libjim on distro that use pkg-config","commit_id":"c9b2133553dc240fd6658aa9d87cb9bb553ee250"}],"configure.ac":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5feef1b2c1de4b47e50f3e05f46cfee232679d7f","unresolved":true,"context_lines":[{"line_number":595,"context_line":"    AC_MSG_ERROR([jimtcl not found, run git submodule init and git submodule update.])"},{"line_number":596,"context_line":"  ])"},{"line_number":597,"context_line":"], ["},{"line_number":598,"context_line":"  PKG_CHECK_MODULES([JIMTCL], [jimtcl \u003e\u003d 0.82])"},{"line_number":599,"context_line":"])"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"AS_IF([test \"x$build_remote_bitbang\" \u003d \"xyes\"], ["}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7dd85221_c6c1cc77","line":598,"updated":"2024-07-14 15:12:51.000000000","message":"we still support older jimtcl \u003e\u003d 0.79.\nIf you put here this strict requirement, OpenOCD would not be buildable on too many Linux distro.\nClearly, a future distro that will integrate this new OpenOCD should also switch to a new jimtcl, but we are still in dev phase and developers are not time-traveler using such future distro.\nI would safely put here\n```\n  PKG_CHECK_MODULES([JIMTCL], [jimtcl \u003e\u003d 0.79])\n```","commit_id":"9853b6af57a8eceed37e57d763e8219506f5471b"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"b867aec7027a9f33b23da6798e133d81a4d84707","unresolved":false,"context_lines":[{"line_number":595,"context_line":"    AC_MSG_ERROR([jimtcl not found, run git submodule init and git submodule update.])"},{"line_number":596,"context_line":"  ])"},{"line_number":597,"context_line":"], ["},{"line_number":598,"context_line":"  PKG_CHECK_MODULES([JIMTCL], [jimtcl \u003e\u003d 0.82])"},{"line_number":599,"context_line":"])"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"AS_IF([test \"x$build_remote_bitbang\" \u003d \"xyes\"], ["}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bd49f07f_99e8cb31","line":598,"in_reply_to":"7dd85221_c6c1cc77","updated":"2024-07-14 16:06:50.000000000","message":"Ups, I thought we already need 0.82. Thanks!","commit_id":"9853b6af57a8eceed37e57d763e8219506f5471b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"0cc2186903367c1f142750f91a5c546fe231efc4","unresolved":true,"context_lines":[{"line_number":790,"context_line":"AM_CONDITIONAL([HAVE_CAPSTONE], [test \"x$enable_capstone\" !\u003d \"xno\"])"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"AM_CONDITIONAL([INTERNAL_JIMTCL], [test \"x$use_internal_jimtcl\" \u003d \"xyes\"])"},{"line_number":793,"context_line":"AM_CONDITIONAL([HAVE_JIMTCL_PKG_CONFIG], [test \"x$have_jimtcl_pkg_config\" \u003d \"xyes\"])"},{"line_number":794,"context_line":"AM_CONDITIONAL([INTERNAL_LIBJAYLINK], [test \"x$use_internal_libjaylink\" \u003d \"xyes\"])"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"# Look for environ alternatives.  Possibility #1: is environ in unistd.h or stdlib.h?"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"79e1be26_cb33da6a","line":793,"updated":"2024-07-15 15:42:45.000000000","message":"What is the purpose of `HAVE_JIMTCL_PKG_CONFIG` and `have_jimtcl_pkg_config` ?\nI think they can be dropped","commit_id":"c9b2133553dc240fd6658aa9d87cb9bb553ee250"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"fcf5896c6f070a84384ea1e565eb9a4f8170cd9a","unresolved":false,"context_lines":[{"line_number":790,"context_line":"AM_CONDITIONAL([HAVE_CAPSTONE], [test \"x$enable_capstone\" !\u003d \"xno\"])"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"AM_CONDITIONAL([INTERNAL_JIMTCL], [test \"x$use_internal_jimtcl\" \u003d \"xyes\"])"},{"line_number":793,"context_line":"AM_CONDITIONAL([HAVE_JIMTCL_PKG_CONFIG], [test \"x$have_jimtcl_pkg_config\" \u003d \"xyes\"])"},{"line_number":794,"context_line":"AM_CONDITIONAL([INTERNAL_LIBJAYLINK], [test \"x$use_internal_libjaylink\" \u003d \"xyes\"])"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"# Look for environ alternatives.  Possibility #1: is environ in unistd.h or stdlib.h?"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"0db9a633_2ccff86a","line":793,"in_reply_to":"79e1be26_cb33da6a","updated":"2024-07-15 16:05:31.000000000","message":"Ooops, sorry. Found it! Needed in the Makefile","commit_id":"c9b2133553dc240fd6658aa9d87cb9bb553ee250"}]}