)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d83b7c3cdf5334550450be9455fcd19ea6a69616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7b6e0526_ec1e9de7","updated":"2024-07-14 17:51:36.000000000","message":"Only a minor comment, not sure it is valid.\nOtherwise, I\u0027m ok with this","commit_id":"20a7f62bed49da35830c3e0f55c92debdf89312d"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"b829d4665594b26bfb1352a00ce98d1312c6fca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf98b56a_912f0c3c","in_reply_to":"7b6e0526_ec1e9de7","updated":"2024-10-28 15:53:58.000000000","message":"Thanks should be good","commit_id":"20a7f62bed49da35830c3e0f55c92debdf89312d"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"1e19ce653ec490ef17f0dd0ef6f983e2ebed6ab8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0277818e_0c17db2d","updated":"2024-11-26 13:15:54.000000000","message":"Thanks for the review Marc","commit_id":"3a46b2e8d19b980151b5b9cee251b0a23b830085"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"441c598e205298ef548adbf81e441dc3bf45fc5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a2901332_ba9b38fe","updated":"2024-11-15 15:46:58.000000000","message":"Thanks for your contribution! Here is a first (short) review from my side.","commit_id":"3a46b2e8d19b980151b5b9cee251b0a23b830085"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b70066d0a24f8dee36f90b8f09bd11f96c60d1d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"85540f34_b24f8ac2","updated":"2024-11-15 13:39:41.000000000","message":"Thanks!","commit_id":"3a46b2e8d19b980151b5b9cee251b0a23b830085"},{"author":{"_account_id":1002327,"name":"Henry Nguyen","email":"h-nguyen8@ti.com","username":"HenryNguyen01"},"change_message_id":"2fa699cf8a22ae3a7ab56c7929996d58de3ff62f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc242f16_6a61fd95","updated":"2024-11-15 14:16:35.000000000","message":"Works as expected👍","commit_id":"3a46b2e8d19b980151b5b9cee251b0a23b830085"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"eba4cd268c4e5bc43c6491f33bda1f733c9b3dec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4997238a_936cca5d","updated":"2025-01-28 17:37:07.000000000","message":"Thanks all for the review comments. New version with review fixes.","commit_id":"ecc6d1268e10040b8e95ec27c99c8996137d6b94"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"66780a70e246ca065850caa51cb365e222160f3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2ebaf58d_124e4f16","updated":"2025-02-19 16:31:55.000000000","message":"@Marc The comments should be addressed in the new revision. Thank you for taking the time to review.","commit_id":"bc7137ecdeb3fca1de4da131a095093da944a44d"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"fcd283e4dbf9d36c5ae4e0246cdb62c083d86752","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a85db698_4849a716","updated":"2025-02-07 01:36:14.000000000","message":"Thanks Tomas. Hopefully this is fixed now","commit_id":"bc7137ecdeb3fca1de4da131a095093da944a44d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d95ee9e34be66483448f15b336fb31cd99b20788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9290c42a_5c19334f","updated":"2025-02-11 11:47:17.000000000","message":"Thanks!","commit_id":"bc7137ecdeb3fca1de4da131a095093da944a44d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"77242b205b0b4a3c0624a04ec05235f8cffb8948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4eede8d7_5ead87fc","updated":"2025-03-01 23:04:05.000000000","message":"minor comments You can ignore them to keep the script simpler.","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"9a8f24a6e66da830e3f6d9c9c110899d4d11ae2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6c50f1c0_971a8bf5","updated":"2025-02-26 13:00:47.000000000","message":"no change. just a rebase","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"87bc95fe74565b774e8c9a3ab142840c31acf532","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9271340b_0dcef5b9","updated":"2025-03-03 14:34:37.000000000","message":"Thanks for the good catches. updated with fixes","commit_id":"4bf8a2e59888c7492f6964514966a76010fbfb55"}],"doc/openocd.texi":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"79a69ae70fb1f00504867feb5df0ee6fe51edf2e","unresolved":true,"context_lines":[{"line_number":7451,"context_line":""},{"line_number":7452,"context_line":"@end itemize"},{"line_number":7453,"context_line":""},{"line_number":7454,"context_line":"@deffn {Command} {mspm0 mspm0_board_reset}"},{"line_number":7455,"context_line":"Performs an nRST toggle on the device."},{"line_number":7456,"context_line":"@end deffn"},{"line_number":7457,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":8,"id":"bcac00aa_e8001691","line":7454,"updated":"2025-02-16 09:36:25.000000000","message":"The \u0027mspm0 \u0027 prefix is wrong. I would prefer to have it but this requires that the driver creates a \u0027mspm0\u0027 command object. But that\u0027s probably something for a later patch. Just remove it here, please.\n\nSame for the other commands below.","commit_id":"bc7137ecdeb3fca1de4da131a095093da944a44d"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"66780a70e246ca065850caa51cb365e222160f3f","unresolved":false,"context_lines":[{"line_number":7451,"context_line":""},{"line_number":7452,"context_line":"@end itemize"},{"line_number":7453,"context_line":""},{"line_number":7454,"context_line":"@deffn {Command} {mspm0 mspm0_board_reset}"},{"line_number":7455,"context_line":"Performs an nRST toggle on the device."},{"line_number":7456,"context_line":"@end deffn"},{"line_number":7457,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":8,"id":"42870cd2_bc5c9761","line":7454,"in_reply_to":"bcac00aa_e8001691","updated":"2025-02-19 16:31:55.000000000","message":"Done","commit_id":"bc7137ecdeb3fca1de4da131a095093da944a44d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"77242b205b0b4a3c0624a04ec05235f8cffb8948","unresolved":true,"context_lines":[{"line_number":7451,"context_line":""},{"line_number":7452,"context_line":"@end itemize"},{"line_number":7453,"context_line":""},{"line_number":7454,"context_line":"@deffn {Command} {mspm0_board_reset}"},{"line_number":7455,"context_line":"Performs an nRST toggle on the device."},{"line_number":7456,"context_line":"@end deffn"},{"line_number":7457,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":10,"id":"cc03f267_dc5df985","line":7454,"updated":"2025-03-01 23:04:05.000000000","message":"This and the other 2 new commands below are implemented as TCL proc\u0027s.\nI think this is the first time we document in this file some TCL procedure; usually we document the C commands wrapped as TCL commands.\nTo highlight this difference, would you mind using instead:\n`@deffn {TCL Proc} {mspm0_board_reset}`\nThe result of the documentation will still be readable.\n\nI often compare the commands in the C code with the doc to look at missing docs and using `Command` here will trigger instead documentation of missing commands.","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"87bc95fe74565b774e8c9a3ab142840c31acf532","unresolved":false,"context_lines":[{"line_number":7451,"context_line":""},{"line_number":7452,"context_line":"@end itemize"},{"line_number":7453,"context_line":""},{"line_number":7454,"context_line":"@deffn {Command} {mspm0_board_reset}"},{"line_number":7455,"context_line":"Performs an nRST toggle on the device."},{"line_number":7456,"context_line":"@end deffn"},{"line_number":7457,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":10,"id":"e6ec7fa5_b77a72fb","line":7454,"in_reply_to":"cc03f267_dc5df985","updated":"2025-03-03 14:34:37.000000000","message":"Done","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"}],"tcl/target/ti_mspm0.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d83b7c3cdf5334550450be9455fcd19ea6a69616","unresolved":true,"context_lines":[{"line_number":156,"context_line":"# Factory reset operations to function."},{"line_number":157,"context_line":"# However this cannot be the default configuration as this"},{"line_number":158,"context_line":"# prevents reset init reset halt to function properly"},{"line_number":159,"context_line":"# since the debugss logic or coresight seems impacted"},{"line_number":160,"context_line":"# by nRST."},{"line_number":161,"context_line":"# This can be overridden in board file as required."},{"line_number":162,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"496a150b_ecd0b0d3","line":159,"updated":"2024-07-14 17:51:36.000000000","message":"is `debugss` a typo?","commit_id":"20a7f62bed49da35830c3e0f55c92debdf89312d"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"b829d4665594b26bfb1352a00ce98d1312c6fca5","unresolved":false,"context_lines":[{"line_number":156,"context_line":"# Factory reset operations to function."},{"line_number":157,"context_line":"# However this cannot be the default configuration as this"},{"line_number":158,"context_line":"# prevents reset init reset halt to function properly"},{"line_number":159,"context_line":"# since the debugss logic or coresight seems impacted"},{"line_number":160,"context_line":"# by nRST."},{"line_number":161,"context_line":"# This can be overridden in board file as required."},{"line_number":162,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"4e723493_2d7d217b","line":159,"in_reply_to":"496a150b_ecd0b0d3","updated":"2024-10-28 15:53:58.000000000","message":"it stands for debug subsystem, so, realizing that not everyone knows these acronyms, I have expanded it for the next rev.","commit_id":"20a7f62bed49da35830c3e0f55c92debdf89312d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"441c598e205298ef548adbf81e441dc3bf45fc5d","unresolved":true,"context_lines":[{"line_number":161,"context_line":"# This can be overridden in board file as required."},{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"# mspm0_board_reset: Board level reset"},{"line_number":164,"context_line":"proc mspm0_board_reset {} {"},{"line_number":165,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":166,"context_line":"\treset_config srst_only combined srst_push_pull"},{"line_number":167,"context_line":"\treset"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"d2289730_13c2d959","line":164,"updated":"2024-11-15 15:46:58.000000000","message":"For other targets, such commands are part of the flash driver. I guess you implement it outside the driver because you need easy access to the SEC-AP? I any case, please document these commands in the manual (doc/openocd.texi).","commit_id":"3a46b2e8d19b980151b5b9cee251b0a23b830085"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"1e19ce653ec490ef17f0dd0ef6f983e2ebed6ab8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# This can be overridden in board file as required."},{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"# mspm0_board_reset: Board level reset"},{"line_number":164,"context_line":"proc mspm0_board_reset {} {"},{"line_number":165,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":166,"context_line":"\treset_config srst_only combined srst_push_pull"},{"line_number":167,"context_line":"\treset"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"34725a2b_72cac7d1","line":164,"in_reply_to":"d2289730_13c2d959","updated":"2024-11-26 13:15:54.000000000","message":"Done","commit_id":"3a46b2e8d19b980151b5b9cee251b0a23b830085"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"441c598e205298ef548adbf81e441dc3bf45fc5d","unresolved":true,"context_lines":[{"line_number":189,"context_line":"$_TARGETNAME configure -work-area-phys $_WORKAREABASE -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"set _FLASHNAME $_CHIPNAME.flash"},{"line_number":192,"context_line":"flash bank $_FLASHNAME.nonmain mspm0 0x41c00000 0 0 0 $_TARGETNAME"},{"line_number":193,"context_line":"flash bank $_FLASHNAME.main mspm0 0 0 0 0 $_TARGETNAME"},{"line_number":194,"context_line":"flash bank $_FLASHNAME.data mspm0 0x41d00000 0 0 0 $_TARGETNAME"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"8dda1728_1f897316","line":192,"updated":"2024-11-15 15:46:58.000000000","message":"Usability: please change the order and make \u0027*.main\u0027 the first flash bank as it is used for other targets. It tooks me a while until I understood why only a single sector is displayed ;)","commit_id":"3a46b2e8d19b980151b5b9cee251b0a23b830085"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"1e19ce653ec490ef17f0dd0ef6f983e2ebed6ab8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"$_TARGETNAME configure -work-area-phys $_WORKAREABASE -work-area-size $_WORKAREASIZE -work-area-backup 0"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"set _FLASHNAME $_CHIPNAME.flash"},{"line_number":192,"context_line":"flash bank $_FLASHNAME.nonmain mspm0 0x41c00000 0 0 0 $_TARGETNAME"},{"line_number":193,"context_line":"flash bank $_FLASHNAME.main mspm0 0 0 0 0 $_TARGETNAME"},{"line_number":194,"context_line":"flash bank $_FLASHNAME.data mspm0 0x41d00000 0 0 0 $_TARGETNAME"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"2b96cecf_5ab33622","line":192,"in_reply_to":"8dda1728_1f897316","updated":"2024-11-26 13:15:54.000000000","message":"Ack","commit_id":"3a46b2e8d19b980151b5b9cee251b0a23b830085"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5ecbe0c70d45357621426f9d9c8acafde8d77ddb","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"source [find target/swj-dp.tcl]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if { [using_jtag] } {"},{"line_number":32,"context_line":"\tset _DAP_ID $_DAP_TAPID"},{"line_number":33,"context_line":"} else {"},{"line_number":34,"context_line":"\tset _DAP_ID $_DAP_SWD_ID"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"8ded0b25_e7a6542f","line":31,"updated":"2024-12-03 10:58:24.000000000","message":"According to the TRMs, MSPM0L/G only supports SWD but you check for JTAG here and create an SWD/JTAG DAP. Why?","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"eba4cd268c4e5bc43c6491f33bda1f733c9b3dec","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"source [find target/swj-dp.tcl]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if { [using_jtag] } {"},{"line_number":32,"context_line":"\tset _DAP_ID $_DAP_TAPID"},{"line_number":33,"context_line":"} else {"},{"line_number":34,"context_line":"\tset _DAP_ID $_DAP_SWD_ID"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"48fa2235_75893ea6","line":31,"in_reply_to":"8ded0b25_e7a6542f","updated":"2025-01-28 17:37:07.000000000","message":"Dropped it. thanks for catching it.","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5ecbe0c70d45357621426f9d9c8acafde8d77ddb","unresolved":true,"context_lines":[{"line_number":77,"context_line":"\t# 8 LSBits of $command should matchup with SECAP::RCR"},{"line_number":78,"context_line":"\t# and"},{"line_number":79,"context_line":"\t# SECAP::RXD should be 0x10003"},{"line_number":80,"context_line":"\tif { ([expr { $command \u0026 0xff}] \u003d\u003d $rcr) \u0026\u0026 ($rxd \u003d\u003d 0x10003) } { return 0 }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\t# Provide some debug log for users to report back if CMD fails."},{"line_number":83,"context_line":"\treturn -code error [format \"MSPM0 SECAP CMD FAIL! RXD: 0x%08X RCR: 0x%08X\" $rxd $rcr]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"d2ef6968_877f5640","line":80,"updated":"2024-12-03 10:58:24.000000000","message":"Put the return in a separate line","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"eba4cd268c4e5bc43c6491f33bda1f733c9b3dec","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\t# 8 LSBits of $command should matchup with SECAP::RCR"},{"line_number":78,"context_line":"\t# and"},{"line_number":79,"context_line":"\t# SECAP::RXD should be 0x10003"},{"line_number":80,"context_line":"\tif { ([expr { $command \u0026 0xff}] \u003d\u003d $rcr) \u0026\u0026 ($rxd \u003d\u003d 0x10003) } { return 0 }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\t# Provide some debug log for users to report back if CMD fails."},{"line_number":83,"context_line":"\treturn -code error [format \"MSPM0 SECAP CMD FAIL! RXD: 0x%08X RCR: 0x%08X\" $rxd $rcr]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"d0caad9b_427e9f8d","line":80,"in_reply_to":"d2ef6968_877f5640","updated":"2025-01-28 17:37:07.000000000","message":"Done","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5ecbe0c70d45357621426f9d9c8acafde8d77ddb","unresolved":true,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"\t# Wait for ROM to do it\u0027s magic and respond back"},{"line_number":100,"context_line":"\tset res [_mspm0_wait_for_dssm_response $command]"},{"line_number":101,"context_line":"\tif { $res } { return $res }"},{"line_number":102,"context_line":"\t# Paranoid.. make sure ROM does what it is meant to do"},{"line_number":103,"context_line":"\t# RX valid should have been cleared after the operation is"},{"line_number":104,"context_line":"\t# complete"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"7b42bb3c_d6a75b57","line":101,"updated":"2024-12-03 10:58:24.000000000","message":"Same, please check for other similar coding style issues.","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"eba4cd268c4e5bc43c6491f33bda1f733c9b3dec","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"\t# Wait for ROM to do it\u0027s magic and respond back"},{"line_number":100,"context_line":"\tset res [_mspm0_wait_for_dssm_response $command]"},{"line_number":101,"context_line":"\tif { $res } { return $res }"},{"line_number":102,"context_line":"\t# Paranoid.. make sure ROM does what it is meant to do"},{"line_number":103,"context_line":"\t# RX valid should have been cleared after the operation is"},{"line_number":104,"context_line":"\t# complete"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"70f5f2bb_d241217f","line":101,"in_reply_to":"7b42bb3c_d6a75b57","updated":"2025-01-28 17:37:07.000000000","message":"Done","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1002341,"name":"Michael Walle","email":"michael@walle.cc","username":"mwalle"},"change_message_id":"0b1bd6a39f95f5bd240d16091084a025c7ac2d35","unresolved":true,"context_lines":[{"line_number":163,"context_line":"# mspm0_board_reset: Board level reset"},{"line_number":164,"context_line":"proc mspm0_board_reset {} {"},{"line_number":165,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":166,"context_line":"\treset_config srst_only combined srst_push_pull"},{"line_number":167,"context_line":"\treset"},{"line_number":168,"context_line":"\t# Restore the user configuration"},{"line_number":169,"context_line":"\tforeach rconfig $user_reset_config {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"c7e7ba3d_4e980961","line":166,"updated":"2024-11-27 09:34:41.000000000","message":"srst_push_pull sounds like it is really board dependent and might even be bad in some cases (i.e. if the reset is an open-drain bus and the debugger actively drives it high).","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"eba4cd268c4e5bc43c6491f33bda1f733c9b3dec","unresolved":false,"context_lines":[{"line_number":163,"context_line":"# mspm0_board_reset: Board level reset"},{"line_number":164,"context_line":"proc mspm0_board_reset {} {"},{"line_number":165,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":166,"context_line":"\treset_config srst_only combined srst_push_pull"},{"line_number":167,"context_line":"\treset"},{"line_number":168,"context_line":"\t# Restore the user configuration"},{"line_number":169,"context_line":"\tforeach rconfig $user_reset_config {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"a25aa29f_c294bd17","line":166,"in_reply_to":"395cc692_f22174a1","updated":"2025-01-28 17:37:07.000000000","message":"it should be srst_only. My bad!","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"be3aee213508480b84741f091ceeb9eea18e4358","unresolved":true,"context_lines":[{"line_number":163,"context_line":"# mspm0_board_reset: Board level reset"},{"line_number":164,"context_line":"proc mspm0_board_reset {} {"},{"line_number":165,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":166,"context_line":"\treset_config srst_only combined srst_push_pull"},{"line_number":167,"context_line":"\treset"},{"line_number":168,"context_line":"\t# Restore the user configuration"},{"line_number":169,"context_line":"\tforeach rconfig $user_reset_config {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"395cc692_f22174a1","line":166,"in_reply_to":"55251aa7_4fbae5c9","updated":"2025-01-03 21:00:56.000000000","message":"Also why `combined` (connected srst and trst) if `srst_only` ??!","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5ecbe0c70d45357621426f9d9c8acafde8d77ddb","unresolved":true,"context_lines":[{"line_number":163,"context_line":"# mspm0_board_reset: Board level reset"},{"line_number":164,"context_line":"proc mspm0_board_reset {} {"},{"line_number":165,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":166,"context_line":"\treset_config srst_only combined srst_push_pull"},{"line_number":167,"context_line":"\treset"},{"line_number":168,"context_line":"\t# Restore the user configuration"},{"line_number":169,"context_line":"\tforeach rconfig $user_reset_config {"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"55251aa7_4fbae5c9","line":166,"in_reply_to":"c7e7ba3d_4e980961","updated":"2024-12-03 10:58:24.000000000","message":"@Nishanth, can you comment this?","commit_id":"2460957a49d83f24878d689692f748bd82b1f1b1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2b9bc7f7c7e81a1ae603affb6b2133eedab1467f","unresolved":true,"context_lines":[{"line_number":170,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":171,"context_line":"\treset_config srst_only"},{"line_number":172,"context_line":"\treset"},{"line_number":173,"context_line":"\t# Restore the user configuration"},{"line_number":174,"context_line":"\tforeach rconfig $user_reset_config {"},{"line_number":175,"context_line":"\t\tset na [reset_config $rconfig]"},{"line_number":176,"context_line":"\t}"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"add_help_text mspm0_board_reset \"Request a board level reset\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"d74a07fc_d0599e4d","line":176,"range":{"start_line":173,"start_character":1,"end_line":176,"end_character":2},"updated":"2025-01-31 03:41:46.000000000","message":"Sorry I missed the last time:\nPlease simplify to\n`eval reset_config $user_reset_config`","commit_id":"18cf0336fc823d3e240df38737068b788a6931b4"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"fcd283e4dbf9d36c5ae4e0246cdb62c083d86752","unresolved":false,"context_lines":[{"line_number":170,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":171,"context_line":"\treset_config srst_only"},{"line_number":172,"context_line":"\treset"},{"line_number":173,"context_line":"\t# Restore the user configuration"},{"line_number":174,"context_line":"\tforeach rconfig $user_reset_config {"},{"line_number":175,"context_line":"\t\tset na [reset_config $rconfig]"},{"line_number":176,"context_line":"\t}"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"add_help_text mspm0_board_reset \"Request a board level reset\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"e128a7b4_d95f1cd7","line":176,"range":{"start_line":173,"start_character":1,"end_line":176,"end_character":2},"in_reply_to":"d74a07fc_d0599e4d","updated":"2025-02-07 01:36:14.000000000","message":"Done","commit_id":"18cf0336fc823d3e240df38737068b788a6931b4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"77242b205b0b4a3c0624a04ec05235f8cffb8948","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"add_help_text mspm0_start_bootloader \"Ask explicitly for bootloader startup\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"# MSPM0 requires board level NRST reset to be toggled for"},{"line_number":161,"context_line":"# Factory reset operations to function."},{"line_number":162,"context_line":"# However this cannot be the default configuration as this"},{"line_number":163,"context_line":"# prevents reset init reset halt to function properly"},{"line_number":164,"context_line":"# since the Debug Subsystem (debugss) logic or coresight"},{"line_number":165,"context_line":"# seems impacted by nRST."},{"line_number":166,"context_line":"# This can be overridden in board file as required."},{"line_number":167,"context_line":"#"},{"line_number":168,"context_line":"# mspm0_board_reset: Board level reset"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"1f83e7c2_deafdf30","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":25},"updated":"2025-03-01 23:04:05.000000000","message":"What a complicated situation!\nSince ages we are thinking about changing/improving the reset framework.\nThis is another odd case that be taken in consideration","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"},{"author":{"_account_id":1002327,"name":"Henry Nguyen","email":"h-nguyen8@ti.com","username":"HenryNguyen01"},"change_message_id":"f376520296ef7c4b268d84d1bf96d143fc3142f3","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"add_help_text mspm0_start_bootloader \"Ask explicitly for bootloader startup\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"# MSPM0 requires board level NRST reset to be toggled for"},{"line_number":161,"context_line":"# Factory reset operations to function."},{"line_number":162,"context_line":"# However this cannot be the default configuration as this"},{"line_number":163,"context_line":"# prevents reset init reset halt to function properly"},{"line_number":164,"context_line":"# since the Debug Subsystem (debugss) logic or coresight"},{"line_number":165,"context_line":"# seems impacted by nRST."},{"line_number":166,"context_line":"# This can be overridden in board file as required."},{"line_number":167,"context_line":"#"},{"line_number":168,"context_line":"# mspm0_board_reset: Board level reset"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"fc86bad5_3d5b2676","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":25},"in_reply_to":"1f83e7c2_deafdf30","updated":"2025-03-02 00:55:33.000000000","message":"Is there any place where this discussion is taking place? 😮\n\nWill be very interested as you noted our scenario is rather unique 😄","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"390169838160e161d8352e9734cb13a639942300","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"add_help_text mspm0_start_bootloader \"Ask explicitly for bootloader startup\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"# MSPM0 requires board level NRST reset to be toggled for"},{"line_number":161,"context_line":"# Factory reset operations to function."},{"line_number":162,"context_line":"# However this cannot be the default configuration as this"},{"line_number":163,"context_line":"# prevents reset init reset halt to function properly"},{"line_number":164,"context_line":"# since the Debug Subsystem (debugss) logic or coresight"},{"line_number":165,"context_line":"# seems impacted by nRST."},{"line_number":166,"context_line":"# This can be overridden in board file as required."},{"line_number":167,"context_line":"#"},{"line_number":168,"context_line":"# mspm0_board_reset: Board level reset"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"834cceb4_9553adeb","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":25},"in_reply_to":"fc86bad5_3d5b2676","updated":"2025-03-08 17:15:24.000000000","message":"The discussion is spread in the review messages in this series\nhttps://review.openocd.org/c/openocd/+/5210\nWe never succeed to recover it.","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"77242b205b0b4a3c0624a04ec05235f8cffb8948","unresolved":true,"context_lines":[{"line_number":169,"context_line":"proc mspm0_board_reset {} {"},{"line_number":170,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":171,"context_line":"\treset_config srst_only"},{"line_number":172,"context_line":"\treset"},{"line_number":173,"context_line":"\teval reset_config $user_reset_config"},{"line_number":174,"context_line":"}"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"caa7002c_48f47eb3","line":172,"updated":"2025-03-01 23:04:05.000000000","message":"`reset` can fail and it will force this proc to exit with error before recovering the former `reset_config`\nIt could be safer using\n`catch {reset}`\nbut then you loose completely the error.\nTo propagate the error, you can use he more complicated:\n```\nset errno [catch {reset}]\neval reset_config $user_reset_config\nif {$errno} {error}\n```","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"87bc95fe74565b774e8c9a3ab142840c31acf532","unresolved":false,"context_lines":[{"line_number":169,"context_line":"proc mspm0_board_reset {} {"},{"line_number":170,"context_line":"\tset user_reset_config [reset_config]"},{"line_number":171,"context_line":"\treset_config srst_only"},{"line_number":172,"context_line":"\treset"},{"line_number":173,"context_line":"\teval reset_config $user_reset_config"},{"line_number":174,"context_line":"}"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"6083ea23_8fc46b90","line":172,"in_reply_to":"caa7002c_48f47eb3","updated":"2025-03-03 14:34:37.000000000","message":"This is a good change, thanks for highlighting. applied","commit_id":"d7dc8cd45fd3c799e8e5d5812c18112733dfc9ff"}]}