)]}'
{"id":"openocd~master~Icaf1a1b2dea8bc55108182ea440708ab76396cd7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-07-28 13:26:05.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-07-18 06:30:53.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"Icaf1a1b2dea8bc55108182ea440708ab76396cd7","subject":"cortex_m: fix scan-build false positive","status":"MERGED","created":"2024-07-13 17:29:05.000000000","updated":"2024-07-28 13:26:05.000000000","submitted":"2024-07-28 13:26:05.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8391","meta_rev_id":"2d0491518b3666cadb7cae959a4c3fd3da43d780","_number":8391,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-28 13:26:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-28 13:26:05.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-28 13:26:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-13 17:36:49.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-07-13 18:08:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b27544e5edf830251b039b8b69f1e6cec50152c4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 17:29:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ee53ad25163a1ecc12569a3e5be9b5902917f12a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 17:36:49.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"706c89fca8237483b82387d4354dd4dcc7100b5a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-13 18:08:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19777/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18933/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"29b9c3c183c4aa29288932c1eb36d6face5ab38d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-07-18 06:30:53.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2d0491518b3666cadb7cae959a4c3fd3da43d780","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-28 13:26:05.000000000","message":"Change has been successfully cherry-picked as 5b7b77349c11e0a8f4b0967f31d65dde6ee01457","accounts_in_message":[],"_revision_number":2}],"current_revision":"5b7b77349c11e0a8f4b0967f31d65dde6ee01457","revisions":{"d0d51b7ec3cca4a65e8fe73a779bcf20b2c3152d":{"kind":"REWORK","_number":1,"created":"2024-07-13 17:29:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/8391/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8391/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/1 \u0026\u0026 git checkout -b change-8391 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8391/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23c33e1d3a332a94ef080451d43c6dc004e34750","subject":"target/cortex_m: workaround Cortex-M7 erratum 3092511"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 17:14:39.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 17:27:59.000000000","tz":120},"subject":"cortex_m: fix scan-build false positive","message":"cortex_m: fix scan-build false positive\n\nScan-build is unable to detect that \u0027target-\u003edbg_msg_enabled\u0027 does\nnot change across the function cortex_m_fast_read_all_regs().\nIt incorrectly assumes that it can be false at the first check (so\n\u0027dcrdr\u0027 get not assigned) and it is true later on (when \u0027dcrdr\u0027\nget used).\nThis triggers a false positive:\n\tsrc/target/cortex_m.c:338:12: warning:\n\t\t3rd function call argument is an uninitialized value\n\t\t[core.CallAndMessage]\n\tretval \u003d mem_ap_write_atomic_u32(armv7m-\u003edebug_ap, DCB_DCRDR, dcrdr);\n\nUse a local variable for \u0027target-\u003edbg_msg_enabled\u0027 so scan-build\ncan track it as not modified.\nWhile there, change the type of \u0027target-\u003edbg_msg_enabled\u0027 to\nboolean as there is no reason to use uint32_t.\n\nChange-Id: Icaf1a1b2dea8bc55108182ea440708ab76396cd7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5b7b77349c11e0a8f4b0967f31d65dde6ee01457":{"kind":"REWORK","_number":2,"created":"2024-07-28 13:26:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/8391/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8391/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/2 \u0026\u0026 git checkout -b change-8391 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8391/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8391/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"052a4a69b5098e23efaf4ef993a3f0c44d605943","subject":"flash/stm32l4x: support STM32U53/U54x devices"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 17:14:39.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-28 13:26:05.000000000","tz":0},"subject":"cortex_m: fix scan-build false positive","message":"cortex_m: fix scan-build false positive\n\nScan-build is unable to detect that \u0027target-\u003edbg_msg_enabled\u0027 does\nnot change across the function cortex_m_fast_read_all_regs().\nIt incorrectly assumes that it can be false at the first check (so\n\u0027dcrdr\u0027 get not assigned) and it is true later on (when \u0027dcrdr\u0027\nget used).\nThis triggers a false positive:\n\tsrc/target/cortex_m.c:338:12: warning:\n\t\t3rd function call argument is an uninitialized value\n\t\t[core.CallAndMessage]\n\tretval \u003d mem_ap_write_atomic_u32(armv7m-\u003edebug_ap, DCB_DCRDR, dcrdr);\n\nUse a local variable for \u0027target-\u003edbg_msg_enabled\u0027 so scan-build\ncan track it as not modified.\nWhile there, change the type of \u0027target-\u003edbg_msg_enabled\u0027 to\nboolean as there is no reason to use uint32_t.\n\nChange-Id: Icaf1a1b2dea8bc55108182ea440708ab76396cd7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8391\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}