)]}'
{"id":"openocd~master~I88855bd83b4e08e8fdcf86a2fa5ef3269dd4ad57","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2024-08-12 07:38:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1001667\u003e replied on the change","reason_account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-08-25 12:35:42.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I88855bd83b4e08e8fdcf86a2fa5ef3269dd4ad57","subject":"helper: command: drop radix parameter from command_parse_str_to_buf()","status":"MERGED","created":"2024-07-14 13:37:38.000000000","updated":"2024-08-25 12:35:47.000000000","submitted":"2024-08-25 12:35:47.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8393","meta_rev_id":"661de9e0a687aff6a181224fbaabd82c8b78cc62","_number":8393,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-25 12:35:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-25 12:35:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-25 12:35:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-14 13:37:38.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2024-07-14 15:20:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"69ebdc740cfc87333f227283b1bb520fb97310fd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-14 13:37:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"49a6a6d5d7267d7154c4af465163b4d90b0f30a5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-14 13:41:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9f8ba75dd32a4cbe2b75aaa604159106ae59b2dc","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-14 15:20:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19782/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18937/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"871c097b7f2397961d48e9206e368f0052369220","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-02 15:55:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8f55d91deeb3fa4dae11fbe348d37c97df69f5d6","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-08-12 07:38:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6e045469fc34ab273f280b0461eb5a268371483b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 12:35:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"661de9e0a687aff6a181224fbaabd82c8b78cc62","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 12:35:47.000000000","message":"Change has been successfully cherry-picked as ea859e1cd042578ea17994b56ac15be216eefe4a","accounts_in_message":[],"_revision_number":2}],"current_revision":"ea859e1cd042578ea17994b56ac15be216eefe4a","revisions":{"7ea3f10501ef76fa1077e0fd3c0128491731b9a3":{"kind":"REWORK","_number":1,"created":"2024-07-14 13:37:38.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/93/8393/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/93/8393/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/1 \u0026\u0026 git checkout -b change-8393 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/93/8393/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f2d3e2925833c952ee73fb178c8fdee637c844e","subject":"rtos/hwthread: derive threadid from SMP index"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-14 09:28:49.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-14 09:28:49.000000000","tz":120},"subject":"helper: command: drop radix parameter from command_parse_str_to_buf()","message":"helper: command: drop radix parameter from command_parse_str_to_buf()\n\nCommit 53b94fad58ab (\"binarybuffer: Fix str_to_buf() parsing\nfunction\") introduces the helper command_parse_str_to_buf() to\nparse as number a string on TCL command-line.\nThe parameter \u0027radix\u0027 can specify the base (decimal, octal,\nhexadecimal, or auto-detected).\n\nTCL is supposed to use decimal numbers by default, while octal and\nhexadecimal numbers must be prefixed respectively with \u00270\u0027 and\n\u00270x\u0027 (or \u00270X\u0027).\nThis would require the helper to always run auto-detection of the\nbase, thus always set the \u0027radix\u0027 parameter to zero. This makes\nthe parameter useless.\n\nKeeping the \u0027radix\u0027 parameter can open the door to future abuse of\nTCL syntax, E.g. a command can require an octal value without the\nmandatory TCL \u00270\u0027 prefix; the octal value cannot be the result of\nTCL expression.\n\nTo prevent any future abuse of the \u0027radix\u0027 parameter, drop it.\n\nChange-Id: I88855bd83b4e08e8fdcf86a2fa5ef3269dd4ad57\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"ea859e1cd042578ea17994b56ac15be216eefe4a":{"kind":"REWORK","_number":2,"created":"2024-08-25 12:35:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/93/8393/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/93/8393/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/2 \u0026\u0026 git checkout -b change-8393 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/93/8393/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/93/8393/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a414ffaf65171bf2d1ed289397befca3cbf8b967","subject":"doc: document command \u0027ms\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-14 09:28:49.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-25 12:35:47.000000000","tz":0},"subject":"helper: command: drop radix parameter from command_parse_str_to_buf()","message":"helper: command: drop radix parameter from command_parse_str_to_buf()\n\nCommit 53b94fad58ab (\"binarybuffer: Fix str_to_buf() parsing\nfunction\") introduces the helper command_parse_str_to_buf() to\nparse as number a string on TCL command-line.\nThe parameter \u0027radix\u0027 can specify the base (decimal, octal,\nhexadecimal, or auto-detected).\n\nTCL is supposed to use decimal numbers by default, while octal and\nhexadecimal numbers must be prefixed respectively with \u00270\u0027 and\n\u00270x\u0027 (or \u00270X\u0027).\nThis would require the helper to always run auto-detection of the\nbase, thus always set the \u0027radix\u0027 parameter to zero. This makes\nthe parameter useless.\n\nKeeping the \u0027radix\u0027 parameter can open the door to future abuse of\nTCL syntax, E.g. a command can require an octal value without the\nmandatory TCL \u00270\u0027 prefix; the octal value cannot be the result of\nTCL expression.\n\nTo prevent any future abuse of the \u0027radix\u0027 parameter, drop it.\n\nChange-Id: I88855bd83b4e08e8fdcf86a2fa5ef3269dd4ad57\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8393\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}