)]}'
{"id":"openocd~master~I1cef9a1ec5ff0e5841ba582610f273e89e7a81da","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2024-08-12 08:24:45.000000000","reason":"\u003cGERRIT_ACCOUNT_1001667\u003e replied on the change","reason_account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-08-25 12:36:21.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I1cef9a1ec5ff0e5841ba582610f273e89e7a81da","subject":"binarybuffer: str_to_buf(): simplify it and fix scan-build error","status":"MERGED","created":"2024-07-14 13:37:38.000000000","updated":"2024-08-25 12:36:29.000000000","submitted":"2024-08-25 12:36:29.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8396","meta_rev_id":"203c620ebdbb81829e487579843899318aa47c6e","_number":8396,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-25 12:36:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-25 12:36:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-25 12:36:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-14 13:37:38.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2024-07-14 16:01:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3fd577572bc57c38bc37f9517377069f701e4caa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-14 13:37:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1871148d424a93cfad717352761d890a250aa65f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-14 13:42:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"249cb8d7b252436f36a6db9636027045ab59165e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-14 16:01:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18939/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/19783/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bec3b86392055a837ad04e841719e1de929f195e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-21 13:25:10.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"efa93c12a49cf8d99befc019cda709c71c177830","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-21 13:38:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19814/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18970/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ccbd7644ade83c3d794178a6c79d8c03046d3a9f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-21 13:46:49.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6762749563e40f297ed69015133c43876aa51800","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-08-12 07:41:47.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"01e069b5719c767b6dbff9f755ea93427c80f123","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-12 08:19:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0320e518fe7055c6f80e9fb1e47a93258f5629e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-12 08:20:21.000000000","message":"Patch Set 3: Published edit on patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"529a00ef25db79bbd73650c05b001d754e11185f","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-08-12 08:24:45.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"3fcaa4f903ecde29f0249f8155db1c3bad575c5f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-12 08:34:02.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19869/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19024/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"2c36466b8e92058aa7af35d087ba2b72a8cb739b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 12:36:21.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"203c620ebdbb81829e487579843899318aa47c6e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 12:36:29.000000000","message":"Change has been successfully cherry-picked as bfd3110e59f5b13c075823c654f1a51cfcd66d4d","accounts_in_message":[],"_revision_number":4}],"current_revision":"bfd3110e59f5b13c075823c654f1a51cfcd66d4d","revisions":{"bfd3110e59f5b13c075823c654f1a51cfcd66d4d":{"kind":"REWORK","_number":4,"created":"2024-08-25 12:36:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/96/8396/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/8396/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/4 \u0026\u0026 git checkout -b change-8396 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/8396/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bee5999a447880dda271926bbbd7d49dc5f4fbe9","subject":"binarybuffer: str_to_buf(): rename buf_len as buf_bitsize"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-14 12:59:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-25 12:36:29.000000000","tz":0},"subject":"binarybuffer: str_to_buf(): simplify it and fix scan-build error","message":"binarybuffer: str_to_buf(): simplify it and fix scan-build error\n\nThe function str_to_buf() can be simplified by writing directly\nthe intermediate results in the output buffer.\nSuch simplification improves the readability and also makes\nscan-build happy, as it does not trigger anymore the warning:\n\tsrc/helper/binarybuffer.c:328:8: warning: Use of memory\n\tallocated with size zero [unix.Malloc]\n\t\tif ((b256_buf[(buf_len / 8)] \u0026 mask) !\u003d 0x0) {\n\nChange-Id: I1cef9a1ec5ff0e5841ba582610f273e89e7a81da\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8396\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nTested-by: jenkins\n"}},"9bbdb687cf16355d4cba5e20aac41084c9ac6058":{"kind":"REWORK","_number":1,"created":"2024-07-14 13:37:38.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/96/8396/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/8396/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/1 \u0026\u0026 git checkout -b change-8396 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/8396/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a775cab49ed72f0699c4b5839f3f61f140fbd05","subject":"binarybuffer: str_to_buf(): rename buf_len as buf_bitsize"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-14 12:59:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-14 13:37:01.000000000","tz":120},"subject":"binarybuffer: str_to_buf(): simplify it and fix scan-build error","message":"binarybuffer: str_to_buf(): simplify it and fix scan-build error\n\nThe function str_to_buf() can be simplified by writing directly\nthe intermediate results in the output buffer.\nSuch simplification improves the readability and also makes\nscan-build happy, as it does not trigger anymore the warning:\n\tsrc/helper/binarybuffer.c:328:8: warning: Use of memory\n\tallocated with size zero [unix.Malloc]\n\t\tif ((b256_buf[(buf_len / 8)] \u0026 mask) !\u003d 0x0) {\n\nChange-Id: I1cef9a1ec5ff0e5841ba582610f273e89e7a81da\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f12467fb6ea971d4a2d8bc8ac62be095fa13c05a":{"kind":"REWORK","_number":3,"created":"2024-08-12 08:20:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/96/8396/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/8396/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/3 \u0026\u0026 git checkout -b change-8396 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/8396/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a775cab49ed72f0699c4b5839f3f61f140fbd05","subject":"binarybuffer: str_to_buf(): rename buf_len as buf_bitsize"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-14 12:59:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-12 08:18:39.000000000","tz":0},"subject":"binarybuffer: str_to_buf(): simplify it and fix scan-build error","message":"binarybuffer: str_to_buf(): simplify it and fix scan-build error\n\nThe function str_to_buf() can be simplified by writing directly\nthe intermediate results in the output buffer.\nSuch simplification improves the readability and also makes\nscan-build happy, as it does not trigger anymore the warning:\n\tsrc/helper/binarybuffer.c:328:8: warning: Use of memory\n\tallocated with size zero [unix.Malloc]\n\t\tif ((b256_buf[(buf_len / 8)] \u0026 mask) !\u003d 0x0) {\n\nChange-Id: I1cef9a1ec5ff0e5841ba582610f273e89e7a81da\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"6d3a1055497fcf2e72c25670ee672aa2efe15980":{"kind":"REWORK","_number":2,"created":"2024-07-21 13:25:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/96/8396/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/8396/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/2 \u0026\u0026 git checkout -b change-8396 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/8396/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/8396/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a775cab49ed72f0699c4b5839f3f61f140fbd05","subject":"binarybuffer: str_to_buf(): rename buf_len as buf_bitsize"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-14 12:59:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-21 13:24:04.000000000","tz":120},"subject":"binarybuffer: str_to_buf(): simplify it and fix scan-build error","message":"binarybuffer: str_to_buf(): simplify it and fix scan-build error\n\nThe function str_to_buf() can be simplified by writing directly\nthe intermediate results in the output buffer.\nSuch simplification improves the readability and also makes\nscan-build happy, as it does not trigger anymore the warning:\n\tsrc/helper/binarybuffer.c:328:8: warning: Use of memory\n\tallocated with size zero [unix.Malloc]\n\t\tif ((b256_buf[(buf_len / 8)] \u0026 mask) !\u003d 0x0) {\n\nChange-Id: I1cef9a1ec5ff0e5841ba582610f273e89e7a81da\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}