)]}'
{"id":"openocd~master~Ic66029b988404a1599bb99bc66d4a8845b8b02c6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-11-02 20:59:48.000000000","reason":"Change was submitted"},"1000859":{"account":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"last_update":"2024-11-02 20:59:48.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-10-25 16:49:30.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"Ic66029b988404a1599bb99bc66d4a8845b8b02c6","subject":"target: cortex_m: fix polling for target kept under reset","status":"MERGED","created":"2024-07-15 10:14:20.000000000","updated":"2024-11-02 20:59:48.000000000","submitted":"2024-11-02 20:59:48.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"8399","meta_rev_id":"12f96f996ee3fb13525fa5c5d485f5abd918db4a","_number":8399,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-02 20:59:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-11-02 20:59:48.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-11-02 20:59:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-15 10:14:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"},{"updated":"2024-07-15 10:14:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-07-15 10:32:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8b72f83b08a41bab1e9a4ccf12cc94ff1c2809f8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-15 10:14:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3150bf2db19571e201cdc13d8c59540ac7c5bc5c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-15 10:21:25.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"92c01201e39609d62d9edca2e043e5c0f4baddbe","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-15 10:32:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19788/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18944/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c9973e19577a78e07e2b08cb3c0d5be27fc03b82","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-07-17 16:35:40.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"555a737f403d4ced387c6929a64ee196c4b74b27","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2024-08-06 13:11:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ffee0ee32c4f855ba51b420dd9f530ed3ce77c92","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-06 14:43:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1005d8f36faac49c185eba5787015bb8881a722d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-08 16:29:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"592a0cb4f3de8a953a75aa43c974e68ac4d83194","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:40:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"eee067a124360c1d972b69810a79a1e51c6dee60","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-10-25 16:49:30.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"12f96f996ee3fb13525fa5c5d485f5abd918db4a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-11-02 20:59:48.000000000","message":"Change has been successfully cherry-picked as 3ce0962f2c525595bcbd0bd5da73673e236fc42d","accounts_in_message":[],"_revision_number":2}],"current_revision":"3ce0962f2c525595bcbd0bd5da73673e236fc42d","revisions":{"3ce0962f2c525595bcbd0bd5da73673e236fc42d":{"kind":"REWORK","_number":2,"created":"2024-11-02 20:59:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/8399/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/8399/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/2 \u0026\u0026 git checkout -b change-8399 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/8399/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7214c8be46f749f210e00d334c30883bd73cca03","subject":"configure: show adapter Xilinx XVC/PCIe in the configuration summary"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-15 09:56:36.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-11-02 20:59:48.000000000","tz":0},"subject":"target: cortex_m: fix polling for target kept under reset","message":"target: cortex_m: fix polling for target kept under reset\n\nIn multi-target SoC not all the targets are running simultaneously\nand some target could be powered off or kept under reset.\nCommit 4892e32294c6 (\"target/cortex_m: allow poll quickly get out\nof TARGET_RESET state\") does not considers the case of a target\nthat is kept in reset and expects the target to change state from\nTARGET_RESET immediately.\nThis causes OpenOCD to log continuously:\n\tInfo : [stm32mp15x.cm4] external reset detected\n\tInfo : [stm32mp15x.cm4] external reset detected\n\tInfo : [stm32mp15x.cm4] external reset detected\n\nRead again dhcsr to detect the \u0027stable\u0027 reset status and quit,\nwaiting for next poll to re-check the target\u0027s status.\n\nChange-Id: Ic66029b988404a1599bb99bc66d4a8845b8b02c6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 4892e32294c6 (\"target/cortex_m: allow poll quickly get out of TARGET_RESET state\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8399\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"8e18f0874c1fced5870114163d092f2f872a1be5":{"kind":"REWORK","_number":1,"created":"2024-07-15 10:14:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/8399/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/8399/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/1 \u0026\u0026 git checkout -b change-8399 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/8399/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/8399/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f2d3e2925833c952ee73fb178c8fdee637c844e","subject":"rtos/hwthread: derive threadid from SMP index"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-15 09:56:36.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-15 10:12:44.000000000","tz":120},"subject":"target: cortex_m: fix polling for target kept under reset","message":"target: cortex_m: fix polling for target kept under reset\n\nIn multi-target SoC not all the targets are running simultaneously\nand some target could be powered off or kept under reset.\nCommit 4892e32294c6 (\"target/cortex_m: allow poll quickly get out\nof TARGET_RESET state\") does not considers the case of a target\nthat is kept in reset and expects the target to change state from\nTARGET_RESET immediately.\nThis causes OpenOCD to log continuously:\n\tInfo : [stm32mp15x.cm4] external reset detected\n\tInfo : [stm32mp15x.cm4] external reset detected\n\tInfo : [stm32mp15x.cm4] external reset detected\n\nRead again dhcsr to detect the \u0027stable\u0027 reset status and quit,\nwaiting for next poll to re-check the target\u0027s status.\n\nChange-Id: Ic66029b988404a1599bb99bc66d4a8845b8b02c6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 4892e32294c6 (\"target/cortex_m: allow poll quickly get out of TARGET_RESET state\")\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}