)]}'
{"src/jtag/core.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"901b24558391ab90101cb8c7956d47af35f01ab3","unresolved":true,"context_lines":[{"line_number":1472,"context_line":"\tjtag_tap_add(tap);"},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"\tLOG_DEBUG(\"Created Tap: %s @ abs position %u, \""},{"line_number":1475,"context_line":"\t\t\t\"irlen %d, capture: 0x%x mask: 0x%x\", tap-\u003edotted_name,"},{"line_number":1476,"context_line":"\t\t\ttap-\u003eabs_chain_position, tap-\u003eir_length,"},{"line_number":1477,"context_line":"\t\t\t(unsigned) tap-\u003eir_capture_value,"},{"line_number":1478,"context_line":"\t\t\t(unsigned) tap-\u003eir_capture_mask);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"362f53e0_3e060e3e","line":1475,"updated":"2024-07-20 09:28:50.000000000","message":"`irlen %u,`","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e346c369a1383631c1cd517bdaa528bdf99fcd1c","unresolved":false,"context_lines":[{"line_number":1472,"context_line":"\tjtag_tap_add(tap);"},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"\tLOG_DEBUG(\"Created Tap: %s @ abs position %u, \""},{"line_number":1475,"context_line":"\t\t\t\"irlen %d, capture: 0x%x mask: 0x%x\", tap-\u003edotted_name,"},{"line_number":1476,"context_line":"\t\t\ttap-\u003eabs_chain_position, tap-\u003eir_length,"},{"line_number":1477,"context_line":"\t\t\t(unsigned) tap-\u003eir_capture_value,"},{"line_number":1478,"context_line":"\t\t\t(unsigned) tap-\u003eir_capture_mask);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ffcd1068_96fc9ecc","line":1475,"in_reply_to":"362f53e0_3e060e3e","updated":"2024-07-21 19:51:40.000000000","message":"Done","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"}],"src/jtag/jtag.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"901b24558391ab90101cb8c7956d47af35f01ab3","unresolved":true,"context_lines":[{"line_number":86,"context_line":" */"},{"line_number":87,"context_line":"struct scan_field {"},{"line_number":88,"context_line":"\t/** The number of bits this field specifies */"},{"line_number":89,"context_line":"\tint num_bits;"},{"line_number":90,"context_line":"\t/** A pointer to value to be scanned into the device */"},{"line_number":91,"context_line":"\tconst uint8_t *out_value;"},{"line_number":92,"context_line":"\t/** A pointer to a 32-bit memory location for data scanned out */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"43c659d3_a40ba2de","line":89,"updated":"2024-07-20 09:28:50.000000000","message":"I see that `ir_length` gets assigned to this `num_bits`, e.g. in\n`src/flash/nor/jtagspi.c:90`\n`src/flash/nor/str9xpec.c:79`\nPlease consider changing this to `unsigned int` in a following patch","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e346c369a1383631c1cd517bdaa528bdf99fcd1c","unresolved":false,"context_lines":[{"line_number":86,"context_line":" */"},{"line_number":87,"context_line":"struct scan_field {"},{"line_number":88,"context_line":"\t/** The number of bits this field specifies */"},{"line_number":89,"context_line":"\tint num_bits;"},{"line_number":90,"context_line":"\t/** A pointer to value to be scanned into the device */"},{"line_number":91,"context_line":"\tconst uint8_t *out_value;"},{"line_number":92,"context_line":"\t/** A pointer to a 32-bit memory location for data scanned out */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"02b8a0c1_5683125a","line":89,"in_reply_to":"43c659d3_a40ba2de","updated":"2024-07-21 19:51:40.000000000","message":"Done","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"}],"src/target/avrt.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"901b24558391ab90101cb8c7956d47af35f01ab3","unresolved":false,"context_lines":[{"line_number":153,"context_line":"\t\tLOG_ERROR(\"invalid tap\");"},{"line_number":154,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":155,"context_line":"\t}"},{"line_number":156,"context_line":"\tif ((unsigned int)ir_len !\u003d tap-\u003eir_length) {"},{"line_number":157,"context_line":"\t\tLOG_ERROR(\"invalid ir_len\");"},{"line_number":158,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":159,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"925dd993_5ec1afbe","line":156,"updated":"2024-07-20 09:28:50.000000000","message":"Not really nice adding this cast, but agree this is the minimal fix.\nThis functions prototype (and other in this file) should be adjusted. E.g. the parameter `rti` can be dropped as it\u0027s always `1` and not used!\nLet\u0027s merge this patch, then return on it","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"}],"src/target/lakemont.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"901b24558391ab90101cb8c7956d47af35f01ab3","unresolved":true,"context_lines":[{"line_number":224,"context_line":"\tif (ir_len !\u003d t-\u003etap-\u003eir_length) {"},{"line_number":225,"context_line":"\t\tretval \u003d ERROR_FAIL;"},{"line_number":226,"context_line":"\t\tif (t-\u003etap-\u003eenabled)"},{"line_number":227,"context_line":"\t\t\tLOG_ERROR(\"%s tap enabled but tap irlen\u003d%d\","},{"line_number":228,"context_line":"\t\t\t\t\t__func__, t-\u003etap-\u003eir_length);"},{"line_number":229,"context_line":"\t\telse"},{"line_number":230,"context_line":"\t\t\tLOG_ERROR(\"%s tap not enabled and irlen\u003d%d\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cc759d94_c390142d","line":227,"updated":"2024-07-20 09:28:50.000000000","message":"`%u`","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e346c369a1383631c1cd517bdaa528bdf99fcd1c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"\tif (ir_len !\u003d t-\u003etap-\u003eir_length) {"},{"line_number":225,"context_line":"\t\tretval \u003d ERROR_FAIL;"},{"line_number":226,"context_line":"\t\tif (t-\u003etap-\u003eenabled)"},{"line_number":227,"context_line":"\t\t\tLOG_ERROR(\"%s tap enabled but tap irlen\u003d%d\","},{"line_number":228,"context_line":"\t\t\t\t\t__func__, t-\u003etap-\u003eir_length);"},{"line_number":229,"context_line":"\t\telse"},{"line_number":230,"context_line":"\t\t\tLOG_ERROR(\"%s tap not enabled and irlen\u003d%d\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b7c455b0_b0f88184","line":227,"in_reply_to":"cc759d94_c390142d","updated":"2024-07-21 19:51:40.000000000","message":"Done","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"901b24558391ab90101cb8c7956d47af35f01ab3","unresolved":true,"context_lines":[{"line_number":227,"context_line":"\t\t\tLOG_ERROR(\"%s tap enabled but tap irlen\u003d%d\","},{"line_number":228,"context_line":"\t\t\t\t\t__func__, t-\u003etap-\u003eir_length);"},{"line_number":229,"context_line":"\t\telse"},{"line_number":230,"context_line":"\t\t\tLOG_ERROR(\"%s tap not enabled and irlen\u003d%d\","},{"line_number":231,"context_line":"\t\t\t\t\t__func__, t-\u003etap-\u003eir_length);"},{"line_number":232,"context_line":"\t\treturn retval;"},{"line_number":233,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e4e5d647_8b9e0acb","line":230,"updated":"2024-07-20 09:28:50.000000000","message":"ditto","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e346c369a1383631c1cd517bdaa528bdf99fcd1c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"\t\t\tLOG_ERROR(\"%s tap enabled but tap irlen\u003d%d\","},{"line_number":228,"context_line":"\t\t\t\t\t__func__, t-\u003etap-\u003eir_length);"},{"line_number":229,"context_line":"\t\telse"},{"line_number":230,"context_line":"\t\t\tLOG_ERROR(\"%s tap not enabled and irlen\u003d%d\","},{"line_number":231,"context_line":"\t\t\t\t\t__func__, t-\u003etap-\u003eir_length);"},{"line_number":232,"context_line":"\t\treturn retval;"},{"line_number":233,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c1727edc_e2424a0a","line":230,"in_reply_to":"e4e5d647_8b9e0acb","updated":"2024-07-21 19:51:40.000000000","message":"Done","commit_id":"2f6b9e8fbab944aac65bd072af78f8d26809c933"}]}