)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3d2b502910471b09db36966fa8d8e3fce4b5a661","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e33d54cf_00d2bb1f","updated":"2024-07-20 09:57:34.000000000","message":"Too big patch to really validate everything and to check for the `%u` in all the format strings, but I would not block the merge for this.\nThere is one real issue below.\nHave you checked if `scan-build` triggers some new issue?","commit_id":"aae53ce6b16547b2aa6c673f5aed5d4a6f393c8c"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"64a45fd8f2e6e7a8c108d290e6e8b18a2e19bcd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ccff2758_e4178d94","in_reply_to":"e33d54cf_00d2bb1f","updated":"2024-07-22 09:04:34.000000000","message":"Indeed, the patch is very long and the work is tedious and time consuming. It clearly shows why we need to enforce an appropriate coding style and data types.\n\nYep, I check the patch with `scan-build` and found no new issues.","commit_id":"aae53ce6b16547b2aa6c673f5aed5d4a6f393c8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"33d135be68747bb36c56b393ca932fc3d33b83ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5ccf207_c21efa74","updated":"2024-07-21 19:58:11.000000000","message":"Thanks!\nI hope someone else will also give a check to this long patch.","commit_id":"cca0c4a9145bacdea12c19b8086f95403fdf768d"}],"src/jtag/drivers/bitq.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3d2b502910471b09db36966fa8d8e3fce4b5a661","unresolved":true,"context_lines":[{"line_number":18,"context_line":"/* state of input queue */"},{"line_number":19,"context_line":"struct bitq_state {"},{"line_number":20,"context_line":"\tstruct jtag_command *cmd; /* command currently processed */"},{"line_number":21,"context_line":"\tint field_idx; /* index of field currently being processed */"},{"line_number":22,"context_line":"\tint bit_pos; /* position of bit currently being processed */"},{"line_number":23,"context_line":"\tint status; /* processing status */"},{"line_number":24,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bb19279a_4266d5fb","line":21,"updated":"2024-07-20 09:57:34.000000000","message":"I prefer you change this to `unsigned int` instead of adding a cast in line 38","commit_id":"aae53ce6b16547b2aa6c673f5aed5d4a6f393c8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"33d135be68747bb36c56b393ca932fc3d33b83ce","unresolved":false,"context_lines":[{"line_number":18,"context_line":"/* state of input queue */"},{"line_number":19,"context_line":"struct bitq_state {"},{"line_number":20,"context_line":"\tstruct jtag_command *cmd; /* command currently processed */"},{"line_number":21,"context_line":"\tint field_idx; /* index of field currently being processed */"},{"line_number":22,"context_line":"\tint bit_pos; /* position of bit currently being processed */"},{"line_number":23,"context_line":"\tint status; /* processing status */"},{"line_number":24,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"27940a5e_205c374f","line":21,"in_reply_to":"bb19279a_4266d5fb","updated":"2024-07-21 19:58:11.000000000","message":"Done","commit_id":"aae53ce6b16547b2aa6c673f5aed5d4a6f393c8c"}],"src/jtag/drivers/openjtag.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3d2b502910471b09db36966fa8d8e3fce4b5a661","unresolved":true,"context_lines":[{"line_number":768,"context_line":""},{"line_number":769,"context_line":"\t\t\topenjtag_add_byte(command);"},{"line_number":770,"context_line":"\t\t\tnum_cycles -\u003d 16;"},{"line_number":771,"context_line":"\t\t} while (num_cycles \u003e 0);"},{"line_number":772,"context_line":"\t}"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"\ttap_set_end_state(end_state);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"987a4005_c46e273a","line":771,"updated":"2024-07-20 09:57:34.000000000","message":"I\u0027m not sure this will work!\nAt line 767 it\u0027s assumed that `num_cycles` could be less than 16.\nThen at line 770 it is decremented by 16, so would get negative if it was still `int`.\nThis test here fails with `unsigned int` type.\nThe loop could be fixed computing the decrement, then using it in line 767 and 770.","commit_id":"aae53ce6b16547b2aa6c673f5aed5d4a6f393c8c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"33d135be68747bb36c56b393ca932fc3d33b83ce","unresolved":false,"context_lines":[{"line_number":768,"context_line":""},{"line_number":769,"context_line":"\t\t\topenjtag_add_byte(command);"},{"line_number":770,"context_line":"\t\t\tnum_cycles -\u003d 16;"},{"line_number":771,"context_line":"\t\t} while (num_cycles \u003e 0);"},{"line_number":772,"context_line":"\t}"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"\ttap_set_end_state(end_state);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"27fe79ce_369a49ab","line":771,"in_reply_to":"987a4005_c46e273a","updated":"2024-07-21 19:58:11.000000000","message":"Done","commit_id":"aae53ce6b16547b2aa6c673f5aed5d4a6f393c8c"}]}