)]}'
{"id":"openocd~master~Idcbbbbbea2705512201eb326c3e6cef110dbc674","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-08-02 16:04:49.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-07-28 14:17:15.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"Idcbbbbbea2705512201eb326c3e6cef110dbc674","subject":"jtag: Use \u0027unsigned int\u0027 for \u0027scan_field.num_bits\u0027","status":"MERGED","created":"2024-07-21 18:32:16.000000000","updated":"2024-08-02 16:04:49.000000000","submitted":"2024-08-02 16:04:49.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8413","meta_rev_id":"29f239419b847ef2f6947665fa184b8d2e25be02","_number":8413,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-02 16:04:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-02 16:04:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-21 19:08:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-21 20:08:38.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-07-28 14:17:15.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"85693567f30c80a6c6b01d3739bee9d65a0c4fc9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-07-21 18:32:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"40a2781881e1563cb5e585b3473db7c8f8aaa311","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-21 19:08:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19819/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18975/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9ca8280ac7ab932caf45de51d2ce6275ab89b5f4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-21 20:08:38.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3da88f42081b4d771ec1eefced2b12c89bf9e0a7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-07-22 06:52:21.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"dbc007ffcdd430a820748be1c5bee74e30c694be","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-22 08:27:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19824/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18979/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"dda781d91b9dc30b504981efe2b7b5703e9d5847","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-07-22 09:05:21.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"38b1442306bb5d11f13a61b86858d144a69640ef","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-28 14:17:15.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"cadd0bde6cb4d6aa2ca821451dd33a780679142f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-02 16:04:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"29f239419b847ef2f6947665fa184b8d2e25be02","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-02 16:04:49.000000000","message":"Change has been successfully cherry-picked as 7d56407ba7b43fddbbce412de2d1eddb51c46bfa","accounts_in_message":[],"_revision_number":3}],"current_revision":"7d56407ba7b43fddbbce412de2d1eddb51c46bfa","revisions":{"7d56407ba7b43fddbbce412de2d1eddb51c46bfa":{"kind":"REWORK","_number":3,"created":"2024-08-02 16:04:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/13/8413/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/8413/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/3 \u0026\u0026 git checkout -b change-8413 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/8413/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9ef59daef00fbf79985c2f4801c55e6116d475d3","subject":"target/avrt: Remove unused parameter \u0027rti\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-07-21 18:28:17.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-02 16:04:49.000000000","tz":0},"subject":"jtag: Use \u0027unsigned int\u0027 for \u0027scan_field.num_bits\u0027","message":"jtag: Use \u0027unsigned int\u0027 for \u0027scan_field.num_bits\u0027\n\nThis patch modifies as little code as possible in order to simplify the\nreview. Data types that are affected by these changes will be addresses\nin following patches.\n\nWhile at it, apply coding style fixes if these are not too extensive.\n\nChange-Id: Idcbbbbbea2705512201eb326c3e6cef110dbc674\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8413\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"32ed5dc23613a3a085cf2b7d9a30d91780a5f4cc":{"kind":"REWORK","_number":2,"created":"2024-07-22 06:52:21.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/13/8413/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/8413/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/2 \u0026\u0026 git checkout -b change-8413 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/8413/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a2c6075daa0c3588dc505b1c0d362ed195173303","subject":"target/avrt: Remove unused parameter \u0027rti\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-07-21 18:28:17.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-07-22 06:49:11.000000000","tz":120},"subject":"jtag: Use \u0027unsigned int\u0027 for \u0027scan_field.num_bits\u0027","message":"jtag: Use \u0027unsigned int\u0027 for \u0027scan_field.num_bits\u0027\n\nThis patch modifies as little code as possible in order to simplify the\nreview. Data types that are affected by these changes will be addresses\nin following patches.\n\nWhile at it, apply coding style fixes if these are not too extensive.\n\nChange-Id: Idcbbbbbea2705512201eb326c3e6cef110dbc674\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"6bf51a9cf799d384648cccbf14e4d2b21424ce72":{"kind":"REWORK","_number":1,"created":"2024-07-21 18:32:16.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/13/8413/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/8413/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/1 \u0026\u0026 git checkout -b change-8413 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/8413/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/8413/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8d92e133cb2851094e9a6d53c80a6868862ac70c","subject":"target/avrt: Remove unused parameter \u0027rti\u0027"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-07-21 18:28:17.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-07-21 18:31:50.000000000","tz":120},"subject":"jtag: Use \u0027unsigned int\u0027 for \u0027scan_field.num_bits\u0027","message":"jtag: Use \u0027unsigned int\u0027 for \u0027scan_field.num_bits\u0027\n\nThis patch modifies as little code as possible in order to simplify the\nreview. Data types that are affected by these changes will be addresses\nin following patches.\n\nWhile at it, apply coding style fixes if these are not too extensive.\n\nChange-Id: Idcbbbbbea2705512201eb326c3e6cef110dbc674\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}