)]}'
{"id":"openocd~master~I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-07-28 14:06:53.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2026-01-27 15:06:55.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}},"1002286":{"account":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"last_update":"2026-02-01 15:00:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c","subject":"target: arm_dap: Fix crash in \u0027dap info\u0027 command","status":"MERGED","created":"2024-07-23 22:59:12.000000000","updated":"2026-02-01 15:00:24.000000000","submitted":"2026-02-01 15:00:24.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":17,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8415","meta_rev_id":"df9c747a3dd3aaf79af9f182d134ee97d8ebb464","_number":8415,"owner":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-01 15:00:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-01 15:00:24.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-02-01 15:00:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-23 23:14:06.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-24 00:18:43.000000000","updated_by":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-07-25 04:06:48.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2026-01-27 15:06:55.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"4380e3692ae04ea56e644a8a0f0cb988359ef709","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"real_author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"date":"2024-07-23 22:59:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a9c815ae148b049c4140322e016a031b43c841a9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-23 23:14:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19828/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18984/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8ccaf6dc922e9e209b42521add754be2e5594de1","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-07-25 04:06:48.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ee127fd992e17ade8b57cd8bbdd7aa7240b1eafa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"real_author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"date":"2024-07-25 08:49:23.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6d9d8e407c1ead650e5b6c4ca0c4302904272748","author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"real_author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"date":"2024-07-25 08:52:47.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"de733711dd9e2ea9135107cbff9226c84d7a657c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"real_author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"date":"2024-07-25 08:55:59.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4630c0d33432e7e5fecf52bd7ff2b72afcbff2da","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-25 08:56:12.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18986/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/19830/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8ab1953c0c66e375b9bf06013af0439892df4de5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-25 09:18:05.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18987/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/19831/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"45b077fbc50985c8a3894ed23302d84d8e1eeb02","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"real_author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"date":"2024-07-26 02:23:51.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"7eb45b8a12e54f4f8adee12339a4a889fe3fa727","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-26 02:37:31.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19835/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18991/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"631bc2103a11192835fba30262af3116fd62bbbb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-26 08:04:21.000000000","message":"Patch Set 4: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"c02eb6a1480c5d8c410b1ae29eb88f1ddeb668d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"real_author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"date":"2024-07-26 08:43:18.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"b2c8a8cfb7cf5e663dbf357f6a48e13b4f6beb77","author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"real_author":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"date":"2024-07-26 08:52:35.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"1e3cb4e22192b5ca625b5083c7eb2ff6669a0727","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-07-26 09:10:14.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19838/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18993/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"b495c6ebb605b480b6add33c081d178cf952b7bd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-28 14:06:53.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"310f82ecd593acef79ce49ef5bec828a6a25c972","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-01-27 15:06:55.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"df9c747a3dd3aaf79af9f182d134ee97d8ebb464","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-01 15:00:24.000000000","message":"Change has been successfully cherry-picked as db34f6f0a71baa9c97794cb347dc3c74b3ef729d","accounts_in_message":[],"_revision_number":6}],"current_revision":"db34f6f0a71baa9c97794cb347dc3c74b3ef729d","revisions":{"db34f6f0a71baa9c97794cb347dc3c74b3ef729d":{"kind":"REWORK","_number":6,"created":"2026-02-01 15:00:24.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/15/8415/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8415/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/6 \u0026\u0026 git checkout -b change-8415 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8415/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"92b482af50f367c1416c4a70ceabab36c19788d1","subject":"log: change line counter to unsigned"}],"author":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-26 08:39:20.000000000","tz":720},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-01 15:00:24.000000000","tz":0},"subject":"target: arm_dap: Fix crash in \u0027dap info\u0027 command","message":"target: arm_dap: Fix crash in \u0027dap info\u0027 command\n\nThe \u0027dap info\u0027 command was not checking that the target was\nan ARM before dereferencing the `arm` pointer. This would\ncause a crash if the current target was (say) a mem_ap.\n\nAdd \u0027target_to_dap\u0027 function to safely get the dap\n\nChange-Id: I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c\nSigned-off-by: Grant Ramsay \u003cgrant.ramsay@hotmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8415\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"62f6054dfb0b289d42f336b7ee02875bab9a1588":{"kind":"REWORK","_number":4,"created":"2024-07-26 02:23:51.000000000","uploader":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"ref":"refs/changes/15/8415/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8415/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/4 \u0026\u0026 git checkout -b change-8415 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8415/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6554d176e926e1e46b90e1b00d1b3ed1bd20b9ff","subject":"flash/stm32l4x: support STM32U59/U5Ax devices"}],"author":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-25 08:47:35.000000000","tz":720},"committer":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-26 02:23:32.000000000","tz":720},"subject":"target: arm_dap: Fix crash in \u0027dap info\u0027 command","message":"target: arm_dap: Fix crash in \u0027dap info\u0027 command\n\nThe \u0027dap info\u0027 command was not checking that the target was\nan ARM before dereferencing the `arm` pointer. This would\ncause a crash if the current target was (say) a mem_ap.\n\nAdd a mem_ap.h header to expose the mem_ap struct and the\n\"common magic\" for determining if a target arch structure\nis a mem_ap. Add basic helper functions.\n\nAdd a `target_to_dap` function that safely returns the DAP\nfrom either ARM or mem_ap targets to fix the crash\n\nChange-Id: I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c\nSigned-off-by: Grant Ramsay \u003cgrant.ramsay@hotmail.com\u003e\n"}},"9819c6ae646e63fc3818c34247b9654b3b7de415":{"kind":"REWORK","_number":5,"created":"2024-07-26 08:43:18.000000000","uploader":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"ref":"refs/changes/15/8415/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8415/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/5 \u0026\u0026 git checkout -b change-8415 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8415/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6554d176e926e1e46b90e1b00d1b3ed1bd20b9ff","subject":"flash/stm32l4x: support STM32U59/U5Ax devices"}],"author":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-26 08:39:20.000000000","tz":720},"committer":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-26 08:43:06.000000000","tz":720},"subject":"target: arm_dap: Fix crash in \u0027dap info\u0027 command","message":"target: arm_dap: Fix crash in \u0027dap info\u0027 command\n\nThe \u0027dap info\u0027 command was not checking that the target was\nan ARM before dereferencing the `arm` pointer. This would\ncause a crash if the current target was (say) a mem_ap.\n\nAdd \u0027target_to_dap\u0027 function to safely get the dap\n\nChange-Id: I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c\nSigned-off-by: Grant Ramsay \u003cgrant.ramsay@hotmail.com\u003e\n"}},"1c9aab33c331f262d05dfee2cd3fb947b6965b97":{"kind":"REWORK","_number":2,"created":"2024-07-25 08:49:23.000000000","uploader":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"ref":"refs/changes/15/8415/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8415/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/2 \u0026\u0026 git checkout -b change-8415 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8415/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6554d176e926e1e46b90e1b00d1b3ed1bd20b9ff","subject":"flash/stm32l4x: support STM32U59/U5Ax devices"}],"author":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-25 08:47:35.000000000","tz":720},"committer":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-25 08:47:35.000000000","tz":720},"subject":"target: arm_dap: Fix crash in \u0027dap info\u0027 command","message":"target: arm_dap: Fix crash in \u0027dap info\u0027 command\n\nThe \u0027dap info\u0027 command was not checking that the target was\nan ARM before dereferencing the `arm` pointer. This would\ncause a crash if the current target was (say) a mem_ap.\n\nAdd a mem_ap.h header to expose the mem_ap struct and the\n\"common magic\" for determining if a target arch structure\nis a mem_ap. Add basic helper functions.\n\nAdd a `target_to_dap` function that safely returns the DAP\nfrom either ARM or mem_ap targets to fix the crash\n\nChange-Id: I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c\nSigned-off-by: Grant Ramsay \u003cgrant.ramsay@hotmail.com\u003e\n"}},"8f72fc4b050ec421d37120829f844fdfa95495ac":{"kind":"REWORK","_number":3,"created":"2024-07-25 08:55:59.000000000","uploader":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"ref":"refs/changes/15/8415/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8415/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/3 \u0026\u0026 git checkout -b change-8415 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8415/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6554d176e926e1e46b90e1b00d1b3ed1bd20b9ff","subject":"flash/stm32l4x: support STM32U59/U5Ax devices"}],"author":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-25 08:47:35.000000000","tz":720},"committer":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-25 08:55:44.000000000","tz":720},"subject":"target: arm_dap: Fix crash in \u0027dap info\u0027 command","message":"target: arm_dap: Fix crash in \u0027dap info\u0027 command\n\nThe \u0027dap info\u0027 command was not checking that the target was\nan ARM before dereferencing the `arm` pointer. This would\ncause a crash if the current target was (say) a mem_ap.\n\nAdd a mem_ap.h header to expose the mem_ap struct and the\n\"common magic\" for determining if a target arch structure\nis a mem_ap. Add basic helper functions.\n\nAdd a `target_to_dap` function that safely returns the DAP\nfrom either ARM or mem_ap targets to fix the crash\n\nChange-Id: I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c\nSigned-off-by: Grant Ramsay \u003cgrant.ramsay@hotmail.com\u003e\n"}},"dfac674f2930c8bc925cdbfb9fd60680f2b9afe7":{"kind":"REWORK","_number":1,"created":"2024-07-23 22:59:12.000000000","uploader":{"_account_id":1002286,"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","username":"gramsay0"},"ref":"refs/changes/15/8415/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8415/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/1 \u0026\u0026 git checkout -b change-8415 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8415/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8415/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6554d176e926e1e46b90e1b00d1b3ed1bd20b9ff","subject":"flash/stm32l4x: support STM32U59/U5Ax devices"}],"author":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-23 22:57:03.000000000","tz":720},"committer":{"name":"Grant Ramsay","email":"grant.ramsay@hotmail.com","date":"2024-07-23 22:57:03.000000000","tz":720},"subject":"target: arm_dap: Fix crash in \u0027dap info\u0027 command","message":"target: arm_dap: Fix crash in \u0027dap info\u0027 command\n\nCheck target is ARM before dereference. Running \u0027dap info\u0027\nwhen the current target is a mem_ap would cause a crash\n\nChange-Id: I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c\nSigned-off-by: Grant Ramsay \u003cgrant.ramsay@hotmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
