)]}'
{"id":"openocd~master~I1d3164ba1f725c0763dfe362192ffa669b3856e6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-08-25 12:36:54.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I1d3164ba1f725c0763dfe362192ffa669b3856e6","subject":"checkpatch: only report error on hit","status":"MERGED","created":"2024-08-01 09:23:34.000000000","updated":"2024-08-25 12:36:57.000000000","submitted":"2024-08-25 12:36:57.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8424","meta_rev_id":"49c366457613e3fbebfe766f96e3174826ef6e4a","_number":8424,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-25 12:36:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-25 12:36:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-25 12:36:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-01 09:38:26.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-01 20:41:16.000000000","updated_by":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"}],"messages":[{"id":"f61edcd583ea93a7defd54e90ed4810b67eb9f68","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-01 09:23:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bc1eb9ffc32197e71b95b5f57c60407ad82dd234","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-01 09:38:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19846/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19001/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"489cce1cd09ac08d416fda18d033a933ab377fa9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-01 12:49:49.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9bca4dffe55be37fe266adbb51936dae8a035551","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-01 12:51:48.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ceb1958be001e9ebe23eebc361eba7a6b500d97b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-01 13:02:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19847/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19002/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"48eb433daa00105b633aba64f2bbd6dc6d81f8db","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2024-08-01 20:41:16.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"da902ae180d993091006284254fcf5bff5dda4d2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 12:36:54.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"49c366457613e3fbebfe766f96e3174826ef6e4a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 12:36:57.000000000","message":"Change has been successfully cherry-picked as ceae51ad74ba3a16be3e7ee2df4743a6df3cd097","accounts_in_message":[],"_revision_number":3}],"current_revision":"ceae51ad74ba3a16be3e7ee2df4743a6df3cd097","revisions":{"893789c95f7c1ebbc1f2b44f4564d8a41d68247f":{"kind":"REWORK","_number":1,"created":"2024-08-01 09:23:34.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/8424/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8424/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/1 \u0026\u0026 git checkout -b change-8424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8424/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"16c114c05891509054079e8d5d82905f1690a7a8","subject":"flash/startup.tcl: Tidy flash program preverify documentation"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-01 08:43:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-01 09:22:52.000000000","tz":120},"subject":"checkpatch: only report error on hit","message":"checkpatch: only report error on hit\n\nThe Linux checkpatch script used by OpenOCD reports hits either as\nerror, warning and check.\nSuch classification is meaningful for Linux maintainers, but for\nOpenOCD Jenkins they are all considered as errors.\n\nHaving such classification in the checkpatch report by Jenkins is\nmisleading for developers that expect \u0027warnings\u0027 to be probably\nignored by maintainers, while having no idea what \u0027checks\u0027 means.\n\nThis patch flattens all the checkpatch reports to \u0027error\u0027 only.\n\nCheckpatch can trigger false positives. OpenOCD uses the tag\n\tCheckpatch-ignore:\nin the commit message to prevent Jenkins to report the error, as\ndescribed in HACKING.\n\nChange-Id: I1d3164ba1f725c0763dfe362192ffa669b3856e6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f23111d11e050c1e64c5e08b92332f03c38c180e":{"kind":"REWORK","_number":2,"created":"2024-08-01 12:49:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/8424/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8424/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/2 \u0026\u0026 git checkout -b change-8424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8424/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"16c114c05891509054079e8d5d82905f1690a7a8","subject":"flash/startup.tcl: Tidy flash program preverify documentation"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-01 08:43:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-01 12:49:08.000000000","tz":120},"subject":"checkpatch: only report error on hit","message":"checkpatch: only report error on hit\n\nThe Linux checkpatch script used by OpenOCD reports hits either as\nerror, warning and check.\nSuch classification is meaningful for Linux maintainers, but for\nOpenOCD Jenkins they are all considered as errors.\n\nHaving such classification in the checkpatch report by Jenkins is\nmisleading for developers that expect \u0027warnings\u0027 to be probably\nignored by maintainers, while having no idea what \u0027checks\u0027 means.\n\nThis patch flattens all the checkpatch reports to \u0027error\u0027 only.\n\nCheckpatch can trigger false positives. OpenOCD uses the tag\n\tCheckpatch-ignore:\nin the commit message to prevent Jenkins to report the error, as\ndescribed in HACKING.\n\nChange-Id: I1d3164ba1f725c0763dfe362192ffa669b3856e6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"ceae51ad74ba3a16be3e7ee2df4743a6df3cd097":{"kind":"REWORK","_number":3,"created":"2024-08-25 12:36:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/8424/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8424/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/3 \u0026\u0026 git checkout -b change-8424 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8424/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8424/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bfd3110e59f5b13c075823c654f1a51cfcd66d4d","subject":"binarybuffer: str_to_buf(): simplify it and fix scan-build error"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-01 08:43:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-25 12:36:57.000000000","tz":0},"subject":"checkpatch: only report error on hit","message":"checkpatch: only report error on hit\n\nThe Linux checkpatch script used by OpenOCD reports hits either as\nerror, warning and check.\nSuch classification is meaningful for Linux maintainers, but for\nOpenOCD Jenkins they are all considered as errors.\n\nHaving such classification in the checkpatch report by Jenkins is\nmisleading for developers that expect \u0027warnings\u0027 to be probably\nignored by maintainers, while having no idea what \u0027checks\u0027 means.\n\nThis patch flattens all the checkpatch reports to \u0027error\u0027 only.\n\nCheckpatch can trigger false positives. OpenOCD uses the tag\n\tCheckpatch-ignore:\nin the commit message to prevent Jenkins to report the error, as\ndescribed in HACKING.\n\nChange-Id: I1d3164ba1f725c0763dfe362192ffa669b3856e6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8424\nReviewed-by: Karl Palsson \u003ckarlp@tweak.au\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}