)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ba4d7fb947e8fc5370913438c40beaeff075356a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The motivation is twofold:"},{"line_number":10,"context_line":"1. It seems reasonable to assume that `target_type-\u003etarget_create` is"},{"line_number":11,"context_line":"   the first `target_type`-specific function being called."},{"line_number":12,"context_line":"   However, `conigure` calls `target_type-\u003etarget_jim_configure` which"},{"line_number":13,"context_line":"   used to make this assumption erroneous."},{"line_number":14,"context_line":"2. The result of `target_type-\u003etarget_create` should not depend on"},{"line_number":15,"context_line":"   options configurable via `configure`, since `configure` can be called"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"40845262_87c8f08b","line":12,"updated":"2024-09-01 14:40:48.000000000","message":"s/conigure/configure/","commit_id":"b9e724337ec7c1764fbe67b3792c124a54489038"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ba4d7fb947e8fc5370913438c40beaeff075356a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6861aba0_e4171470","updated":"2024-09-01 14:40:48.000000000","message":"Evgeniy, can you be more detailed on the use case you find broken? Which target-type?\n\nWe use `target_type-\u003etarget_jim_configure` to parse the parameters of command `target create`. I assume some parameter\u0027s value could be useful during `target_type-\u003etarget_create` (but I have not checked all targets to confirm it).\n\nWe use the struct `target-\u003eprivate_config` to hold values from configure that will be used  during `target_type-\u003etarget_create`.\nSwapping the order of the calls breaks this.","commit_id":"b9e724337ec7c1764fbe67b3792c124a54489038"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"95c58b67de057667c9b735d5bdf1c45185aba1af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f837b57b_ec5a4163","in_reply_to":"6861aba0_e4171470","updated":"2024-09-04 16:09:32.000000000","message":"Thanks for the explanation. I\u0027ve missed the use of `target-\u003eprivate_config`. I\u0027ll abandon the patch.\n\n\u003e Evgeniy, can you be more detailed on the use case you find broken? Which target-type?\n\nNothing is broken, I\u0027ve encountered the issue while trying to extend RISC-V target type.\n\nThe problem is, `examine` is quite intrusive on RISC-V platforms due to configurability of the architecture.\n\nThe idea was to provide user interface to optionally configure known architecture parameters (e.g. if it is known that the target\u0027s DXLEN is 64-bit -- it can be specified and DXLEN examination can be skipped).\n\nI\u0027ve tried to implement this using `target_type-\u003etarget_jim_configure`, but I\u0027ve stored the configured parameters in the same place examined once would go -- in the `target-\u003earch_info`.\n\nThis is when I got a segfault, since `target-\u003earch_info` is allocated during `target_type-\u003etarget_create`.\n\nIt seemed counter intuitive to me that `target-\u003econfigure` is called before \n\nTLDR: `target-\u003eprivate_config` will be fine for the use-case in RISC-V targets.","commit_id":"b9e724337ec7c1764fbe67b3792c124a54489038"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"29e725b606e884db3eac74eb409676ae95d185e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c00fcea3_b59fe4ae","in_reply_to":"f837b57b_ec5a4163","updated":"2024-09-04 16:38:33.000000000","message":"I don\u0027t really like the use of `target-\u003eprivate_config` that is later copied in `target-\u003earch_info`. The idea of swapping and having `target_create` before `configure` could be the way to make `target-\u003eprivate_config` disappear by letting configure writing directly in `target-\u003earch_info`, as you were trying to do.\nBut before doing this, I\u0027m willing to drop the JimTCL code from both `target_create` and `configure`, rewriting them. I\u0027m already working on it.\nSo, please use `target-\u003eprivate_config` for the time being; it will be changed later, hopefully.","commit_id":"b9e724337ec7c1764fbe67b3792c124a54489038"}]}