)]}'
{"id":"openocd~master~I88ae8ed631a6812e2a27562e644cc101fa168b16","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-09-04 16:11:43.000000000","reason":"Change was abandoned"},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2024-09-04 16:09:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1002047\u003e replied on the change","reason_account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}}},"hashtags":[],"change_id":"I88ae8ed631a6812e2a27562e644cc101fa168b16","subject":"target/target: call `target_type-\u003etarget_create` before `configure`","status":"ABANDONED","created":"2024-08-14 17:04:12.000000000","updated":"2024-09-04 16:38:33.000000000","total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"29e725b606e884db3eac74eb409676ae95d185e4","_number":8434,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2024-08-14 20:17:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":-1,"date":"2024-09-01 14:40:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-14 17:05:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-01 14:40:48.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"a0fa54a8e415efa4fba1dea9504292db95393df0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-08-14 17:04:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e4a725f97cdb8fb1ac1dee4f542467a28ad8719c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-14 17:05:39.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19875/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19030/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"2f011667a4e55723ffb569c1dc273d75dea01f4a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-08-14 20:03:15.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f117b70340fee514cf7c44ad59db23c4cf68ef20","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-14 20:17:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19876/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19031/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ba4d7fb947e8fc5370913438c40beaeff075356a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-01 14:40:48.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"95c58b67de057667c9b735d5bdf1c45185aba1af","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-04 16:09:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"80ef8e7dd97f1aab48f6894e13cb834adc610035","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-04 16:11:43.000000000","message":"Abandoned\n\n`target-\u003eprivate_config`, not `target-\u003earch_type` should be used to store `target_type`-specific `configure` parameters.","accounts_in_message":[],"_revision_number":2},{"id":"29e725b606e884db3eac74eb409676ae95d185e4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-04 16:38:33.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"b9e724337ec7c1764fbe67b3792c124a54489038","revisions":{"b9e724337ec7c1764fbe67b3792c124a54489038":{"kind":"REWORK","_number":2,"created":"2024-08-14 20:03:15.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/34/8434/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/8434/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/2 \u0026\u0026 git checkout -b change-8434 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/8434/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"efe90221979458960618a5a5c8f90b116e91f011","subject":"server/telnet: Always allow \u0027exit\u0027 command"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-08-02 13:49:42.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-08-14 20:02:59.000000000","tz":180},"subject":"target/target: call `target_type-\u003etarget_create` before `configure`","message":"target/target: call `target_type-\u003etarget_create` before `configure`\n\nThe motivation is twofold:\n1. It seems reasonable to assume that `target_type-\u003etarget_create` is\n   the first `target_type`-specific function being called.\n   However, `conigure` calls `target_type-\u003etarget_jim_configure` which\n   used to make this assumption erroneous.\n2. The result of `target_type-\u003etarget_create` should not depend on\n   options configurable via `configure`, since `configure` can be called\n   after `target create` in any order a user may see fit.\n\nChange-Id: I88ae8ed631a6812e2a27562e644cc101fa168b16\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"cc4f43864c59eb318aeada48d4ab4247ec40e150":{"kind":"REWORK","_number":1,"created":"2024-08-14 17:04:12.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/34/8434/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/8434/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/1 \u0026\u0026 git checkout -b change-8434 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/8434/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/8434/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"efe90221979458960618a5a5c8f90b116e91f011","subject":"server/telnet: Always allow \u0027exit\u0027 command"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-08-02 13:49:42.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-08-14 17:03:54.000000000","tz":180},"subject":"target/target: call `target_type-\u003etarget_create` before `configure`","message":"target/target: call `target_type-\u003etarget_create` before `configure`\n\nThe motivation is twofold:\n1. It seems reasonable to assume that `target_type-\u003etarget_create` is\n   the first `target_type`-specific function being called.\n   However, `conigure` calls `target_type-\u003etarget_jim_configure` which\n   used to make this assumption erroneous.\n2. The result of `target_type-\u003etarget_create` should not depend on\n   options configurable via `configure`, since `configure` can be called\n   after `target create` in any order a user may see fit.\n\nChange-Id: I88ae8ed631a6812e2a27562e644cc101fa168b16\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}