)]}'
{"id":"openocd~master~Ibb18775aeed192361ae1585bfdaad03760583cf3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002337":{"account":{"_account_id":1002337,"name":"Luke Wren","username":"Wren6991"},"last_update":"2025-04-25 09:27:20.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-02-17 17:58:57.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ibb18775aeed192361ae1585bfdaad03760583cf3","subject":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks","status":"MERGED","created":"2024-08-15 05:29:05.000000000","updated":"2025-04-25 09:27:20.000000000","submitted":"2025-04-25 09:27:20.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8444","meta_rev_id":"ab9cedd49b622d0f46bbb6ab71e35f0e72d03eb5","_number":8444,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-25 09:27:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-25 09:27:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-04-25 09:27:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-15 06:52:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-17 10:14:41.000000000","updated_by":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"}],"messages":[{"id":"43e8a706fc01de204999a83f9c79494ddc151f3e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-15 05:29:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2c6440219bf926a0172e3b7377b72b01ea653eab","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-15 06:52:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19888/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19042/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"1be5bfa62e16d5fc6bdf37cc1757a6955c0f8ffc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-16 07:46:36.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"42085fe6172274854da855125616f9708ed0f19b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-16 08:03:54.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19912/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19067/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"67b28fdf454a6597c673fc649b7649763e62be27","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002337,"name":"Luke Wren","username":"Wren6991"},"real_author":{"_account_id":1002337,"name":"Luke Wren","username":"Wren6991"},"date":"2024-11-07 09:28:08.000000000","message":"Patch Set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"962b16353140d00e5cb7a61999a4b71ca14abf1e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-11-07 09:56:50.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20156/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19312/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b7f23a8e9f735fcf524c60faa63e93ec36020aed","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-29 09:55:16.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"6f9887c9dc53c5553198a5f24dac579fc966cd19","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2025-02-17 10:14:41.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"da0d8cc0a219b01db83e1a1fdb1d31d6c6767651","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-02-17 17:58:57.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ab9cedd49b622d0f46bbb6ab71e35f0e72d03eb5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-04-25 09:27:20.000000000","message":"Change has been successfully cherry-picked as ca966d3d7f28875e4872e691c3fdce27867ddab0","accounts_in_message":[],"_revision_number":4}],"current_revision":"ca966d3d7f28875e4872e691c3fdce27867ddab0","revisions":{"1b750edbaef53ffcb4467068efc88285f3476618":{"kind":"REWORK","_number":1,"created":"2024-08-15 05:29:05.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8444/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8444/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/1 \u0026\u0026 git checkout -b change-8444 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8444/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3fcfddb93aaa27c45ab6760b758d21d0876f3038","subject":"flash/nor/rp2040: Fix up ROM table lookup for RP2350 A2"}],"author":{"name":"Luke Wren","email":"luke@raspberrypi.com","date":"2024-07-25 09:55:41.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-15 05:27:34.000000000","tz":120},"subject":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks","message":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks\n\nAlso add keep_alive() to erase/program to avoid nasty GDB message.\n\nTV: Fixed style problems.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ibb18775aeed192361ae1585bfdaad03760583cf3\n"}},"f1cd577c4410c748849f8f7226257d59947b1ee0":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-11-07 09:28:08.000000000","uploader":{"_account_id":1002337,"name":"Luke Wren","username":"Wren6991"},"ref":"refs/changes/44/8444/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8444/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/3 \u0026\u0026 git checkout -b change-8444 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8444/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"658d423fc857b03f7619eb36d2fe3bdc78e012b9","subject":"flash/nor/rp2040: Fix up ROM table lookup for RP2350 A2"}],"author":{"name":"Luke Wren","email":"luke@raspberrypi.com","date":"2024-07-25 09:55:41.000000000","tz":60},"committer":{"name":"Luke Wren","email":"Wren6991@review.openocd.org","date":"2024-11-07 09:28:08.000000000","tz":0},"subject":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks","message":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks\n\nAlso add keep_alive() to erase/program to avoid nasty GDB message.\n\nTV: Fixed style problems.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nSigned-off-by: Luke Wren \u003cluke@raspberrypi.com\u003e\nChange-Id: Ibb18775aeed192361ae1585bfdaad03760583cf3\n"},"description":"Edit commit message"},"99acfa1c4b24d411e407b6afb242ed1642f6b79e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-08-16 07:46:36.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8444/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8444/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/2 \u0026\u0026 git checkout -b change-8444 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8444/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"658d423fc857b03f7619eb36d2fe3bdc78e012b9","subject":"flash/nor/rp2040: Fix up ROM table lookup for RP2350 A2"}],"author":{"name":"Luke Wren","email":"luke@raspberrypi.com","date":"2024-07-25 09:55:41.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 05:50:38.000000000","tz":120},"subject":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks","message":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks\n\nAlso add keep_alive() to erase/program to avoid nasty GDB message.\n\nTV: Fixed style problems.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ibb18775aeed192361ae1585bfdaad03760583cf3\n"}},"ca966d3d7f28875e4872e691c3fdce27867ddab0":{"kind":"REWORK","_number":4,"created":"2025-04-25 09:27:20.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/44/8444/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/44/8444/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/4 \u0026\u0026 git checkout -b change-8444 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/44/8444/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/44/8444/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2e8e1a3da386685a2a572bcc85f043505a7b3d94","subject":"flash/nor/rp2040: Fix up ROM table lookup for RP2350 A2"}],"author":{"name":"Luke Wren","email":"luke@raspberrypi.com","date":"2024-07-25 09:55:41.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-04-25 09:27:20.000000000","tz":0},"subject":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks","message":"flash/nor/rp2040: Avoid ROM call timeout on long erases by splitting into chunks\n\nAlso add keep_alive() to erase/program to avoid nasty GDB message.\n\nTV: Fixed style problems.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nSigned-off-by: Luke Wren \u003cluke@raspberrypi.com\u003e\nChange-Id: Ibb18775aeed192361ae1585bfdaad03760583cf3\nReviewed-on: https://review.openocd.org/c/openocd/+/8444\nTested-by: jenkins\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
