)]}'
{"id":"openocd~master~I151e684e1fbfc9476ec429036caf85f4c9329547","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-04-25 09:43:44.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I151e684e1fbfc9476ec429036caf85f4c9329547","subject":"flash/nor/rp2xxx: minor code improvements","status":"MERGED","created":"2024-08-15 05:29:05.000000000","updated":"2025-04-25 09:44:00.000000000","submitted":"2025-04-25 09:44:00.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8457","meta_rev_id":"eaa617562d61e61c4addef59bdd3d7fe14b20d9b","_number":8457,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-25 09:44:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-25 09:44:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-04-25 09:44:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-15 07:24:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-17 10:28:27.000000000","updated_by":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"}],"messages":[{"id":"537bbc04f1b26a3201db56d4505eb42b9ac1c37b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-15 05:29:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e2c39c5caf1701a760aa22980a3ad5980d829f91","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-15 07:24:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19901/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19056/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"b227294014d04d0b9918cd38cd6df8e5a5b210bb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-16 21:59:27.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e56be98ff7711004d2bf9fff31131a6093466198","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-16 22:56:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19933/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19088/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e027aa8c8fcd9ca452cf17ffb31ce9a2301c22ea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-17 15:36:49.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"f9ace698628e58c4a51af376ce1c83b0c2d41287","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-17 16:59:50.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19943/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19096/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"78c212d3d1556e0ea4522c47589745a1bcba12da","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-29 18:10:05.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"9f1d9e2ca5ab4a2f3df422a7a584e12837ca03da","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-29 20:43:22.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20680/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19829/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"f71ec8b27c5eba29860b2fcbdfbb9d7b9c09adf4","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2025-02-17 10:28:27.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"f4180544303d43823a863e7fc1fb583ca701c251","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-04-25 09:43:44.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"eaa617562d61e61c4addef59bdd3d7fe14b20d9b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-04-25 09:44:00.000000000","message":"Change has been successfully cherry-picked as d29c1c6d6df31f64ae5593babc65cfdffa312def","accounts_in_message":[],"_revision_number":5}],"current_revision":"d29c1c6d6df31f64ae5593babc65cfdffa312def","revisions":{"a7dd7d24af5952ee6db774d8ea390be167bbb3cf":{"kind":"REWORK","_number":1,"created":"2024-08-15 05:29:05.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/57/8457/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8457/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/1 \u0026\u0026 git checkout -b change-8457 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8457/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b28ae610ae6554459820d53b3668c5957505dce0","subject":"doc: document changes in rp2xxx flash driver"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-14 15:43:13.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-15 05:28:37.000000000","tz":120},"subject":"flash/nor/rp2xxx: minor code improvements","message":"flash/nor/rp2xxx: minor code improvements\n\nAdd error messages and proper error propagation.\nType cleaning.\nUse saved chip id.\nCosmetics: separating lines added.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I151e684e1fbfc9476ec429036caf85f4c9329547\n"}},"86dfe8c5973d06914acc45745661a137bfbdd4f4":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-08-16 21:59:27.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/57/8457/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8457/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/2 \u0026\u0026 git checkout -b change-8457 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8457/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aec258dc1b698e3d7b66ba81efaa47fb63f1b6d2","subject":"doc: document changes in rp2xxx flash driver"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-14 15:43:13.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 20:29:38.000000000","tz":120},"subject":"flash/nor/rp2xxx: minor code improvements","message":"flash/nor/rp2xxx: minor code improvements\n\nAdd error messages and proper error propagation.\nType cleaning.\nUse saved chip id.\nCosmetics: separating lines added.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I151e684e1fbfc9476ec429036caf85f4c9329547\n"}},"32ad04a7663c0e25ea115aa8e4364c11d345c7a3":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-08-17 15:36:49.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/57/8457/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8457/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/3 \u0026\u0026 git checkout -b change-8457 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8457/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8e42e5f019b9279b5d5dafb16276b9a2b0ca3d5a","subject":"doc: document changes in rp2xxx flash driver"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-14 15:43:13.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-17 14:47:30.000000000","tz":120},"subject":"flash/nor/rp2xxx: minor code improvements","message":"flash/nor/rp2xxx: minor code improvements\n\nAdd error messages and proper error propagation.\nType cleaning.\nUse saved chip id.\nCosmetics: separating lines added.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I151e684e1fbfc9476ec429036caf85f4c9329547\n"}},"74a2634fa579df591d253a0dc3e3edee8a40646b":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-01-29 18:10:05.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/57/8457/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8457/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/4 \u0026\u0026 git checkout -b change-8457 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8457/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae6b7b0d1d3f08918ed885723fd395bd57da3e73","subject":"doc: document changes in rp2xxx flash driver"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-14 15:43:13.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-29 18:08:32.000000000","tz":60},"subject":"flash/nor/rp2xxx: minor code improvements","message":"flash/nor/rp2xxx: minor code improvements\n\nAdd error messages and proper error propagation.\nType cleaning.\nUse saved chip id.\nCosmetics: separating lines added.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I151e684e1fbfc9476ec429036caf85f4c9329547\n"}},"d29c1c6d6df31f64ae5593babc65cfdffa312def":{"kind":"REWORK","_number":5,"created":"2025-04-25 09:44:00.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/57/8457/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8457/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/5 \u0026\u0026 git checkout -b change-8457 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8457/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8457/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9fce121366c86e77e84b9d20c7d1c7dbb38710d5","subject":"doc: document changes in rp2xxx flash driver"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-14 15:43:13.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-04-25 09:44:00.000000000","tz":0},"subject":"flash/nor/rp2xxx: minor code improvements","message":"flash/nor/rp2xxx: minor code improvements\n\nAdd error messages and proper error propagation.\nType cleaning.\nUse saved chip id.\nCosmetics: separating lines added.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I151e684e1fbfc9476ec429036caf85f4c9329547\nReviewed-on: https://review.openocd.org/c/openocd/+/8457\nTested-by: jenkins\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}