)]}'
{"id":"openocd~master~I23a7549251ba21987212708ef35cdad4c5d5661a","project":"openocd","branch":"master","attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-08-17 07:04:06.000000000","reason":"\u003cGERRIT_ACCOUNT_1002161\u003e replied on the change","reason_account":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"}}},"removed_from_attention_set":{"1002161":{"account":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"last_update":"2024-08-17 07:04:06.000000000","reason":"\u003cGERRIT_ACCOUNT_1002161\u003e replied on the change","reason_account":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"}}},"hashtags":[],"change_id":"I23a7549251ba21987212708ef35cdad4c5d5661a","subject":"target/target: fix confusing error messages during verify_image","status":"NEW","created":"2024-08-16 15:37:45.000000000","updated":"2024-08-17 07:04:06.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":12,"unresolved_comment_count":6,"has_review_started":true,"meta_rev_id":"3f1db5d7ee98e808e25d6b95d5a4737e6ad3ce39","_number":8458,"owner":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2024-08-16 16:08:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":-1,"date":"2024-08-17 05:11:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-16 15:38:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-17 05:11:59.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"559563fa4320a1d3e8f68acffe47d28b9693c8a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2024-08-16 15:37:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f94959b9d410bf13da1f3814c2ff6a96e6cf43f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-16 15:38:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19927/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19082/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"517bb30ff33b5cde3ca7570e0c448d1448f81341","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2024-08-16 15:54:09.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9665ae8fc0d76d4f29e29fe9363ff417acd03ae7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-16 16:08:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19928/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19083/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"24cabb92fbf3ed96b5a8819b2e74f966717db9f7","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-17 05:11:59.000000000","message":"Patch Set 2: Code-Review-1\n\n(6 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3f1db5d7ee98e808e25d6b95d5a4737e6ad3ce39","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2024-08-17 07:04:06.000000000","message":"Patch Set 2:\n\n(6 comments)","accounts_in_message":[],"_revision_number":2}],"current_revision":"e642b4c703247e7a446610dca075d0bb76975245","revisions":{"c381adab4d4158e5b950ce39646c108a3a1ab84d":{"kind":"REWORK","_number":1,"created":"2024-08-16 15:37:45.000000000","uploader":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"ref":"refs/changes/58/8458/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/8458/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/1 \u0026\u0026 git checkout -b change-8458 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/8458/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ac63cd00d792331914db0b6edd3f427c30eec3fa","subject":"tcl/interface/raspberrypi5-gpiod: fix string match pattern escaping"}],"author":{"name":"Parshintsev Anatoly","email":"anatoly.parshintsev@syntacore.com","date":"2024-08-15 09:14:49.000000000","tz":180},"committer":{"name":"Parshintsev Anatoly","email":"anatoly.parshintsev@syntacore.com","date":"2024-08-16 15:37:40.000000000","tz":180},"subject":"target/target: fix confusing error messages during verify_image","message":"target/target: fix confusing error messages during verify_image\n\nWhen calculating target memory checksum OpenOCD tries to use\ntarget-specific routine for crc calculation on the target. If this\napproach fails it uses target-independent fallback.\n\nThis commit fixes two issues:\n\n1. It allows to use target-independent fallback even if the target does\n   not provide target-specific routine (I assume this is a bug).\n2. If target-specific routine fails, we print a warning indicating that\n  fallback is used. Otherwise we had quite a confusing messages:\n\n```\nverify_image 512k 0x80000000\nNo working memory available. Specify -work-area-phys to target.\nnot enough working area available(requested 1112)\nverified 524288 bytes in 5.484234s (93.359 KiB/s)\n```\n\nAfter the patch these become:\n\n```\nverify_image 512k 0x80000000\n[riscv.cpu0] No working memory available. Specify -work-area-phys to target.\n[riscv.cpu0] not enough working area available(requested 1112)\n[riscv.cpu0] target-specific checksum_memory routine failed, attempting generic routine as a fallback\nverified 524288 bytes in 6.473983s (79.086 KiB/s)\n```\n\nChange-Id: I23a7549251ba21987212708ef35cdad4c5d5661a\nSigned-off-by: Parshintsev Anatoly \u003canatoly.parshintsev@syntacore.com\u003e\n"}},"e642b4c703247e7a446610dca075d0bb76975245":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-08-16 15:54:09.000000000","uploader":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"ref":"refs/changes/58/8458/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/8458/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/2 \u0026\u0026 git checkout -b change-8458 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/8458/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/8458/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ac63cd00d792331914db0b6edd3f427c30eec3fa","subject":"tcl/interface/raspberrypi5-gpiod: fix string match pattern escaping"}],"author":{"name":"Parshintsev Anatoly","email":"anatoly.parshintsev@syntacore.com","date":"2024-08-15 09:14:49.000000000","tz":180},"committer":{"name":"Parshintsev Anatoly","email":"anatoly.parshintsev@syntacore.com","date":"2024-08-16 15:51:39.000000000","tz":180},"subject":"target/target: fix confusing error messages during verify_image","message":"target/target: fix confusing error messages during verify_image\n\nWhen calculating target memory checksum OpenOCD tries to use\ntarget-specific routine for crc calculation on the target. If this\napproach fails it uses target-independent fallback.\n\nThis commit fixes two issues:\n\n1. It allows to use target-independent fallback even if the target does\n   not provide target-specific routine (I assume this is a bug).\n2. If target-specific routine fails, we print a warning indicating that\n  fallback is used. Otherwise we had quite a confusing messages:\n\n```\nverify_image 512k 0x80000000\nNo working memory available. Specify -work-area-phys to target.\nnot enough working area available(requested 1112)\nverified 524288 bytes in 5.484234s (93.359 KiB/s)\n```\n\nAfter the patch these become:\n\n```\nverify_image 512k 0x80000000\n[riscv.cpu0] No working memory available. Specify -work-area-phys ...\n[riscv.cpu0] not enough working area available(requested 1112)\n[riscv.cpu0] target-specific checksum_memory routine failed, atte ...\nverified 524288 bytes in 6.473983s (79.086 KiB/s)\n```\n\nNote: messages are truncated to pass checkpatch.\n\nChange-Id: I23a7549251ba21987212708ef35cdad4c5d5661a\nSigned-off-by: Parshintsev Anatoly \u003canatoly.parshintsev@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}