)]}'
{"id":"openocd~master~Ib515f96a3c77afea87274f33b8ccac7a71bfb932","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-04-25 09:44:20.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ib515f96a3c77afea87274f33b8ccac7a71bfb932","subject":"flash/nor/rp2xxx: drop couple of Java-like const","status":"MERGED","created":"2024-08-16 21:59:27.000000000","updated":"2025-04-25 09:44:28.000000000","submitted":"2025-04-25 09:44:28.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8459","meta_rev_id":"ef510dd1484d2ad8e2b469f480355c83937da564","_number":8459,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-25 09:44:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-25 09:44:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-04-25 09:44:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-16 23:19:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-17 10:27:08.000000000","updated_by":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"}],"messages":[{"id":"8ca11e1b19ce2561120b8e2223cc5d938d6a2cbd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-16 21:59:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ab451f9b2902222a790589a375a9046909aec3a5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-16 23:19:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19935/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19090/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"34e989dd0377a00948a155a4a21af0382879b946","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-17 15:36:49.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9091390fcfd21d6eaefdc58101d6861d2ef415ed","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-17 17:25:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19942/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19098/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0e3868a5c6fa164418e8b06d72fecbbca6bcde3d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-29 18:10:05.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"e1d37ab563e984c7d487a01745f75b789a779eca","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-29 20:54:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20681/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19830/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"0b60071f42b2a2caa4ab775e0bae166200159205","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2025-02-17 10:27:08.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"ec015159f4277dca9801a31cd73a601b1ea3527c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-04-25 09:44:20.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ef510dd1484d2ad8e2b469f480355c83937da564","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-04-25 09:44:28.000000000","message":"Change has been successfully cherry-picked as a9608871692be6cda4d73ae837b4313747370ff8","accounts_in_message":[],"_revision_number":4}],"current_revision":"a9608871692be6cda4d73ae837b4313747370ff8","revisions":{"dd517f233274b3b98b534e83f0cf688991fc981d":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-01-29 18:10:05.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/59/8459/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/8459/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/3 \u0026\u0026 git checkout -b change-8459 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/8459/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"74a2634fa579df591d253a0dc3e3edee8a40646b","subject":"flash/nor/rp2xxx: minor code improvements"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 20:53:36.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-29 18:08:32.000000000","tz":60},"subject":"flash/nor/rp2xxx: drop couple of Java-like const","message":"flash/nor/rp2xxx: drop couple of Java-like const\n\nThe compiler knows what variable remains constant during its lifetime\nand there is no need to emphasise constantness.\n\nChange-Id: Ib515f96a3c77afea87274f33b8ccac7a71bfb932\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"aff48c2d80d55c02cb0eea1f0b29e450b4fd0a66":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-08-17 15:36:49.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/59/8459/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/8459/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/2 \u0026\u0026 git checkout -b change-8459 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/8459/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"32ad04a7663c0e25ea115aa8e4364c11d345c7a3","subject":"flash/nor/rp2xxx: minor code improvements"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 20:53:36.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-17 14:47:30.000000000","tz":120},"subject":"flash/nor/rp2xxx: drop couple of Java-like const","message":"flash/nor/rp2xxx: drop couple of Java-like const\n\nThe compiler knows what variable remains constant during its lifetime\nand there is no need to emphasise constantness.\n\nChange-Id: Ib515f96a3c77afea87274f33b8ccac7a71bfb932\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"e2b826ea01f2ae4d66e242f613042792070a24c8":{"kind":"REWORK","_number":1,"created":"2024-08-16 21:59:27.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/59/8459/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/8459/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/1 \u0026\u0026 git checkout -b change-8459 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/8459/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"86dfe8c5973d06914acc45745661a137bfbdd4f4","subject":"flash/nor/rp2xxx: minor code improvements"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 20:53:36.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 20:53:36.000000000","tz":120},"subject":"flash/nor/rp2xxx: drop couple of Java-like const","message":"flash/nor/rp2xxx: drop couple of Java-like const\n\nThe compiler knows what variable remains constant during its lifetime\nand there is no need to emphasise constantness.\n\nChange-Id: Ib515f96a3c77afea87274f33b8ccac7a71bfb932\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"a9608871692be6cda4d73ae837b4313747370ff8":{"kind":"REWORK","_number":4,"created":"2025-04-25 09:44:28.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/59/8459/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/8459/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/4 \u0026\u0026 git checkout -b change-8459 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/8459/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/8459/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d29c1c6d6df31f64ae5593babc65cfdffa312def","subject":"flash/nor/rp2xxx: minor code improvements"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 20:53:36.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-04-25 09:44:28.000000000","tz":0},"subject":"flash/nor/rp2xxx: drop couple of Java-like const","message":"flash/nor/rp2xxx: drop couple of Java-like const\n\nThe compiler knows what variable remains constant during its lifetime\nand there is no need to emphasise constantness.\n\nChange-Id: Ib515f96a3c77afea87274f33b8ccac7a71bfb932\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8459\nTested-by: jenkins\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}