)]}'
{"id":"openocd~master~I0e698396003869bee5dde4141d48ddd7d62b3cbc","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2025-04-25 09:44:57.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I0e698396003869bee5dde4141d48ddd7d62b3cbc","subject":"flash/nor/rp2xxx: fix endianness error","status":"MERGED","created":"2024-08-17 15:36:49.000000000","updated":"2025-04-25 09:45:06.000000000","submitted":"2025-04-25 09:45:06.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8460","meta_rev_id":"986449c5c9126c4c49026f57a5a36f9adf4baff5","_number":8460,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-25 09:45:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-04-25 09:45:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-04-25 09:45:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-17 17:38:23.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-17 10:27:52.000000000","updated_by":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"}],"messages":[{"id":"cdfdc0b026f8af40044a108744c4b18b093c5e52","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-17 15:36:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d34da86de78b58e6bb839069a9e900525ab1ac7e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-17 17:38:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19945/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19100/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a663068d97864ef3dab873017ca67037303bdb5b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-01-29 18:10:05.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"4ecd987695b61570069a392d3e58a0b43a195d7a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-01-29 21:06:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20682/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19831/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"82371f1e7b14d647509c8ea2a5fcd60891197c2d","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2025-02-17 10:27:52.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"11257942df18adeb74536eb233b985ff52fd49eb","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-04-25 09:44:57.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"986449c5c9126c4c49026f57a5a36f9adf4baff5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-04-25 09:45:06.000000000","message":"Change has been successfully cherry-picked as f039fe7f9d1ecfc1ca25574d5527c35db119e77b","accounts_in_message":[],"_revision_number":3}],"current_revision":"f039fe7f9d1ecfc1ca25574d5527c35db119e77b","revisions":{"006f0dab2aea2c7ba6a4168624a22992c7eafa3e":{"kind":"REWORK","_number":1,"created":"2024-08-17 15:36:49.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/60/8460/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8460/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/1 \u0026\u0026 git checkout -b change-8460 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8460/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aff48c2d80d55c02cb0eea1f0b29e450b4fd0a66","subject":"flash/nor/rp2xxx: drop couple of Java-like const"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 21:35:06.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-17 14:47:30.000000000","tz":120},"subject":"flash/nor/rp2xxx: fix endianness error","message":"flash/nor/rp2xxx: fix endianness error\n\nstruct rp2xxx_rom_call_batch_record consists of uint32_t in the host\nendianness. Therefore it should be converted to the target endianness\nnot just simply copied by target_write_buffer().\n\nConcatenate algo code, converted batch records and terminator\nto the host resident buffer and copy it at once to the target and\nsave some adapter turnaround times.\n\nWhile on it remove typedef rp2xxx_rom_call_batch_record_t\n\nChange-Id: I0e698396003869bee5dde4141d48ddd7d62b3cbc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"f039fe7f9d1ecfc1ca25574d5527c35db119e77b":{"kind":"REWORK","_number":3,"created":"2025-04-25 09:45:06.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/60/8460/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8460/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/3 \u0026\u0026 git checkout -b change-8460 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8460/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a9608871692be6cda4d73ae837b4313747370ff8","subject":"flash/nor/rp2xxx: drop couple of Java-like const"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 21:35:06.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-04-25 09:45:06.000000000","tz":0},"subject":"flash/nor/rp2xxx: fix endianness error","message":"flash/nor/rp2xxx: fix endianness error\n\nstruct rp2xxx_rom_call_batch_record consists of uint32_t in the host\nendianness. Therefore it should be converted to the target endianness\nnot just simply copied by target_write_buffer().\n\nConcatenate algo code, converted batch records and terminator\nto the host resident buffer and copy it at once to the target and\nsave some adapter turnaround times.\n\nWhile on it remove typedef rp2xxx_rom_call_batch_record_t\n\nChange-Id: I0e698396003869bee5dde4141d48ddd7d62b3cbc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8460\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\nTested-by: jenkins\n"}},"81fe6f44f399fcc7906da8a87302d12b49e99f99":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-01-29 18:10:05.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/60/8460/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8460/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/2 \u0026\u0026 git checkout -b change-8460 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8460/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8460/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd517f233274b3b98b534e83f0cf688991fc981d","subject":"flash/nor/rp2xxx: drop couple of Java-like const"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-08-16 21:35:06.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2025-01-29 18:08:32.000000000","tz":60},"subject":"flash/nor/rp2xxx: fix endianness error","message":"flash/nor/rp2xxx: fix endianness error\n\nstruct rp2xxx_rom_call_batch_record consists of uint32_t in the host\nendianness. Therefore it should be converted to the target endianness\nnot just simply copied by target_write_buffer().\n\nConcatenate algo code, converted batch records and terminator\nto the host resident buffer and copy it at once to the target and\nsave some adapter turnaround times.\n\nWhile on it remove typedef rp2xxx_rom_call_batch_record_t\n\nChange-Id: I0e698396003869bee5dde4141d48ddd7d62b3cbc\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}