)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"change_message_id":"9106c9217385ec2b66169c72b612cc26e28488ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a08d9000_fe097cac","updated":"2024-08-20 13:33:16.000000000","message":"Jan, Antonio - would you kindly take a look? This \"issue\" was detected during backmerge in riscv-openocd repository (looks like we have more \"strict\" checks there)","commit_id":"e9cb50cc0afcb2b7e8034f902166a651b1409ec0"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"dd85c5f29164edec95cdbda1fe58119bf155a579","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ffdd09e_92430ec8","updated":"2024-08-22 10:29:53.000000000","message":"Thanks!","commit_id":"e9cb50cc0afcb2b7e8034f902166a651b1409ec0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"535f96ace1b13005b7719b7dc98d7b2cb6b6d44e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60c17246_5a6f7647","updated":"2024-08-26 16:29:37.000000000","message":"Thanks!\nStrange it didn\u0027t triggered a warning here. Maybe different compiler version.\n\nAlso, we have missed that the variable named `CYCLES_ONE_BATCH` doesn\u0027t follow the coding style, as it requires variables to be lowercase.\nWould you mind sending an additional patch to replace `CYCLES_ONE_BATCH`  with `cycles_one_batch`?","commit_id":"e9cb50cc0afcb2b7e8034f902166a651b1409ec0"},{"author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"change_message_id":"edd090069c4a0826e0e47f45cd0b6b3a490e82eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bbaa6e4a_86882387","in_reply_to":"60c17246_5a6f7647","updated":"2024-08-26 18:55:29.000000000","message":"\u003e Would you mind sending an additional patch to replace CYCLES_ONE_BATCH with cycles_one_batch?\n\nsure! I\u0027ll send a subsequent patch.","commit_id":"e9cb50cc0afcb2b7e8034f902166a651b1409ec0"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"bd3078c2c0b6e31c4dc9e100ab338f0d84cc567a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea067b67_f4deb1b5","in_reply_to":"bbaa6e4a_86882387","updated":"2024-08-26 21:26:17.000000000","message":"\u003e Also, we have missed that the variable named CYCLES_ONE_BATCH doesn\u0027t follow the coding style\n\nAntonio,\n`CYCLES_ONE_BATCH` is a constant (not the first time I seen such use). I admit it has some logic to use upper case as C style guide requires for `#define`d and `enum`ed constants. That why I didn\u0027t complain. Let\u0027s make clear if the variable naming rule applies here. I have no strong preference...","commit_id":"e9cb50cc0afcb2b7e8034f902166a651b1409ec0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a950f6c715fb5ad0af4f34d96c0ca47340edc88d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e528eec_1c38a957","in_reply_to":"ea067b67_f4deb1b5","updated":"2024-08-26 21:50:22.000000000","message":"Tomas,\nI\u0027m just looking at consistency across the code.\nToday we only have 17 hits of const variable with uppercase name:\n`grep -rn \u0027const [^;\u003d[,(]*[A-Z]\u0027 src/`\nover way more cases of lowercase const variables and structs.","commit_id":"e9cb50cc0afcb2b7e8034f902166a651b1409ec0"}]}