)]}'
{"id":"openocd~master~I9b7af698e29ac2c4f5fc8ecd82fa7f4b1a0d43f1","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002247":{"account":{"_account_id":1002247,"name":"Daniel Lizewski","display_name":"Daniel Lizewski","email":"daniellizewski@geotab.com","username":"dlizewski"},"last_update":"2024-09-15 09:07:12.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-09-01 11:23:15.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I9b7af698e29ac2c4f5fc8ecd82fa7f4b1a0d43f1","subject":"src/flash/nor/kinetis.c: Fixed flash bank write gap","status":"MERGED","created":"2024-08-23 12:41:04.000000000","updated":"2024-09-15 09:07:12.000000000","submitted":"2024-09-15 09:07:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8463","meta_rev_id":"687c8aa1df6569a38dce4061f67a76a7c1e13c46","_number":8463,"owner":{"_account_id":1002247,"name":"Daniel Lizewski","display_name":"Daniel Lizewski","email":"daniellizewski@geotab.com","username":"dlizewski"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-15 09:07:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-15 09:07:12.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-15 09:07:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-23 12:54:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-01 09:33:53.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-09-01 09:33:53.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"9402e5df8b80d037b0536ad9935eb6be3f28342e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002247,"name":"Daniel Lizewski","display_name":"Daniel Lizewski","email":"daniellizewski@geotab.com","username":"dlizewski"},"real_author":{"_account_id":1002247,"name":"Daniel Lizewski","display_name":"Daniel Lizewski","email":"daniellizewski@geotab.com","username":"dlizewski"},"date":"2024-08-23 12:41:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"807c6c85ab02c74799e4e9d3c39f607676f4a87d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-23 12:54:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19951/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19106/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1ad01de9c7a9599c7551a0c046db73d97e84a5f9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-01 09:33:53.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e348c282cbf0446e08187d15f20e378aedcf6a0c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-09-01 11:23:15.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"814e06c32eb65368f96917aeaee9ac5184378edc","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-09-01 11:33:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"687c8aa1df6569a38dce4061f67a76a7c1e13c46","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-15 09:07:12.000000000","message":"Change has been successfully cherry-picked as d35399b00e5693d5b6f91208b0f52e5d710d086f","accounts_in_message":[],"_revision_number":2}],"current_revision":"d35399b00e5693d5b6f91208b0f52e5d710d086f","revisions":{"d35399b00e5693d5b6f91208b0f52e5d710d086f":{"kind":"REWORK","_number":2,"created":"2024-09-15 09:07:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/8463/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/8463/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/2 \u0026\u0026 git checkout -b change-8463 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/8463/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f9b1ee521203f0d43b7d84e671ba4e32bd3e599","subject":"tcl/interface/ftdi: add support for Sipeed USB-JTAG/TTL Debugger"}],"author":{"name":"daniellizewski","email":"daniellizewski@geotab.com","date":"2024-08-23 12:31:04.000000000","tz":-240},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-15 09:07:12.000000000","tz":0},"subject":"src/flash/nor/kinetis.c: Fixed flash bank write gap","message":"src/flash/nor/kinetis.c: Fixed flash bank write gap\n\nFlash banks created in kinetis_create_missing_banks did not populate\nbank-\u003eminimal_write_gap. The default value of 0 was interpreted as\nFLASH_WRITE_CONTINUOUS. This created unnecessary large padding if your\nbinary had a gap in the populated flash. It also caused flash errors\nwhen loading with GDB because the erroneously padded pages were not\nerased first. Tested using an S32k148 using s32k.cfg.\n\nChange-Id: I9b7af698e29ac2c4f5fc8ecd82fa7f4b1a0d43f1\nSigned-off-by: daniellizewski \u003cdaniellizewski@geotab.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8463\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"46f57d8bac2501898443b8cd560fde65b9f83d6f":{"kind":"REWORK","_number":1,"created":"2024-08-23 12:41:04.000000000","uploader":{"_account_id":1002247,"name":"Daniel Lizewski","display_name":"Daniel Lizewski","email":"daniellizewski@geotab.com","username":"dlizewski"},"ref":"refs/changes/63/8463/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/8463/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/1 \u0026\u0026 git checkout -b change-8463 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/8463/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/8463/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ac63cd00d792331914db0b6edd3f427c30eec3fa","subject":"tcl/interface/raspberrypi5-gpiod: fix string match pattern escaping"}],"author":{"name":"daniellizewski","email":"daniellizewski@geotab.com","date":"2024-08-23 12:31:04.000000000","tz":-240},"committer":{"name":"daniellizewski","email":"daniellizewski@geotab.com","date":"2024-08-23 12:31:04.000000000","tz":-240},"subject":"src/flash/nor/kinetis.c: Fixed flash bank write gap","message":"src/flash/nor/kinetis.c: Fixed flash bank write gap\n\nFlash banks created in kinetis_create_missing_banks did not populate\nbank-\u003eminimal_write_gap. The default value of 0 was interpreted as\nFLASH_WRITE_CONTINUOUS. This created unnecessary large padding if your\nbinary had a gap in the populated flash. It also caused flash errors\nwhen loading with GDB because the erroneously padded pages were not\nerased first. Tested using an S32k148 using s32k.cfg.\n\nChange-Id: I9b7af698e29ac2c4f5fc8ecd82fa7f4b1a0d43f1\nSigned-off-by: daniellizewski \u003cdaniellizewski@geotab.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}