)]}'
{"id":"openocd~master~I708ef72146d75b7bf429df329a0269cf48700a44","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2024-08-29 08:38:13.000000000","reason":"\u003cGERRIT_ACCOUNT_1001667\u003e replied on the change","reason_account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-09-07 11:37:08.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I708ef72146d75b7bf429df329a0269cf48700a44","subject":"binarybuffer: str_to_buf(): align prefix to TCL syntax","status":"MERGED","created":"2024-08-25 13:47:09.000000000","updated":"2024-09-07 11:37:15.000000000","submitted":"2024-09-07 11:37:15.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8465","meta_rev_id":"fd1d9ac61d4f93bfb139e0d0688e1df4f8ae9ec6","_number":8465,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-07 11:37:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-07 11:37:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-07 11:37:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-25 13:47:09.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2024-08-25 15:23:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"af7fcde34a20d57dad61452d4e021302f34c9278","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 13:47:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c6836553ee9b69d4ce19d5260fe26d65d50ba99b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-25 15:23:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19954/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19109/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d0a71f54ceab6631bed49a909a32a4899982ba68","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 17:25:18.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"94184e3a34d3db89014a15b80e43a33556c7d583","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-08-29 08:38:13.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8fb77d836944b823f8340173bcd880e7c33ade33","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-07 11:37:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fd1d9ac61d4f93bfb139e0d0688e1df4f8ae9ec6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-07 11:37:15.000000000","message":"Change has been successfully cherry-picked as 4680d6ebdf142f9dd1acdc439d4e146ed36a290b","accounts_in_message":[],"_revision_number":2}],"current_revision":"4680d6ebdf142f9dd1acdc439d4e146ed36a290b","revisions":{"088fada7ef7c871ea1da58264cdbf55e51a5584c":{"kind":"REWORK","_number":1,"created":"2024-08-25 13:47:09.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/65/8465/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/8465/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/1 \u0026\u0026 git checkout -b change-8465 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/8465/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e09bb72da50c9a9878565af23ee8d5465c11526d","subject":"target/cortex_m: add DSCSR_CDSKEY bit definition"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-25 13:38:07.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-25 13:44:34.000000000","tz":120},"subject":"binarybuffer: str_to_buf(): align prefix to TCL syntax","message":"binarybuffer: str_to_buf(): align prefix to TCL syntax\n\nInteger values are interpreted by TCL as decimal, binary, octal\nor hexadecimal if prepended with \u00270d\u0027, \u00270b\u0027, \u00270o\u0027 or \u00270x\u0027\nrespectively.\nThe case of \u00270\u0027 prefix has been interpreted as octal till TCL 8.6\nbut is interpreted as part of a decimal number by JimTCL and from\nTCL 9.\n\nAlign str_to_buf() to latest TCL syntax by:\n- addding support for \u00270d\u0027, \u00270b\u0027 and \u00270o\u0027 prefix;\n- dropping support for \u00270\u0027 prefix.\n\nChange-Id: I708ef72146d75b7bf429df329a0269cf48700a44\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"4680d6ebdf142f9dd1acdc439d4e146ed36a290b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-09-07 11:37:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/65/8465/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/8465/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/2 \u0026\u0026 git checkout -b change-8465 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/8465/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/8465/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e09bb72da50c9a9878565af23ee8d5465c11526d","subject":"target/cortex_m: add DSCSR_CDSKEY bit definition"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-25 13:38:07.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-07 11:37:15.000000000","tz":0},"subject":"binarybuffer: str_to_buf(): align prefix to TCL syntax","message":"binarybuffer: str_to_buf(): align prefix to TCL syntax\n\nInteger values are interpreted by TCL as decimal, binary, octal\nor hexadecimal if prepended with \u00270d\u0027, \u00270b\u0027, \u00270o\u0027 or \u00270x\u0027\nrespectively.\nThe case of \u00270\u0027 prefix has been interpreted as octal till TCL 8.6\nbut is interpreted as part of a decimal number by JimTCL and from\nTCL 9.\n\nAlign str_to_buf() to latest TCL syntax by:\n- addding support for \u00270d\u0027, \u00270b\u0027 and \u00270o\u0027 prefix;\n- dropping support for \u00270\u0027 prefix.\n\nChange-Id: I708ef72146d75b7bf429df329a0269cf48700a44\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8465\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}