)]}'
{"id":"openocd~master~I292da62a95a9b414c69cdb1bba8a28dfd16a7336","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001810":{"account":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"last_update":"2024-09-03 21:27:41.000000000","reason":"\u003cGERRIT_ACCOUNT_1001810\u003e replied on the change","reason_account":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"}},"1002312":{"account":{"_account_id":1002312,"name":"Adam Novak","email":"interfect@gmail.com","username":"interfect"},"last_update":"2024-09-07 11:39:22.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I292da62a95a9b414c69cdb1bba8a28dfd16a7336","subject":"cpld: update warning to suggest virtex2 refresh","status":"MERGED","created":"2024-08-26 02:54:42.000000000","updated":"2024-09-07 11:39:22.000000000","submitted":"2024-09-07 11:39:22.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8468","meta_rev_id":"c56e947f911f4f1abb4c4abeb43b1ccd077f677e","_number":8468,"owner":{"_account_id":1002312,"name":"Adam Novak","email":"interfect@gmail.com","username":"interfect"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-07 11:39:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-07 11:39:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-07 11:39:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-26 03:19:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-26 16:20:32.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-08-26 16:20:32.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"state":"REVIEWER"}],"messages":[{"id":"6caa42ce26329cd5794069a455a2805c0a730bac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002312,"name":"Adam Novak","email":"interfect@gmail.com","username":"interfect"},"real_author":{"_account_id":1002312,"name":"Adam Novak","email":"interfect@gmail.com","username":"interfect"},"date":"2024-08-26 02:54:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c63e5eb1a3019bf8c857a21ccee06d66eeb580b4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-26 03:19:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19957/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19112/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5da5751a0d8df98abb14bab5686c0421a79636e6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-26 16:20:32.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dc667513adf94a334a88cda63b356f06edeaa20c","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2024-09-03 21:27:41.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e57157144c7331b30b1f8dfa8f85b55033f3175f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-07 11:39:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c56e947f911f4f1abb4c4abeb43b1ccd077f677e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-07 11:39:22.000000000","message":"Change has been successfully cherry-picked as 324469da57f1b061674ac45a3b1f7fbc3b11fdfe","accounts_in_message":[],"_revision_number":2}],"current_revision":"324469da57f1b061674ac45a3b1f7fbc3b11fdfe","revisions":{"324469da57f1b061674ac45a3b1f7fbc3b11fdfe":{"kind":"REWORK","_number":2,"created":"2024-09-07 11:39:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/8468/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/8468/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/2 \u0026\u0026 git checkout -b change-8468 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/8468/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e271c91516ce106ceec6af952b9e02641b203cd","subject":"flash/stm32l4x: option_write usage: mask is optional"}],"author":{"name":"Adam Novak","email":"interfect@gmail.com","date":"2024-08-26 02:51:22.000000000","tz":-240},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-07 11:39:22.000000000","tz":0},"subject":"cpld: update warning to suggest virtex2 refresh","message":"cpld: update warning to suggest virtex2 refresh\n\nvirtex2 refresh replaced virtex2 program, but the even older programming\ncommands like xc6s_program still suggest the old, now-removed program\ncommand. This changes the warnings to suggest the command that is still\nthere, and also adds some indication that you will need to use the .pld\nname instead of the .tap name.\n\nChange-Id: I292da62a95a9b414c69cdb1bba8a28dfd16a7336\nSigned-off-by: Adam Novak \u003cinterfect@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8468\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\n"}},"b282d4b6912ab37fe1ed85208cefec620d48c7d7":{"kind":"REWORK","_number":1,"created":"2024-08-26 02:54:42.000000000","uploader":{"_account_id":1002312,"name":"Adam Novak","email":"interfect@gmail.com","username":"interfect"},"ref":"refs/changes/68/8468/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/8468/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/1 \u0026\u0026 git checkout -b change-8468 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/8468/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/8468/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e09bb72da50c9a9878565af23ee8d5465c11526d","subject":"target/cortex_m: add DSCSR_CDSKEY bit definition"}],"author":{"name":"Adam Novak","email":"interfect@gmail.com","date":"2024-08-26 02:51:22.000000000","tz":-240},"committer":{"name":"Adam Novak","email":"interfect@gmail.com","date":"2024-08-26 02:51:22.000000000","tz":-240},"subject":"cpld: update warning to suggest virtex2 refresh","message":"cpld: update warning to suggest virtex2 refresh\n\nvirtex2 refresh replaced virtex2 program, but the even older programming\ncommands like xc6s_program still suggest the old, now-removed program\ncommand. This changes the warnings to suggest the command that is still\nthere, and also adds some indication that you will need to use the .pld\nname instead of the .tap name.\n\nChange-Id: I292da62a95a9b414c69cdb1bba8a28dfd16a7336\nSigned-off-by: Adam Novak \u003cinterfect@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}