)]}'
{"id":"openocd~master~I4979e3125ec7d93bbd56eee0096ae1d9c5f6a565","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000097":{"account":{"_account_id":1000097,"name":"Marek Vasut","email":"marek.vasut@gmail.com","username":"marex"},"last_update":"2024-09-07 11:42:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4979e3125ec7d93bbd56eee0096ae1d9c5f6a565","subject":"tcl/target: Make sure R-Car Gen3 _targets variable is global","status":"MERGED","created":"2024-08-30 19:14:26.000000000","updated":"2024-09-07 11:42:25.000000000","submitted":"2024-09-07 11:42:25.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8470","meta_rev_id":"a2bb2fed2ecdbd4825db9596ffd3f3e6ad02aa80","_number":8470,"owner":{"_account_id":1000097,"name":"Marek Vasut","email":"marek.vasut@gmail.com","username":"marex"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-07 11:42:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-07 11:42:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-30 19:27:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-31 13:38:05.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"ae2d9030f86c92a0de1bcc877ad23e12a00f8e25","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000097,"name":"Marek Vasut","email":"marek.vasut@gmail.com","username":"marex"},"real_author":{"_account_id":1000097,"name":"Marek Vasut","email":"marek.vasut@gmail.com","username":"marex"},"date":"2024-08-30 19:14:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d0ea134a82f24d73a32dd3717c596a0148677b35","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-30 19:27:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19967/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19122/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"db3c892cbc6142ffa12f4bc787fd560034d5f0d8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-31 13:38:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2d4282e00d3c7240132d94b479e743fc02d65c7b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-07 11:42:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a2bb2fed2ecdbd4825db9596ffd3f3e6ad02aa80","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-07 11:42:25.000000000","message":"Change has been successfully cherry-picked as cbed09ee9bdbba27ca93f5883b79595f7e9d347d","accounts_in_message":[],"_revision_number":2}],"current_revision":"cbed09ee9bdbba27ca93f5883b79595f7e9d347d","revisions":{"22b2aa458d29981986a9306ecf3127be8f42574c":{"kind":"REWORK","_number":1,"created":"2024-08-30 19:14:26.000000000","uploader":{"_account_id":1000097,"name":"Marek Vasut","email":"marek.vasut@gmail.com","username":"marex"},"ref":"refs/changes/70/8470/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8470/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/1 \u0026\u0026 git checkout -b change-8470 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8470/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e09bb72da50c9a9878565af23ee8d5465c11526d","subject":"target/cortex_m: add DSCSR_CDSKEY bit definition"}],"author":{"name":"Marek Vasut","email":"marek.vasut@gmail.com","date":"2024-08-22 23:29:02.000000000","tz":120},"committer":{"name":"Marek Vasut","email":"marek.vasut@gmail.com","date":"2024-08-30 19:14:09.000000000","tz":120},"subject":"tcl/target: Make sure R-Car Gen3 _targets variable is global","message":"tcl/target: Make sure R-Car Gen3 _targets variable is global\n\nThe _targets has to be global as it is accessed at the end of this file.\nThis is already the case for setup_a5x {}, assure it is the same way for\nsetup_crx{} . Without this change, the _targets at the end of this file\nis empty in case the Cortex-R is the boot core, fix this.\n\nChange-Id: I4979e3125ec7d93bbd56eee0096ae1d9c5f6a565\nSigned-off-by: Marek Vasut \u003cmarek.vasut@gmail.com\u003e\n"}},"cbed09ee9bdbba27ca93f5883b79595f7e9d347d":{"kind":"REWORK","_number":2,"created":"2024-09-07 11:42:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/8470/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8470/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/2 \u0026\u0026 git checkout -b change-8470 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8470/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8470/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"75b418faa7b9849a118c86ccac019d2d9ea235af","subject":"tcl/board: Support for Digilent Anvyl board"}],"author":{"name":"Marek Vasut","email":"marek.vasut@gmail.com","date":"2024-08-22 23:29:02.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-07 11:42:25.000000000","tz":0},"subject":"tcl/target: Make sure R-Car Gen3 _targets variable is global","message":"tcl/target: Make sure R-Car Gen3 _targets variable is global\n\nThe _targets has to be global as it is accessed at the end of this file.\nThis is already the case for setup_a5x {}, assure it is the same way for\nsetup_crx{} . Without this change, the _targets at the end of this file\nis empty in case the Cortex-R is the boot core, fix this.\n\nChange-Id: I4979e3125ec7d93bbd56eee0096ae1d9c5f6a565\nSigned-off-by: Marek Vasut \u003cmarek.vasut@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8470\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}