)]}'
{"id":"openocd~master~Iaa80e9cb1a65c27512919398b8ffbf14e5c240cd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000250":{"account":{"_account_id":1000250,"name":"Matthias Blaicher","email":"matthias@blaicher.com","username":"mabl"},"last_update":"2024-10-05 15:38:23.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iaa80e9cb1a65c27512919398b8ffbf14e5c240cd","subject":"rtos: chibios: fix version display","status":"MERGED","created":"2024-09-01 13:08:03.000000000","updated":"2024-10-05 15:38:23.000000000","submitted":"2024-10-05 15:38:23.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8473","meta_rev_id":"b56db8839c2274344e20378f46ba8e1504b54352","_number":8473,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-10-05 15:38:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-10-05 15:38:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000250,"name":"Matthias Blaicher","email":"matthias@blaicher.com","username":"mabl"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000250,"name":"Matthias Blaicher","email":"matthias@blaicher.com","username":"mabl"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-01 13:09:32.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000250,"name":"Matthias Blaicher","email":"matthias@blaicher.com","username":"mabl"},"state":"REVIEWER"},{"updated":"2024-09-01 13:36:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4439b869bc6ec110c1af004536d77e169f4851a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-01 13:08:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"41aab454cc43d77b2d01bc32ea544d1af70a64c8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-01 13:09:32.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"fa6240bcf599f8045f6590d54a404869bde224f1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-01 13:36:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19972/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19127/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ebb096ae3ec6ddeeb35fcce003ed6dd111ec3e47","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:38:17.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b56db8839c2274344e20378f46ba8e1504b54352","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-10-05 15:38:23.000000000","message":"Change has been successfully cherry-picked as 8edfdb02ed1fd73568ef9e9522634e65791dbd69","accounts_in_message":[],"_revision_number":2}],"current_revision":"8edfdb02ed1fd73568ef9e9522634e65791dbd69","revisions":{"8edfdb02ed1fd73568ef9e9522634e65791dbd69":{"kind":"REWORK","_number":2,"created":"2024-10-05 15:38:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/73/8473/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/8473/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/2 \u0026\u0026 git checkout -b change-8473 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/8473/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1173473f662bbdf6d1499654568256257eee6cdd","subject":"flash/nor/atsame5: add PIC32CX-SG device IDs"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-01 12:45:36.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-10-05 15:38:23.000000000","tz":0},"subject":"rtos: chibios: fix version display","message":"rtos: chibios: fix version display\n\nThe field \u0027struct chibios_chdebug::ch_version\u0027 is 16 bits wide, so\nusing le_to_h_u32() and be_to_h_u32() overflows in the following\nfields of the struct.\n\nRestrict the endianness conversion to 16 bits and use the target\nendianness dependent target_buffer_get_u16().\nConvert the \u0027struct chibios_chdebug::ch_version\u0027 to an array of\nuint8_t.\n\nChange-Id: Iaa80e9cb1a65c27512919398b8ffbf14e5c240cd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8473\nTested-by: jenkins\n"}},"ec73b44e485c674906cae3ad779c3ec6d5a9832a":{"kind":"REWORK","_number":1,"created":"2024-09-01 13:08:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/73/8473/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/8473/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/1 \u0026\u0026 git checkout -b change-8473 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/8473/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/8473/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e09bb72da50c9a9878565af23ee8d5465c11526d","subject":"target/cortex_m: add DSCSR_CDSKEY bit definition"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-01 12:45:36.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-01 13:05:07.000000000","tz":120},"subject":"rtos: chibios: fix version display","message":"rtos: chibios: fix version display\n\nThe field \u0027struct chibios_chdebug::ch_version\u0027 is 16 bits wide, so\nusing le_to_h_u32() and be_to_h_u32() overflows in the following\nfields of the struct.\n\nRestrict the endianness conversion to 16 bits and use the target\nendianness dependent target_buffer_get_u16().\nConvert the \u0027struct chibios_chdebug::ch_version\u0027 to an array of\nuint8_t.\n\nChange-Id: Iaa80e9cb1a65c27512919398b8ffbf14e5c240cd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}