)]}'
{"id":"openocd~master~I9130400aca5dbc54fefb413ed74f27d75fe50640","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2024-09-21 09:05:02.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9130400aca5dbc54fefb413ed74f27d75fe50640","subject":"server/gdb_server: improve error handling for `Z/z` packet","status":"MERGED","created":"2024-09-12 15:58:59.000000000","updated":"2024-09-21 09:05:02.000000000","submitted":"2024-09-21 09:05:02.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8488","meta_rev_id":"20c13490c285a0c71732e891f47dfe99124a21d1","_number":8488,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-21 09:05:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-21 09:05:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-12 16:20:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-14 12:22:23.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"72f574d9afc561fd3be300a95fdbc85f9713c6cb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-12 15:58:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"403558449338a0c201b56568dba13ef69896a7d4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-12 16:20:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20005/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19160/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c8f401e00db3100d19aa419bdefb2c52b85123b1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-14 12:22:23.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"12476530e2dc5a9fae9b2adc0d251c060843b08a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-21 09:04:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"20c13490c285a0c71732e891f47dfe99124a21d1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-21 09:05:02.000000000","message":"Change has been successfully cherry-picked as e6ade35305fa32674d615a26713487b5ad00b352","accounts_in_message":[],"_revision_number":2}],"current_revision":"e6ade35305fa32674d615a26713487b5ad00b352","revisions":{"49b2a71e14c268d2857566531e1578a0a48f05cc":{"kind":"REWORK","_number":1,"created":"2024-09-12 15:58:59.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/88/8488/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/8488/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/1 \u0026\u0026 git checkout -b change-8488 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/8488/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cbed09ee9bdbba27ca93f5883b79595f7e9d347d","subject":"tcl/target: Make sure R-Car Gen3 _targets variable is global"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-09-12 12:16:45.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-09-12 15:58:21.000000000","tz":180},"subject":"server/gdb_server: improve error handling for `Z/z` packet","message":"server/gdb_server: improve error handling for `Z/z` packet\n\n* Report errors for `z` packet.\n* Report not supported types as required by GDB Remote Protocol\u0027s\n  documentation:\n  \u003e Implementation notes: A remote target shall return an empty string\n    for an unrecognized breakpoint or watchpoint packet type.\n\n  Link: https://sourceware.org/gdb/current/onlinedocs/gdb.html/Packets.html#insert-breakpoint-or-watchpoint-packet\n\nChange-Id: I9130400aca5dbc54fefb413ed74f27d75fe50640\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}},"e6ade35305fa32674d615a26713487b5ad00b352":{"kind":"REWORK","_number":2,"created":"2024-09-21 09:05:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/88/8488/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/8488/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/2 \u0026\u0026 git checkout -b change-8488 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/8488/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/8488/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ae6b07b45198618c3f0975fd49de59cf6c04e7a","subject":"binarybuffer: Invert buf_cmp* return value and rename to buf_eq*"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-09-12 12:16:45.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-21 09:05:02.000000000","tz":0},"subject":"server/gdb_server: improve error handling for `Z/z` packet","message":"server/gdb_server: improve error handling for `Z/z` packet\n\n* Report errors for `z` packet.\n* Report not supported types as required by GDB Remote Protocol\u0027s\n  documentation:\n  \u003e Implementation notes: A remote target shall return an empty string\n    for an unrecognized breakpoint or watchpoint packet type.\n\n  Link: https://sourceware.org/gdb/current/onlinedocs/gdb.html/Packets.html#insert-breakpoint-or-watchpoint-packet\n\nChange-Id: I9130400aca5dbc54fefb413ed74f27d75fe50640\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8488\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}