)]}'
{"id":"openocd~master~Ic4f7ed094429abc4c06a775eb847a8b3ddf2e2d6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002319":{"account":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"last_update":"2024-09-15 09:22:44.000000000","reason":"Change was submitted"},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2024-09-15 09:22:44.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-09-15 09:22:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic4f7ed094429abc4c06a775eb847a8b3ddf2e2d6","subject":"binarybuffer: Fix inverted return value in buf_cmp","status":"MERGED","created":"2024-09-12 19:13:31.000000000","updated":"2024-09-15 09:22:44.000000000","submitted":"2024-09-15 09:22:44.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":10,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"8489","meta_rev_id":"cb5a6b109f9171e31d5a3e5008fcbb5e82522fe0","_number":8489,"owner":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-15 09:22:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-15 09:22:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-15 09:22:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-15 09:22:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-12 19:26:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-13 07:37:08.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-09-13 07:42:23.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-09-13 09:22:23.000000000","updated_by":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"reviewer":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"state":"CC"},{"updated":"2024-09-13 10:01:28.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"}],"messages":[{"id":"705e5303a730b8bcb28fb063bbf10078788f498e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"real_author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"date":"2024-09-12 19:13:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b47c4e9f6f2d4c5c06322755180dc7124afb5bfe","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-12 19:26:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20006/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19161/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"27e68c7afa374491e6fd8dbfcfb8823ec6ff7b54","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-09-13 07:37:08.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d6b90d343ff15d5b04314c4f4c9838328b7bbbd2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-13 07:42:23.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6195d5d38ec581576c7af8107e0496148e956d8d","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2024-09-13 09:22:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"84663c46dde1b4cb1af742266d023a5962140aed","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-13 10:01:28.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"effcc6cedf1b67001930bd4cdfda4b3facd46a9f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-09-13 10:13:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"60703a3eb615720e2963d7c325f9692de8c40d4e","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-13 10:32:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7809c96cb495bf752893f98bca66c0df27268236","author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"real_author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"date":"2024-09-13 16:51:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f7d4ba62b7b3ab778883519752a10041b7468eb3","author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"real_author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"date":"2024-09-13 17:11:55.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4762f9b915d1e0fb7c229b5ff7663258da746d1e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-15 09:22:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cb5a6b109f9171e31d5a3e5008fcbb5e82522fe0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-15 09:22:44.000000000","message":"Change has been successfully cherry-picked as fd7b66c5eb038185b72953821204ec9bb8ce49d1","accounts_in_message":[],"_revision_number":2}],"current_revision":"fd7b66c5eb038185b72953821204ec9bb8ce49d1","revisions":{"fd7b66c5eb038185b72953821204ec9bb8ce49d1":{"kind":"REWORK","_number":2,"created":"2024-09-15 09:22:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/89/8489/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/8489/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/2 \u0026\u0026 git checkout -b change-8489 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/8489/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"63ca9670321c1c057ee32e9925826f9f8c836005","subject":"README: Use proper Markdown syntax"}],"author":{"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","date":"2024-09-12 19:12:05.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-15 09:22:44.000000000","tz":0},"subject":"binarybuffer: Fix inverted return value in buf_cmp","message":"binarybuffer: Fix inverted return value in buf_cmp\n\nThis is the fast path for when there is a mismatch in the leading whole\nbytes, which means we should return true to indicate not equal like all\nthe other cases here and in the surrounding functions. Otherwise we\u0027ll\nincorrectly report _buf1 \u003d\u003d _buf2 if and only if there are mismatches in\nthe leading whole bytes.\n\nThis was introduced during the refactor and optimisation referenced\nbelow.\n\nThe only in-tree caller of this is jtag_check_value_inner, which will\njust fail to catch some errors. However, downstream in riscv-openocd it\ngets used in the riscv target to determine whether an IR scan is needed\nto select the debug module, and with an IRLEN \u003e\u003d 8 this breaks resetting\nif the encoding for the DMI isn\u0027t all-ones in its leading whole bytes\n(to match BYPASS), since it will believe they are the same and not do an\nIR scan, failing (with \"At least one TAP shouldn\u0027t be in BYPASS mode\")\nin the subsequent DR scan due to the TAP still being recorded as having\nbypass set (and really having an instruction of either BYPASS or\nIDCODE).\n\nFixes: e4ee891759b0 (\"improve buf_cmp and buf_cmp_mask helpers\")\nChange-Id: Ic4f7ed094429abc4c06a775eb847a8b3ddf2e2d6\nSigned-off-by: Jessica Clarke \u003cjrtc27@jrtc27.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8489\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"7538deb70bdce9d16295c34e7fc5b62a0a9061b0":{"kind":"REWORK","_number":1,"created":"2024-09-12 19:13:31.000000000","uploader":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"ref":"refs/changes/89/8489/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/8489/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/1 \u0026\u0026 git checkout -b change-8489 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/8489/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/8489/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cbed09ee9bdbba27ca93f5883b79595f7e9d347d","subject":"tcl/target: Make sure R-Car Gen3 _targets variable is global"}],"author":{"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","date":"2024-09-12 19:12:05.000000000","tz":60},"committer":{"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","date":"2024-09-12 19:12:05.000000000","tz":60},"subject":"binarybuffer: Fix inverted return value in buf_cmp","message":"binarybuffer: Fix inverted return value in buf_cmp\n\nThis is the fast path for when there is a mismatch in the leading whole\nbytes, which means we should return true to indicate not equal like all\nthe other cases here and in the surrounding functions. Otherwise we\u0027ll\nincorrectly report _buf1 \u003d\u003d _buf2 if and only if there are mismatches in\nthe leading whole bytes.\n\nThis was introduced during the refactor and optimisation referenced\nbelow.\n\nThe only in-tree caller of this is jtag_check_value_inner, which will\njust fail to catch some errors. However, downstream in riscv-openocd it\ngets used in the riscv target to determine whether an IR scan is needed\nto select the debug module, and with an IRLEN \u003e\u003d 8 this breaks resetting\nif the encoding for the DMI isn\u0027t all-ones in its leading whole bytes\n(to match BYPASS), since it will believe they are the same and not do an\nIR scan, failing (with \"At least one TAP shouldn\u0027t be in BYPASS mode\")\nin the subsequent DR scan due to the TAP still being recorded as having\nbypass set (and really having an instruction of either BYPASS or\nIDCODE).\n\nFixes: e4ee891759b0 (\"improve buf_cmp and buf_cmp_mask helpers\")\nChange-Id: Ic4f7ed094429abc4c06a775eb847a8b3ddf2e2d6\nSigned-off-by: Jessica Clarke \u003cjrtc27@jrtc27.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}