)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"dd9c05ea352a4a814501259e56510f6e8d97a9b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e7c3777_416566e6","updated":"2024-09-13 17:37:18.000000000","message":"LGTM","commit_id":"75bca35108ed9ca5bc9aabe33b13bc84e6646c65"},{"author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"change_message_id":"4cc9c276f35521401d36c9fa6b7153c33acd763b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa46fce4_1b335e0e","updated":"2024-09-13 17:13:29.000000000","message":"Please check this very carefully, it\u0027s possible I\u0027ve made a mistake (and nearly made one that I then caught) and would hate to introduce the kind of bug I just fixed!","commit_id":"75bca35108ed9ca5bc9aabe33b13bc84e6646c65"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"901a4ebd4bcbef73c4fccd04b6715c9fccd993a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4fe45366_dcae14ed","updated":"2024-09-14 12:03:31.000000000","message":"Thanks, I agree this makes the code easier to read.\n\nRegarding the \u0027unsigned\u0027 vs \u0027unsigned int\u0027, the coding style reports:\n`prefer type \"unsigned int\" to type \"unsigned\"`\n\nUsually the fix get required by the patch that has to change the code, but I have already queued commit https://review.openocd.org/c/openocd/+/8482\nto fix these files.\nNo need for you to send a new version.\nI will first merge this patch, then re-generated 8482.","commit_id":"f95ee292ada90c02f6413d277a9a74f513f87215"}],"src/helper/binarybuffer.h":[{"author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"change_message_id":"f12b5bb511512effe476fe990051e6c0e9a1296c","unresolved":true,"context_lines":[{"line_number":168,"context_line":" */"},{"line_number":169,"context_line":"uint32_t flip_u32(uint32_t value, unsigned width);"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"bool buf_eq(const void *buf1, const void *buf2, unsigned size);"},{"line_number":172,"context_line":"bool buf_eq_mask(const void *buf1, const void *buf2,"},{"line_number":173,"context_line":"\t\tconst void *mask, unsigned size);"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9a4dec82_3a630e02","line":171,"updated":"2024-09-13 17:16:13.000000000","message":"checkpatch doesn\u0027t like the existing bare unsigned\u0027s in lines I\u0027ve touched; I\u0027ve left them alone to minimise the diff, but don\u0027t know if the preference would be to fix them instead.","commit_id":"75bca35108ed9ca5bc9aabe33b13bc84e6646c65"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"dd9c05ea352a4a814501259e56510f6e8d97a9b2","unresolved":true,"context_lines":[{"line_number":168,"context_line":" */"},{"line_number":169,"context_line":"uint32_t flip_u32(uint32_t value, unsigned width);"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"bool buf_eq(const void *buf1, const void *buf2, unsigned size);"},{"line_number":172,"context_line":"bool buf_eq_mask(const void *buf1, const void *buf2,"},{"line_number":173,"context_line":"\t\tconst void *mask, unsigned size);"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"716a5c03_2a8e0434","line":171,"in_reply_to":"9a4dec82_3a630e02","updated":"2024-09-13 17:37:18.000000000","message":"\u003e I\u0027ve left them alone\n\nIf so, consider adding\n```\nCheckpatch-ignore: UNSPECIFIED_INT\n```\n\nto the footer of your commit message, so that the check doesn\u0027t fail.","commit_id":"75bca35108ed9ca5bc9aabe33b13bc84e6646c65"}]}