)]}'
{"id":"openocd~master~Iee0c5af794316aab5327cb9c168051fabd3bc1cb","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002319":{"account":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"last_update":"2024-09-21 09:04:06.000000000","reason":"Change was submitted"},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2024-09-16 11:48:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1002047\u003e replied on the change","reason_account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}}},"hashtags":[],"change_id":"Iee0c5af794316aab5327cb9c168051fabd3bc1cb","subject":"binarybuffer: Invert buf_cmp* return value and rename to buf_eq*","status":"MERGED","created":"2024-09-13 17:11:15.000000000","updated":"2024-09-21 09:04:06.000000000","submitted":"2024-09-21 09:04:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"8490","meta_rev_id":"ade550b96715966cd63cfb50d5e4782dc49a1240","_number":8490,"owner":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-21 09:04:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-21 09:04:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-21 09:04:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-13 17:12:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-13 17:37:18.000000000","updated_by":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2024-09-14 12:03:31.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"b5a62008dadc52ef73bbf8e1ae113c8321172f7c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"real_author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"date":"2024-09-13 17:11:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"057687e7abb6548ed95f7b424e88a539a7f45fd4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-13 17:12:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/20007/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19162/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"4cc9c276f35521401d36c9fa6b7153c33acd763b","author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"real_author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"date":"2024-09-13 17:13:29.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f12b5bb511512effe476fe990051e6c0e9a1296c","author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"real_author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"date":"2024-09-13 17:16:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dd9c05ea352a4a814501259e56510f6e8d97a9b2","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-13 17:37:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f5e2a6366cd6a4592cf8e8a1a701e309d692e264","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"real_author":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"date":"2024-09-13 17:38:58.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ba133974fa4cb471e5b6e2f525fbd8b9598ae1e5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-09-13 18:17:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/20008/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19163/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"901a4ebd4bcbef73c4fccd04b6715c9fccd993a2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-14 12:03:31.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cf224f838879d50b4102e6f47ca384ff4e845c92","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-09-16 11:48:21.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a89508921fa1f24cbf3de56cfc799add27a23e66","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-21 09:03:54.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ade550b96715966cd63cfb50d5e4782dc49a1240","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-21 09:04:06.000000000","message":"Change has been successfully cherry-picked as 1ae6b07b45198618c3f0975fd49de59cf6c04e7a","accounts_in_message":[],"_revision_number":3}],"current_revision":"1ae6b07b45198618c3f0975fd49de59cf6c04e7a","revisions":{"75bca35108ed9ca5bc9aabe33b13bc84e6646c65":{"kind":"REWORK","_number":1,"created":"2024-09-13 17:11:15.000000000","uploader":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"ref":"refs/changes/90/8490/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/90/8490/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/1 \u0026\u0026 git checkout -b change-8490 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/90/8490/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7538deb70bdce9d16295c34e7fc5b62a0a9061b0","subject":"binarybuffer: Fix inverted return value in buf_cmp"}],"author":{"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","date":"2024-09-13 17:10:48.000000000","tz":60},"committer":{"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","date":"2024-09-13 17:10:48.000000000","tz":60},"subject":"binarybuffer: Invert buf_cmp* return value and rename to buf_eq*","message":"binarybuffer: Invert buf_cmp* return value and rename to buf_eq*\n\nThe current semantics are a bit confusing, as the return value looks\nlike memcmp (0/false being equal) but the bool return type means one\nlikely expects true to mean equal. Make this clearer by switching them\nout for buf_eq* functions that do that instead.\n\nChange-Id: Iee0c5af794316aab5327cb9c168051fabd3bc1cb\nSigned-off-by: Jessica Clarke \u003cjrtc27@jrtc27.com\u003e\n"}},"1ae6b07b45198618c3f0975fd49de59cf6c04e7a":{"kind":"REWORK","_number":3,"created":"2024-09-21 09:04:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/90/8490/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/90/8490/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/3 \u0026\u0026 git checkout -b change-8490 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/90/8490/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5159c599157cc878521ae64e836675f7939c6a09","subject":"src/rtos/rtos_nuttx_stackings.c: Fix stack alignment for cortex-m targets"}],"author":{"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","date":"2024-09-13 17:10:48.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-21 09:04:06.000000000","tz":0},"subject":"binarybuffer: Invert buf_cmp* return value and rename to buf_eq*","message":"binarybuffer: Invert buf_cmp* return value and rename to buf_eq*\n\nThe current semantics are a bit confusing, as the return value looks\nlike memcmp (0/false being equal) but the bool return type means one\nlikely expects true to mean equal. Make this clearer by switching them\nout for buf_eq* functions that do that instead.\n\nCheckpatch-ignore: UNSPECIFIED_INT\nChange-Id: Iee0c5af794316aab5327cb9c168051fabd3bc1cb\nSigned-off-by: Jessica Clarke \u003cjrtc27@jrtc27.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8490\nTested-by: jenkins\nReviewed-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f95ee292ada90c02f6413d277a9a74f513f87215":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-09-13 17:38:58.000000000","uploader":{"_account_id":1002319,"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","username":"jrtc27"},"ref":"refs/changes/90/8490/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/90/8490/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/2 \u0026\u0026 git checkout -b change-8490 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/90/8490/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/90/8490/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7538deb70bdce9d16295c34e7fc5b62a0a9061b0","subject":"binarybuffer: Fix inverted return value in buf_cmp"}],"author":{"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","date":"2024-09-13 17:10:48.000000000","tz":60},"committer":{"name":"Jessica Clarke","email":"jrtc27@jrtc27.com","date":"2024-09-13 17:38:27.000000000","tz":60},"subject":"binarybuffer: Invert buf_cmp* return value and rename to buf_eq*","message":"binarybuffer: Invert buf_cmp* return value and rename to buf_eq*\n\nThe current semantics are a bit confusing, as the return value looks\nlike memcmp (0/false being equal) but the bool return type means one\nlikely expects true to mean equal. Make this clearer by switching them\nout for buf_eq* functions that do that instead.\n\nCheckpatch-ignore: UNSPECIFIED_INT\nChange-Id: Iee0c5af794316aab5327cb9c168051fabd3bc1cb\nSigned-off-by: Jessica Clarke \u003cjrtc27@jrtc27.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}